* [PATCH] hwspinlock: sirf: Remove the redundant 'of_match_ptr'
@ 2020-06-08 12:20 Baolin Wang
2020-07-10 6:08 ` Barry Song
0 siblings, 1 reply; 2+ messages in thread
From: Baolin Wang @ 2020-06-08 12:20 UTC (permalink / raw)
To: ohad, bjorn.andersson
Cc: baolin.wang7, baohua, linux-remoteproc, linux-kernel, linux-arm-kernel
Remove the the redundant 'of_match_ptr' macro to fix below warning
when the CONFIG_OF is not selected.
All warnings:
drivers/hwspinlock/sirf_hwspinlock.c:87:34: warning: unused variable
'sirf_hwpinlock_ids' [-Wunused-const-variable]
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Baolin Wang <baolin.wang7@gmail.com>
---
drivers/hwspinlock/sirf_hwspinlock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwspinlock/sirf_hwspinlock.c b/drivers/hwspinlock/sirf_hwspinlock.c
index 823d3c4f621e..a3f77120bad7 100644
--- a/drivers/hwspinlock/sirf_hwspinlock.c
+++ b/drivers/hwspinlock/sirf_hwspinlock.c
@@ -94,7 +94,7 @@ static struct platform_driver sirf_hwspinlock_driver = {
.probe = sirf_hwspinlock_probe,
.driver = {
.name = "atlas7_hwspinlock",
- .of_match_table = of_match_ptr(sirf_hwpinlock_ids),
+ .of_match_table = sirf_hwpinlock_ids,
},
};
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwspinlock: sirf: Remove the redundant 'of_match_ptr'
2020-06-08 12:20 [PATCH] hwspinlock: sirf: Remove the redundant 'of_match_ptr' Baolin Wang
@ 2020-07-10 6:08 ` Barry Song
0 siblings, 0 replies; 2+ messages in thread
From: Barry Song @ 2020-07-10 6:08 UTC (permalink / raw)
To: Baolin Wang
Cc: Ohad Ben-Cohen, linux-remoteproc, LKML, linux-arm-kernel,
bjorn.andersson
Baolin Wang <baolin.wang7@gmail.com> 于2020年6月9日周二 上午12:22写道:
>
> Remove the the redundant 'of_match_ptr' macro to fix below warning
> when the CONFIG_OF is not selected.
>
> All warnings:
> drivers/hwspinlock/sirf_hwspinlock.c:87:34: warning: unused variable
> 'sirf_hwpinlock_ids' [-Wunused-const-variable]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Baolin Wang <baolin.wang7@gmail.com>
> ---
> drivers/hwspinlock/sirf_hwspinlock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwspinlock/sirf_hwspinlock.c b/drivers/hwspinlock/sirf_hwspinlock.c
> index 823d3c4f621e..a3f77120bad7 100644
> --- a/drivers/hwspinlock/sirf_hwspinlock.c
> +++ b/drivers/hwspinlock/sirf_hwspinlock.c
> @@ -94,7 +94,7 @@ static struct platform_driver sirf_hwspinlock_driver = {
> .probe = sirf_hwspinlock_probe,
> .driver = {
> .name = "atlas7_hwspinlock",
> - .of_match_table = of_match_ptr(sirf_hwpinlock_ids),
> + .of_match_table = sirf_hwpinlock_ids,
is it better to do?
#ifdef CONFIG_OF
static const struct of_device_id sirf_hwpinlock_ids[] = {
{ .compatible = "sirf,hwspinlock", },
{},
};
MODULE_DEVICE_TABLE(of, sirf_hwpinlock_ids);
#endif
> },
> };
>
> --
> 2.17.1
Thanks
barry
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-10 6:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-08 12:20 [PATCH] hwspinlock: sirf: Remove the redundant 'of_match_ptr' Baolin Wang
2020-07-10 6:08 ` Barry Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).