linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v5 2/4] pwm: sirf: add dt-binding document
@ 2014-07-16  2:01 Huayi Li
  2014-07-24 10:08 ` Barry Song
  0 siblings, 1 reply; 2+ messages in thread
From: Huayi Li @ 2014-07-16  2:01 UTC (permalink / raw)
  To: linux-arm-kernel

This patch adds dt-binding document for pwm-sirf. here the controller clock
can't generate PWM signals, so we need seperate clock as signal source.

Signed-off-by: Huayi Li <huayi.li@csr.com>
---
 Documentation/devicetree/bindings/pwm/pwm-sirf.txt | 29 ++++++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pwm/pwm-sirf.txt

diff --git a/Documentation/devicetree/bindings/pwm/pwm-sirf.txt b/Documentation/devicetree/bindings/pwm/pwm-sirf.txt
new file mode 100644
index 0000000..221e5d9
--- /dev/null
+++ b/Documentation/devicetree/bindings/pwm/pwm-sirf.txt
@@ -0,0 +1,29 @@
+SiRF prima2 & atlas6 PWM drivers
+
+Required properties:
+- compatible: "sirf,prima2-pwm"
+- reg: physical base address and length of the controller's registers
+- #pwm-cells: should be 2. See pwm.txt in this directory for a description of
+  the cells format.
+- clocks: Must contain an entry for each entry in clock-names.
+  See ../clock/prima2-clock.txt for details.
+- clock-names: Must include the following entries:
+  of clock sources to generate PWM signal,
+  - pwmc: PWM controller clock
+  - sigsrc0: source clock 0 for PWM
+  - sigsrc1: source clock 1 for PWM
+  - sigsrc2: source clock 2 for PWM
+  - sigsrc3: source clock 3 for PWM
+  - sigsrc4: source clock 4 for PWM
+
+Example:
+
+pwm: pwm at b0130000 {
+	compatible = "sirf,prima2-pwm";
+	#pwm-cells = <2>;
+	reg = <0xb0130000 0x10000>;
+	clocks = <&clks 21>, <&clks 1>, <&clks 2>,
+	       <&clks 3>, <&clks 0>, <&clks 4>;
+	clock-names = "pwmc", "sigsrc0", "sigsrc1",
+		"sigsrc2", "sigsrc3", "sigsrc4";
+};
-- 
1.9.3



Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Keep up to date with CSR on our technical blog, www.csr.com/blog, CSR people blog, www.csr.com/people, YouTube, www.youtube.com/user/CSRplc, Facebook, www.facebook.com/pages/CSR/191038434253534, or follow us on Twitter at www.twitter.com/CSR_plc.
New for 2014, you can now access the wide range of products powered by aptX at www.aptx.com.

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH v5 2/4] pwm: sirf: add dt-binding document
  2014-07-16  2:01 [PATCH v5 2/4] pwm: sirf: add dt-binding document Huayi Li
@ 2014-07-24 10:08 ` Barry Song
  0 siblings, 0 replies; 2+ messages in thread
From: Barry Song @ 2014-07-24 10:08 UTC (permalink / raw)
  To: linux-arm-kernel

2014-07-16 10:01 GMT+08:00 Huayi Li <huayi.li@csr.com>:
> This patch adds dt-binding document for pwm-sirf. here the controller clock
> can't generate PWM signals, so we need seperate clock as signal source.
>
> Signed-off-by: Huayi Li <huayi.li@csr.com>

Reviewed-by: Barry Song <Baohua.Song@csr.com>

except that the commit log has not explained enough clearly that every
pwm channel can choice one from five clock sources to generate PWM
wave.

> ---
>  Documentation/devicetree/bindings/pwm/pwm-sirf.txt | 29 ++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pwm/pwm-sirf.txt
>
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-sirf.txt b/Documentation/devicetree/bindings/pwm/pwm-sirf.txt
> new file mode 100644
> index 0000000..221e5d9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/pwm-sirf.txt
> @@ -0,0 +1,29 @@
> +SiRF prima2 & atlas6 PWM drivers
> +
> +Required properties:
> +- compatible: "sirf,prima2-pwm"
> +- reg: physical base address and length of the controller's registers
> +- #pwm-cells: should be 2. See pwm.txt in this directory for a description of
> +  the cells format.
> +- clocks: Must contain an entry for each entry in clock-names.
> +  See ../clock/prima2-clock.txt for details.
> +- clock-names: Must include the following entries:
> +  of clock sources to generate PWM signal,
> +  - pwmc: PWM controller clock
> +  - sigsrc0: source clock 0 for PWM
> +  - sigsrc1: source clock 1 for PWM
> +  - sigsrc2: source clock 2 for PWM
> +  - sigsrc3: source clock 3 for PWM
> +  - sigsrc4: source clock 4 for PWM
> +
> +Example:
> +
> +pwm: pwm at b0130000 {
> +       compatible = "sirf,prima2-pwm";
> +       #pwm-cells = <2>;
> +       reg = <0xb0130000 0x10000>;
> +       clocks = <&clks 21>, <&clks 1>, <&clks 2>,
> +              <&clks 3>, <&clks 0>, <&clks 4>;
> +       clock-names = "pwmc", "sigsrc0", "sigsrc1",
> +               "sigsrc2", "sigsrc3", "sigsrc4";
> +};
> --
> 1.9.3
>

-barry

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-24 10:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-16  2:01 [PATCH v5 2/4] pwm: sirf: add dt-binding document Huayi Li
2014-07-24 10:08 ` Barry Song

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).