From: Markus Mayer <mmayer@broadcom.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Broadcom Kernel Team <bcm-kernel-feedback-list@broadcom.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Linux ARM Kernel <linux-arm-kernel@lists.infradead.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH 6/7] memory: brcmstb_dpfe: simplify platform_get_resource_byname()
Date: Tue, 26 Apr 2022 09:52:05 -0700 [thread overview]
Message-ID: <CAGt4E5tyGQStKT3S=tUg8CLchzS3S3g8Byh2Kap9oids=jF-UQ@mail.gmail.com> (raw)
In-Reply-To: <20220419142859.380566-6-krzysztof.kozlowski@linaro.org>
On Tue, 19 Apr 2022 at 07:29, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Use devm_platform_ioremap_resource_byname() instead of
> platform_get_resource_byname() and devm_ioremap_resource().
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thanks for the change.
Acked-by: Markus Mayer <mmayer@broadcom.com>
Regards,
-Markus
> ---
> drivers/memory/brcmstb_dpfe.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c
> index 14412002775d..76c82e9c8fce 100644
> --- a/drivers/memory/brcmstb_dpfe.c
> +++ b/drivers/memory/brcmstb_dpfe.c
> @@ -857,7 +857,6 @@ static int brcmstb_dpfe_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct brcmstb_dpfe_priv *priv;
> - struct resource *res;
> int ret;
>
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> @@ -869,22 +868,19 @@ static int brcmstb_dpfe_probe(struct platform_device *pdev)
> mutex_init(&priv->lock);
> platform_set_drvdata(pdev, priv);
>
> - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dpfe-cpu");
> - priv->regs = devm_ioremap_resource(dev, res);
> + priv->regs = devm_platform_ioremap_resource_byname(pdev, "dpfe-cpu");
> if (IS_ERR(priv->regs)) {
> dev_err(dev, "couldn't map DCPU registers\n");
> return -ENODEV;
> }
>
> - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dpfe-dmem");
> - priv->dmem = devm_ioremap_resource(dev, res);
> + priv->dmem = devm_platform_ioremap_resource_byname(pdev, "dpfe-dmem");
> if (IS_ERR(priv->dmem)) {
> dev_err(dev, "Couldn't map DCPU data memory\n");
> return -ENOENT;
> }
>
> - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dpfe-imem");
> - priv->imem = devm_ioremap_resource(dev, res);
> + priv->imem = devm_platform_ioremap_resource_byname(pdev, "dpfe-imem");
> if (IS_ERR(priv->imem)) {
> dev_err(dev, "Couldn't map DCPU instruction memory\n");
> return -ENOENT;
> --
> 2.32.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-26 16:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 14:28 [PATCH 1/7] memory: da8xx-ddrctl: simplify platform_get_resource() Krzysztof Kozlowski
2022-04-19 14:28 ` [PATCH 2/7] memory: emif: " Krzysztof Kozlowski
2022-04-19 14:28 ` [PATCH 3/7] memory: ti-emif: " Krzysztof Kozlowski
2022-04-19 14:28 ` [PATCH 4/7] memory: ti-emif-pm: " Krzysztof Kozlowski
2022-04-19 14:28 ` [PATCH 5/7] memory: tegra: mc: " Krzysztof Kozlowski
2022-04-19 14:28 ` [PATCH 6/7] memory: brcmstb_dpfe: simplify platform_get_resource_byname() Krzysztof Kozlowski
2022-04-26 16:52 ` Markus Mayer [this message]
2022-04-19 14:28 ` [PATCH 7/7] memory: renesas-rpc-if: " Krzysztof Kozlowski
2022-04-26 7:49 ` [PATCH 1/7] memory: da8xx-ddrctl: simplify platform_get_resource() Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGt4E5tyGQStKT3S=tUg8CLchzS3S3g8Byh2Kap9oids=jF-UQ@mail.gmail.com' \
--to=mmayer@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=ssantosh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).