From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Hawa, Hanna" <hhhawa@amazon.com>
Cc: Tony Lindgren <tony@atomide.com>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
David Woodhouse <dwmw@amazon.co.uk>,
benh@amazon.com, ronenk@amazon.com, talel@amazon.com,
jonnyc@amazon.com, hanochu@amazon.com, tgershi@amazon.com,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] pinctrl: pinctrl-single: fix pcs_pin_dbg_show() when bits_per_mux is not zero
Date: Fri, 19 Mar 2021 12:04:08 +0200 [thread overview]
Message-ID: <CAHp75Vc-5DxJC41+ATVjuczGgdHkDkukvpFzi0bWH5GD7uMfHg@mail.gmail.com> (raw)
In-Reply-To: <cd589749-7f37-9f7f-9d36-42032c724506@amazon.com>
On Fri, Mar 19, 2021 at 9:53 AM Hawa, Hanna <hhhawa@amazon.com> wrote:
> On 3/18/2021 2:15 PM, Andy Shevchenko wrote:
> > On Wed, Mar 17, 2021 at 11:42 PM Hanna Hawa<hhhawa@amazon.com> wrote:
> >> An SError was detected when trying to print the supported pins in a
> > What is SError? Yes, I have read a discussion, but here is the hint:
> > if a person sees this as a first text due to, for example, bisecting
> > an issue, what she/he can get from this cryptic name?
>
> What you suggest?
> s/An SError/A kernel-panic/?
Not below, but something which makes clear what SError is.
Like "A System Error (SError, followed by kernel panic) ..."
> Or remove the sentence and keep the below:
> "
> This change fixes the pcs_pin_dbg_show() in pinctrl-single driver when
> bits_per_mux is not zero. In addition move offset calculation and pin
> offset in register to common function.
> "
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-03-19 10:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 21:41 [PATCH v2 0/3] Fix pinctrl-single pcs_pin_dbg_show() Hanna Hawa
2021-03-17 21:41 ` [PATCH v3 1/3] pinctrl: pinctrl-single: remove unused variable Hanna Hawa
2021-03-17 21:41 ` [PATCH v3 2/3] pinctrl: pinctrl-single: remove unused parameter Hanna Hawa
2021-03-17 21:41 ` [PATCH v3 3/3] pinctrl: pinctrl-single: fix pcs_pin_dbg_show() when bits_per_mux is not zero Hanna Hawa
2021-03-18 12:15 ` Andy Shevchenko
2021-03-19 7:52 ` Hawa, Hanna
2021-03-19 10:04 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vc-5DxJC41+ATVjuczGgdHkDkukvpFzi0bWH5GD7uMfHg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=benh@amazon.com \
--cc=dwmw@amazon.co.uk \
--cc=hanochu@amazon.com \
--cc=haojian.zhuang@linaro.org \
--cc=hhhawa@amazon.com \
--cc=jonnyc@amazon.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
--cc=tgershi@amazon.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).