* [PATCH] regulator: mt6360: Fix missing IRQF_ONESHOT as only threaded handler
@ 2021-04-16 3:47 zhuguangqing83
2021-04-16 8:45 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: zhuguangqing83 @ 2021-04-16 3:47 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Matthias Brugger
Cc: linux-kernel, linux-arm-kernel, linux-mediatek, Guangqing Zhu
From: Guangqing Zhu <zhuguangqing83@gmail.com>
Coccinelle noticed:
drivers/regulator/mt6360-regulator.c:386:8-33: ERROR: Threaded IRQ with no
primary handler requested without IRQF_ONESHOT
Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com>
---
drivers/regulator/mt6360-regulator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/mt6360-regulator.c b/drivers/regulator/mt6360-regulator.c
index 4d34be94d166..34c354721ef0 100644
--- a/drivers/regulator/mt6360-regulator.c
+++ b/drivers/regulator/mt6360-regulator.c
@@ -383,8 +383,8 @@ static int mt6360_regulator_irq_register(struct platform_device *pdev,
if (irq < 0)
return irq;
- ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, irq_desc->handler, 0,
- irq_desc->name, rdev);
+ ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, irq_desc->handler,
+ IRQF_ONESHOT, irq_desc->name, rdev);
if (ret) {
dev_err(&pdev->dev, "Fail to request %s irq\n", irq_desc->name);
return ret;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator: mt6360: Fix missing IRQF_ONESHOT as only threaded handler
2021-04-16 3:47 [PATCH] regulator: mt6360: Fix missing IRQF_ONESHOT as only threaded handler zhuguangqing83
@ 2021-04-16 8:45 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2021-04-16 8:45 UTC (permalink / raw)
To: zhuguangqing83
Cc: Liam Girdwood, Mark Brown, Matthias Brugger, linux-kernel,
linux-arm-kernel, linux-mediatek
On Fri, 16 Apr 2021 at 06:30, <zhuguangqing83@gmail.com> wrote:
>
> From: Guangqing Zhu <zhuguangqing83@gmail.com>
>
> Coccinelle noticed:
> drivers/regulator/mt6360-regulator.c:386:8-33: ERROR: Threaded IRQ with no
> primary handler requested without IRQF_ONESHOT
This should be tested. There are several patches like this all over
the tree so it looks like "let's fix everything from Coccinelle"
because you ignored at least in some of the cases that the handler is
not the primary one. I am not saying that the change is bad, but
rather it looks automated.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-16 9:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-16 3:47 [PATCH] regulator: mt6360: Fix missing IRQF_ONESHOT as only threaded handler zhuguangqing83
2021-04-16 8:45 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).