* [PATCH v2] media: exynos4-is: add missing call to of_node_put()
@ 2021-02-26 1:28 Yang Li
2021-02-26 10:29 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2021-02-26 1:28 UTC (permalink / raw)
To: mchehab
Cc: linux-samsung-soc, linux-kernel, krzk, Yang Li, s.nawrocki,
linux-arm-kernel, linux-media
In one of the error paths of the for_each_child_of_node() loop in
fimc_md_parse_one_endpoint, add missing call to of_node_put().
Fix the following coccicheck warning:
./drivers/media/platform/exynos4-is/media-dev.c:489:1-23: WARNING:
Function "for_each_child_of_node" should have of_node_put() before
return around line 492.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
Changes in v2:
-add braces for if
drivers/media/platform/exynos4-is/media-dev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c
index 8e1e892..a6ee2a3 100644
--- a/drivers/media/platform/exynos4-is/media-dev.c
+++ b/drivers/media/platform/exynos4-is/media-dev.c
@@ -488,8 +488,10 @@ static int fimc_md_parse_port_node(struct fimc_md *fmd,
for_each_child_of_node(port, ep) {
ret = fimc_md_parse_one_endpoint(fmd, ep);
- if (ret < 0)
+ if (ret < 0) {
+ of_node_put(ep);
return ret;
+ }
}
return 0;
--
1.8.3.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] media: exynos4-is: add missing call to of_node_put()
2021-02-26 1:28 [PATCH v2] media: exynos4-is: add missing call to of_node_put() Yang Li
@ 2021-02-26 10:29 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2021-02-26 10:29 UTC (permalink / raw)
To: Yang Li
Cc: linux-samsung-soc, linux-kernel, Sylwester Nawrocki, mchehab,
linux-arm-kernel, linux-media
On Fri, 26 Feb 2021 at 02:28, Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> In one of the error paths of the for_each_child_of_node() loop in
> fimc_md_parse_one_endpoint, add missing call to of_node_put().
>
> Fix the following coccicheck warning:
> ./drivers/media/platform/exynos4-is/media-dev.c:489:1-23: WARNING:
> Function "for_each_child_of_node" should have of_node_put() before
> return around line 492.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
You ignored the comment for this. Anyone can run Coccinelle and it
does not equal "Reported-by" credit. Reported by is for reported bugs,
but I asked three times to you guys to share the reports. This is not
an open way of working.
This should be removed.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-26 10:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-26 1:28 [PATCH v2] media: exynos4-is: add missing call to of_node_put() Yang Li
2021-02-26 10:29 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).