* [PATCH v2 1/2] arm64: dts: mt8183: add mediatek,gce-events in mutex
@ 2021-05-03 5:05 Hsin-Yi Wang
2021-05-03 5:05 ` [PATCH v2 2/2] dt-bindings: mediatek: Add optional mediatek, gce-events property Hsin-Yi Wang
0 siblings, 1 reply; 4+ messages in thread
From: Hsin-Yi Wang @ 2021-05-03 5:05 UTC (permalink / raw)
To: Matthias Brugger, Rob Herring, Chun-Kuang Hu, devicetree,
Enric Balletbo i Serra, linux-arm-kernel, linux-mediatek,
linux-kernel
mediatek,gce-events is read by mutex node.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index c5e822b6b77a..cf22d71161e5 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -1250,6 +1250,8 @@ mutex: mutex@14016000 {
reg = <0 0x14016000 0 0x1000>;
interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_LOW>;
power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
+ mediatek,gce-events = <CMDQ_EVENT_MUTEX_STREAM_DONE0>,
+ <CMDQ_EVENT_MUTEX_STREAM_DONE1>;
};
larb0: larb@14017000 {
--
2.31.1.527.g47e6f16901-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 2/2] dt-bindings: mediatek: Add optional mediatek, gce-events property
2021-05-03 5:05 [PATCH v2 1/2] arm64: dts: mt8183: add mediatek,gce-events in mutex Hsin-Yi Wang
@ 2021-05-03 5:05 ` Hsin-Yi Wang
2021-05-04 4:10 ` CK Hu
0 siblings, 1 reply; 4+ messages in thread
From: Hsin-Yi Wang @ 2021-05-03 5:05 UTC (permalink / raw)
To: Matthias Brugger, Rob Herring, Chun-Kuang Hu, devicetree,
Enric Balletbo i Serra, linux-arm-kernel, linux-mediatek,
linux-kernel
mediatek,gce-events property is used by gce clients.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
.../devicetree/bindings/display/mediatek/mediatek,disp.txt | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
index fbb59c9ddda6..939b2da3bdc5 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
@@ -75,6 +75,10 @@ Optional properties (RDMA function blocks):
mediatek,rdma-fifo-size of mt8183-rdma0 is 5K
mediatek,rdma-fifo-size of mt8183-rdma1 is 2K
+Optional properties for display mutex:
+- mediatek,gce-events: GCE events used by clients. The event numbers are
+ defined in 'dt-bindings/gce/<chip>-gce.h'.
+
Examples:
mmsys: clock-controller@14000000 {
@@ -209,6 +213,8 @@ mutex: mutex@14020000 {
interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_LOW>;
power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
clocks = <&mmsys CLK_MM_MUTEX_32K>;
+ mediatek,gce-events = <CMDQ_EVENT_MUTEX0_STREAM_EOF>,
+ <CMDQ_EVENT_MUTEX1_STREAM_EOF>;
};
od@14023000 {
--
2.31.1.527.g47e6f16901-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: mediatek: Add optional mediatek, gce-events property
2021-05-03 5:05 ` [PATCH v2 2/2] dt-bindings: mediatek: Add optional mediatek, gce-events property Hsin-Yi Wang
@ 2021-05-04 4:10 ` CK Hu
2021-05-04 5:46 ` Hsin-Yi Wang
0 siblings, 1 reply; 4+ messages in thread
From: CK Hu @ 2021-05-04 4:10 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Matthias Brugger, Rob Herring, Chun-Kuang Hu, devicetree,
Enric Balletbo i Serra, linux-arm-kernel, linux-mediatek,
linux-kernel
Hi, Hsin-yi:
On Mon, 2021-05-03 at 13:05 +0800, Hsin-Yi Wang wrote:
> mediatek,gce-events property is used by gce clients.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,disp.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> index fbb59c9ddda6..939b2da3bdc5 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> @@ -75,6 +75,10 @@ Optional properties (RDMA function blocks):
> mediatek,rdma-fifo-size of mt8183-rdma0 is 5K
> mediatek,rdma-fifo-size of mt8183-rdma1 is 2K
>
> +Optional properties for display mutex:
> +- mediatek,gce-events: GCE events used by clients. The event numbers are
> + defined in 'dt-bindings/gce/<chip>-gce.h'.
I think mediatek,gce-events should be first defined in [1], and here
refer to [1].
In addition, mtk-mutex driver is moved into soc folder, so I would like
to move mtk-mutex binding out of display binding. It's up to you.
[1] Documentation/devicetree/bindings/mailbox/mtk-gce.txt
Regards,
CK
> +
> Examples:
>
> mmsys: clock-controller@14000000 {
> @@ -209,6 +213,8 @@ mutex: mutex@14020000 {
> interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_LOW>;
> power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
> clocks = <&mmsys CLK_MM_MUTEX_32K>;
> + mediatek,gce-events = <CMDQ_EVENT_MUTEX0_STREAM_EOF>,
> + <CMDQ_EVENT_MUTEX1_STREAM_EOF>;
> };
>
> od@14023000 {
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: mediatek: Add optional mediatek, gce-events property
2021-05-04 4:10 ` CK Hu
@ 2021-05-04 5:46 ` Hsin-Yi Wang
0 siblings, 0 replies; 4+ messages in thread
From: Hsin-Yi Wang @ 2021-05-04 5:46 UTC (permalink / raw)
To: CK Hu
Cc: Matthias Brugger, Rob Herring, Chun-Kuang Hu, Devicetree List,
Enric Balletbo i Serra,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/Mediatek SoC support, lkml
On Tue, May 4, 2021 at 12:11 PM CK Hu <ck.hu@mediatek.com> wrote:
>
> Hi, Hsin-yi:
>
> On Mon, 2021-05-03 at 13:05 +0800, Hsin-Yi Wang wrote:
> > mediatek,gce-events property is used by gce clients.
> >
> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,disp.txt | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> > index fbb59c9ddda6..939b2da3bdc5 100644
> > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> > @@ -75,6 +75,10 @@ Optional properties (RDMA function blocks):
> > mediatek,rdma-fifo-size of mt8183-rdma0 is 5K
> > mediatek,rdma-fifo-size of mt8183-rdma1 is 2K
> >
> > +Optional properties for display mutex:
> > +- mediatek,gce-events: GCE events used by clients. The event numbers are
> > + defined in 'dt-bindings/gce/<chip>-gce.h'.
>
> I think mediatek,gce-events should be first defined in [1], and here
> refer to [1].
>
> In addition, mtk-mutex driver is moved into soc folder, so I would like
> to move mtk-mutex binding out of display binding. It's up to you.
>
> [1] Documentation/devicetree/bindings/mailbox/mtk-gce.txt
>
Thanks, I moved the definition here in v3.
> Regards,
> CK
>
> > +
> > Examples:
> >
> > mmsys: clock-controller@14000000 {
> > @@ -209,6 +213,8 @@ mutex: mutex@14020000 {
> > interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_LOW>;
> > power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
> > clocks = <&mmsys CLK_MM_MUTEX_32K>;
> > + mediatek,gce-events = <CMDQ_EVENT_MUTEX0_STREAM_EOF>,
> > + <CMDQ_EVENT_MUTEX1_STREAM_EOF>;
> > };
> >
> > od@14023000 {
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-04 5:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-03 5:05 [PATCH v2 1/2] arm64: dts: mt8183: add mediatek,gce-events in mutex Hsin-Yi Wang
2021-05-03 5:05 ` [PATCH v2 2/2] dt-bindings: mediatek: Add optional mediatek, gce-events property Hsin-Yi Wang
2021-05-04 4:10 ` CK Hu
2021-05-04 5:46 ` Hsin-Yi Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).