* [PATCH] ARM: visit mach-* and plat-* directories when cleaning
@ 2019-07-18 16:35 Masahiro Yamada
2019-07-25 16:46 ` Russell King - ARM Linux admin
0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2019-07-18 16:35 UTC (permalink / raw)
To: patches; +Cc: Masahiro Yamada, Russell King, linux-arm-kernel, linux-kernel
When you run "make clean" for arm, it never visits mach-* or plat-*
directories because machine-y and plat-y are just empty.
When cleaning, all machine, plat directories are accumulated to
machine-, plat-, respectively. So, let's pass them to core- to
clean up those directories.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
KernelVersion: v5.3-rc1
arch/arm/Makefile | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 792f7fa16a24..c3eb0d9a2fdd 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -286,6 +286,10 @@ core-y += arch/arm/net/
core-y += arch/arm/crypto/
core-y += $(machdirs) $(platdirs)
+# For cleaning
+core- += $(patsubst %,arch/arm/mach-%/, $(machine-))
+core- += $(patsubst %,arch/arm/plat-%/, $(plat-))
+
drivers-$(CONFIG_OPROFILE) += arch/arm/oprofile/
libs-y := arch/arm/lib/ $(libs-y)
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: visit mach-* and plat-* directories when cleaning
2019-07-18 16:35 [PATCH] ARM: visit mach-* and plat-* directories when cleaning Masahiro Yamada
@ 2019-07-25 16:46 ` Russell King - ARM Linux admin
2019-07-26 0:20 ` Masahiro Yamada
0 siblings, 1 reply; 3+ messages in thread
From: Russell King - ARM Linux admin @ 2019-07-25 16:46 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: patches, linux-kernel, linux-arm-kernel
On Fri, Jul 19, 2019 at 01:35:23AM +0900, Masahiro Yamada wrote:
> When you run "make clean" for arm, it never visits mach-* or plat-*
> directories because machine-y and plat-y are just empty.
>
> When cleaning, all machine, plat directories are accumulated to
> machine-, plat-, respectively. So, let's pass them to core- to
> clean up those directories.
You don't say what actual, real-life issue this patch is solving.
Which files are left behind by a "make clean" ?
From what I can see, this only matters if there are extra files that
are generated (and have set extra-* or clean-*). Everything else is
cleaned up via the big find command in the top level makefile.
Or is this a "it would be nice if..." patch?
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> KernelVersion: v5.3-rc1
>
> arch/arm/Makefile | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index 792f7fa16a24..c3eb0d9a2fdd 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -286,6 +286,10 @@ core-y += arch/arm/net/
> core-y += arch/arm/crypto/
> core-y += $(machdirs) $(platdirs)
>
> +# For cleaning
> +core- += $(patsubst %,arch/arm/mach-%/, $(machine-))
> +core- += $(patsubst %,arch/arm/plat-%/, $(plat-))
> +
> drivers-$(CONFIG_OPROFILE) += arch/arm/oprofile/
>
> libs-y := arch/arm/lib/ $(libs-y)
> --
> 2.17.1
>
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: visit mach-* and plat-* directories when cleaning
2019-07-25 16:46 ` Russell King - ARM Linux admin
@ 2019-07-26 0:20 ` Masahiro Yamada
0 siblings, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2019-07-26 0:20 UTC (permalink / raw)
To: Russell King - ARM Linux admin
Cc: patches, Linux Kernel Mailing List, linux-arm-kernel
On Fri, Jul 26, 2019 at 1:46 AM Russell King - ARM Linux admin
<linux@armlinux.org.uk> wrote:
>
> On Fri, Jul 19, 2019 at 01:35:23AM +0900, Masahiro Yamada wrote:
> > When you run "make clean" for arm, it never visits mach-* or plat-*
> > directories because machine-y and plat-y are just empty.
> >
> > When cleaning, all machine, plat directories are accumulated to
> > machine-, plat-, respectively. So, let's pass them to core- to
> > clean up those directories.
>
> You don't say what actual, real-life issue this patch is solving.
> Which files are left behind by a "make clean" ?
>
> From what I can see, this only matters if there are extra files that
> are generated (and have set extra-* or clean-*). Everything else is
> cleaned up via the big find command in the top level makefile.
>
> Or is this a "it would be nice if..." patch?
>
This is a prerequisite for the following:
https://lore.kernel.org/patchwork/patch/1059150/
https://lore.kernel.org/patchwork/patch/1059149/
If this patch lands in upstream, I will resend them.
The motivation of the two is to avoid unneeded
re-compilation of kernel/kheaders_data.tar.xz
This is a race condition between
scripts/gen_kheaders.sh and arch/arm/mach-{at91,omap2}/Makefile
--
Best Regards
Masahiro Yamada
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-26 0:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-18 16:35 [PATCH] ARM: visit mach-* and plat-* directories when cleaning Masahiro Yamada
2019-07-25 16:46 ` Russell King - ARM Linux admin
2019-07-26 0:20 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).