From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Kate Stewart <kstewart@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Vincent Whitchurch <vincent.whitchurch@axis.com>,
Russell King <linux@armlinux.org.uk>,
Stefan Agner <stefan@agner.ch>,
LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Russell King <rmk+kernel@armlinux.org.uk>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Olof Johansson <olof@lixom.net>,
Thomas Gleixner <tglx@linutronix.de>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Enrico Weigelt <info@metux.net>,
Allison Randal <allison@lohutok.net>
Subject: Re: [PATCH v2] ARM: add __always_inline to functions called from __get_user_check()
Date: Wed, 2 Oct 2019 22:01:51 +0900 [thread overview]
Message-ID: <CAK7LNATvGykFY10mOXez84zPV_k3snefgS9zymcn2_7k3EMxAg@mail.gmail.com> (raw)
In-Reply-To: <CAKwvOd=NObDXDL3jz9ZX9wo4tn747peBJPTj0DXyLerixgL+wQ@mail.gmail.com>
Hi Nick,
On Wed, Oct 2, 2019 at 2:04 AM Nick Desaulniers <ndesaulniers@google.com> wrote:
> > Since that commit, all architectures can enable CONFIG_OPTIMIZE_INLINING.
> > So, __always_inline is now the only guaranteed way of forcible inlining.
>
> No, the C preprocessor is the only guaranteed way of inlining.
I do not think this is fatal if I understood this correctly:
https://lore.kernel.org/patchwork/patch/1122097/#1331784
For GCC, we at least get a warning if a function with
__always_inline is not inlined.
I am fine with adding -Werror=attributes to the top Makefile
(unless we have unpleasant side-effects).
You filed the bug for Clang, and hopefully it will be OK
in the future releases?
--
Best Regards
Masahiro Yamada
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-10-02 13:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 8:37 [PATCH v2] ARM: add __always_inline to functions called from __get_user_check() Masahiro Yamada
2019-10-01 9:03 ` Nicolas Saenz Julienne
2019-10-01 17:03 ` Nick Desaulniers
2019-10-02 8:24 ` Russell King - ARM Linux admin
2019-10-02 10:45 ` Masahiro Yamada
2019-10-02 13:01 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNATvGykFY10mOXez84zPV_k3snefgS9zymcn2_7k3EMxAg@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=allison@lohutok.net \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=julien.thierry.kdev@gmail.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=ndesaulniers@google.com \
--cc=nsaenzjulienne@suse.de \
--cc=olof@lixom.net \
--cc=rmk+kernel@armlinux.org.uk \
--cc=stefan@agner.ch \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).