* [PATCH v2] drm/sun4i: Implement drm_driver lastclose to restore fbdev console
@ 2017-07-09 7:59 Jonathan Liu
2017-07-09 15:11 ` Chen-Yu Tsai
0 siblings, 1 reply; 5+ messages in thread
From: Jonathan Liu @ 2017-07-09 7:59 UTC (permalink / raw)
To: linux-arm-kernel
The drm_driver lastclose callback is called when the last userspace
DRM client has closed. Call drm_fbdev_cma_restore_mode to restore
the fbdev console otherwise the fbdev console will stop working.
Signed-off-by: Jonathan Liu <net147@gmail.com>
---
Changes for v2:
- Rename sun4i_drm_lastclose to sun4i_drv_lastclose
drivers/gpu/drm/sun4i/sun4i_drv.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
index abc7d8fe06b4..a45a627283a1 100644
--- a/drivers/gpu/drm/sun4i/sun4i_drv.c
+++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
@@ -25,12 +25,20 @@
#include "sun4i_framebuffer.h"
#include "sun4i_tcon.h"
+static void sun4i_drv_lastclose(struct drm_device *dev)
+{
+ struct sun4i_drv *drv = dev->dev_private;
+
+ drm_fbdev_cma_restore_mode(drv->fbdev);
+}
+
DEFINE_DRM_GEM_CMA_FOPS(sun4i_drv_fops);
static struct drm_driver sun4i_drv_driver = {
.driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_PRIME | DRIVER_ATOMIC,
/* Generic Operations */
+ .lastclose = sun4i_drv_lastclose,
.fops = &sun4i_drv_fops,
.name = "sun4i-drm",
.desc = "Allwinner sun4i Display Engine",
--
2.13.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2] drm/sun4i: Implement drm_driver lastclose to restore fbdev console
2017-07-09 7:59 [PATCH v2] drm/sun4i: Implement drm_driver lastclose to restore fbdev console Jonathan Liu
@ 2017-07-09 15:11 ` Chen-Yu Tsai
2017-07-10 6:44 ` Maxime Ripard
0 siblings, 1 reply; 5+ messages in thread
From: Chen-Yu Tsai @ 2017-07-09 15:11 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Jul 9, 2017 at 3:59 PM, Jonathan Liu <net147@gmail.com> wrote:
> The drm_driver lastclose callback is called when the last userspace
> DRM client has closed. Call drm_fbdev_cma_restore_mode to restore
> the fbdev console otherwise the fbdev console will stop working.
>
> Signed-off-by: Jonathan Liu <net147@gmail.com>
This should have
Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support")
Otherwise,
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] drm/sun4i: Implement drm_driver lastclose to restore fbdev console
2017-07-09 15:11 ` Chen-Yu Tsai
@ 2017-07-10 6:44 ` Maxime Ripard
2017-07-10 6:53 ` Jonathan Liu
2017-07-10 18:01 ` Daniel Vetter
0 siblings, 2 replies; 5+ messages in thread
From: Maxime Ripard @ 2017-07-10 6:44 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Jul 09, 2017 at 11:11:07PM +0800, Chen-Yu Tsai wrote:
> On Sun, Jul 9, 2017 at 3:59 PM, Jonathan Liu <net147@gmail.com> wrote:
> > The drm_driver lastclose callback is called when the last userspace
> > DRM client has closed. Call drm_fbdev_cma_restore_mode to restore
> > the fbdev console otherwise the fbdev console will stop working.
> >
> > Signed-off-by: Jonathan Liu <net147@gmail.com>
>
> This should have
>
> Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support")
>
> Otherwise,
>
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
And it should be sent to stable too.
Can you resend it?
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170710/f64b0505/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] drm/sun4i: Implement drm_driver lastclose to restore fbdev console
2017-07-10 6:44 ` Maxime Ripard
@ 2017-07-10 6:53 ` Jonathan Liu
2017-07-10 18:01 ` Daniel Vetter
1 sibling, 0 replies; 5+ messages in thread
From: Jonathan Liu @ 2017-07-10 6:53 UTC (permalink / raw)
To: linux-arm-kernel
Hi Maxime,
On 10 July 2017 at 16:44, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Sun, Jul 09, 2017 at 11:11:07PM +0800, Chen-Yu Tsai wrote:
>> On Sun, Jul 9, 2017 at 3:59 PM, Jonathan Liu <net147@gmail.com> wrote:
>> > The drm_driver lastclose callback is called when the last userspace
>> > DRM client has closed. Call drm_fbdev_cma_restore_mode to restore
>> > the fbdev console otherwise the fbdev console will stop working.
>> >
>> > Signed-off-by: Jonathan Liu <net147@gmail.com>
>>
>> This should have
>>
>> Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support")
>>
>> Otherwise,
>>
>> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
>
> And it should be sent to stable too.
>
> Can you resend it?
Will do.
>
> Thanks!
> Maxime
>
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
Regards,
Jonathan
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] drm/sun4i: Implement drm_driver lastclose to restore fbdev console
2017-07-10 6:44 ` Maxime Ripard
2017-07-10 6:53 ` Jonathan Liu
@ 2017-07-10 18:01 ` Daniel Vetter
1 sibling, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2017-07-10 18:01 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 10, 2017 at 8:44 AM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Sun, Jul 09, 2017 at 11:11:07PM +0800, Chen-Yu Tsai wrote:
>> On Sun, Jul 9, 2017 at 3:59 PM, Jonathan Liu <net147@gmail.com> wrote:
>> > The drm_driver lastclose callback is called when the last userspace
>> > DRM client has closed. Call drm_fbdev_cma_restore_mode to restore
>> > the fbdev console otherwise the fbdev console will stop working.
>> >
>> > Signed-off-by: Jonathan Liu <net147@gmail.com>
>>
>> This should have
>>
>> Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support")
>>
>> Otherwise,
>>
>> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
>
> And it should be sent to stable too.
>
> Can you resend it?
Fyi but patchwork auto-adds these tags. Feels a bit like overkill
asking for a resend for something you can trivially add yourself ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-07-10 18:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-09 7:59 [PATCH v2] drm/sun4i: Implement drm_driver lastclose to restore fbdev console Jonathan Liu
2017-07-09 15:11 ` Chen-Yu Tsai
2017-07-10 6:44 ` Maxime Ripard
2017-07-10 6:53 ` Jonathan Liu
2017-07-10 18:01 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).