From: Rob Herring <robh@kernel.org>
To: Chuanhua Han <chuanhua.han@nxp.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Ying Zhang <ying.zhang22455@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Leo Li <leoyang.li@nxp.com>, Shawn Guo <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node
Date: Fri, 24 May 2019 07:29:20 -0500 [thread overview]
Message-ID: <CAL_Jsq+evXqKKyXLFbE+9o8X5BA9NWmcjvZ9-Y1Y7-pwcu8nJg@mail.gmail.com> (raw)
In-Reply-To: <AM6PR04MB4357072E079BDD8D1866595797020@AM6PR04MB4357.eurprd04.prod.outlook.com>
On Fri, May 24, 2019 at 4:48 AM Chuanhua Han <chuanhua.han@nxp.com> wrote:
>
> Hi, Rob Herring
>
> > -----Original Message-----
> > From: Leo Li
> > Sent: 2019年5月22日 14:50
> > > > > > > > > - wdog0: watchdog@23c0000 {
> > > > > > > > > - compatible = "fsl,ls1028a-wdt",
> > > > "fsl,imx21-wdt";
> > > > > > > > > - reg = <0x0 0x23c0000 0x0 0x10000>;
> > > > > > > > > - interrupts = <GIC_SPI 59
> > > > > > IRQ_TYPE_LEVEL_HIGH>;
> > > > > > > > > - clocks = <&clockgen 4 1>;
> > > > > > > > > - big-endian;
> > > > > > > > > - status = "disabled";
> > > > > > > > > + cluster1_core0_watchdog: wdt@c000000 {
> > > > > > > >
> > > > > > > > Keep 'watchdog' as the node name,
> > > > > > > Thanks for your replay
> > > > > > > Do you mean replace the ‘wdt’ with ‘watchdog’?
> > > > > > > and keep nodes sort in unit-address.
> > > > > > > What does this mean?
> > > > > >
> > > > > > That means order the nodes by the addresses (e.g. c000000,
> > > > > > c010000)
> > > > > The current order is correct（The first is c000000, then c000000）.
> > > >
> > > > But they are added after gpio@2320000 and before sata@3200000.
> > > I changed and made the second version of the patch, but I found the
> > > following error when I executed ./scripts/checkpatch.pl xxx.patch to
> > > check the patch:
> > >
> > > WARNING: DT compatible string vendor "arm" appears un-documented --
> > > check ./Documentation/devicetree/bindings/vendor-prefixes.txt
> > > #43: FILE: arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:351:
> > > + compatible = "arm,sp805", "arm,primecell";
> > >
> > > However, there is no vendor-prefixes.txt file in the
> > > ./Documentation/devicetree/bindings/ directory, only vendor-
> > > prefixes.yaml.
> > > Moreover, there are ‘arm’ vendors in vendor-prefixes.yaml.
> >
> > Added Rob Herring to the thread.
> >
> > > Request help，thanks
> How can I solve this patch check error? Ask for help, thank you!
Ignore it. A fix to checkpatch.pl is pending.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-24 12:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 7:06 [PATCH] arm64: dts: ls1028a: fix watchdog device node Chuanhua Han
2019-05-17 2:37 ` Shawn Guo
2019-05-17 6:10 ` [EXT] " Chuanhua Han
2019-05-17 22:01 ` Leo Li
2019-05-21 13:00 ` Chuanhua Han
2019-05-21 20:14 ` Leo Li
2019-05-22 6:26 ` Chuanhua Han
2019-05-22 6:50 ` Leo Li
2019-05-24 9:48 ` Chuanhua Han
2019-05-24 12:29 ` Rob Herring [this message]
2019-05-30 3:09 ` Chuanhua Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_Jsq+evXqKKyXLFbE+9o8X5BA9NWmcjvZ9-Y1Y7-pwcu8nJg@mail.gmail.com \
--to=robh@kernel.org \
--cc=chuanhua.han@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=shawnguo@kernel.org \
--cc=ying.zhang22455@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).