linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh+dt@kernel.org>
To: Joseph Kogut <joseph.kogut@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	David Airlie <airlied@linux.ie>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Kukjin Kim <kgene@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Daniel Vetter <daniel@ffwll.ch>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] arm: dts: add ARM Mali GPU node for Odroid XU3
Date: Fri, 14 Jun 2019 14:36:45 -0600	[thread overview]
Message-ID: <CAL_JsqJjqCRU2a9sfMimTJoMQnR6CjqAqjHRAxyaebWAad299g@mail.gmail.com> (raw)
In-Reply-To: <20190614203144.3850-2-joseph.kogut@gmail.com>

On Fri, Jun 14, 2019 at 2:31 PM Joseph Kogut <joseph.kogut@gmail.com> wrote:
>
> Add device tree node for mali gpu on Odroid XU3 SoCs.
>
> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
> ---
>  .../boot/dts/exynos5422-odroidxu3-common.dtsi  | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> index 93a48f2dda49..1f2ae19d01af 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> @@ -48,6 +48,24 @@
>                 cooling-levels = <0 130 170 230>;
>         };
>
> +       gpu: gpu@11800000 {
> +               compatible = "samsung,exynos-mali", "arm,mali-t628";
> +               reg = <0x11800000 0x5000>;
> +               interrupts = <0 117 0>,
> +                            <0 219 0>,
> +                            <0 74  0>;
> +               interrupt-names = "gpu", "job", "mmu";

Please use the order defined in the binding doc.

> +               clocks = <&clock CLK_G3D>,
> +                        <&clock CLK_DOUT_ACLK_G3D>,
> +                        <&clock CLK_FOUT_VPLL>;

The binding doc says a single clock.

> +               mali-supply = <&buck4_reg>;
> +               operating-points = <

The binding doc says operating-points-v2.

> +                       /* KHz  uV   */
> +                       600000  1150000
> +                       177000  812500
> +               >;
> +       };
> +
>         thermal-zones {
>                 cpu0_thermal: cpu0-thermal {
>                         thermal-sensors = <&tmu_cpu0 0>;
> --
> 2.22.0
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-06-14 20:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14 20:31 [PATCH 1/2] dt-bindings: gpu: add Exynos Mali vendor specifics Joseph Kogut
2019-06-14 20:31 ` [PATCH 2/2] arm: dts: add ARM Mali GPU node for Odroid XU3 Joseph Kogut
2019-06-14 20:36   ` Rob Herring [this message]
2019-06-14 23:57   ` [PATCH v2 " Joseph Kogut
2019-06-16  8:59     ` Krzysztof Kozlowski
2019-06-17 16:15       ` Joseph Kogut
2019-06-17 16:36         ` Krzysztof Kozlowski
2019-06-18 17:41           ` Joseph Kogut
2019-06-18 19:17             ` Krzysztof Kozlowski
2019-06-17 19:16     ` Rob Herring
2019-06-18  9:26     ` Krzysztof Kozlowski
2019-06-18 14:18       ` Rob Herring
2019-06-18 14:45         ` Krzysztof Kozlowski
2019-06-16  8:15 ` [PATCH 1/2] dt-bindings: gpu: add Exynos Mali vendor specifics Krzysztof Kozlowski
2019-06-17 22:06   ` Rob Herring
2019-06-18  7:23     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_JsqJjqCRU2a9sfMimTJoMQnR6CjqAqjHRAxyaebWAad299g@mail.gmail.com \
    --to=robh+dt@kernel.org \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=joseph.kogut@gmail.com \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).