From: Krzysztof Kozlowski <krzk@kernel.org>
To: Joseph Kogut <joseph.kogut@gmail.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
airlied@linux.ie, dri-devel@lists.freedesktop.org,
robh+dt@kernel.org, kgene@kernel.org, daniel@ffwll.ch,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] arm: dts: add ARM Mali GPU node for Odroid XU3
Date: Tue, 18 Jun 2019 11:26:58 +0200 [thread overview]
Message-ID: <CAJKOXPc-Xztou+xyibb8YZtfz20q3kzr_gTBoE=R3q_CSk9kzQ@mail.gmail.com> (raw)
In-Reply-To: <20190614235719.8134-1-joseph.kogut@gmail.com>
On Sat, 15 Jun 2019 at 01:57, Joseph Kogut <joseph.kogut@gmail.com> wrote:
>
> Add device tree node for mali gpu on Odroid XU3 SoCs.
>
> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
> ---
>
> Changes v1 -> v2:
> - Use interrupt name ordering from binding doc
> - Specify a single clock for GPU node
> - Add gpu opp table
> - Fix warnings from IRQ_TYPE_NONE
>
> .../boot/dts/exynos5422-odroidxu3-common.dtsi | 26 +++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> index 93a48f2dda49..b8a4246e3b37 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> @@ -48,6 +48,32 @@
> cooling-levels = <0 130 170 230>;
> };
>
> + gpu: gpu@11800000 {
> + compatible = "samsung,exynos-mali", "arm,mali-t628";
> + reg = <0x11800000 0x5000>;
> + interrupts = <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "job", "mmu", "gpu";
> + clocks = <&clock CLK_G3D>;
> + mali-supply = <&buck4_reg>;
> + operating-points-v2 = <&gpu_opp_table>;
> + };
> +
> + gpu_opp_table: gpu-opp-table {
One more thing - use "opp_table" as node name (generic class of node,
matches style with other tables).
Best regards,
Krzysztof
> + compatible = "operating-points-v2";
> +
> + opp-177000000 {
> + opp-hz = /bits/ 64 <117000000>;
> + opp-microvolt = <812500>;
> + };
> +
> + opp-600000000 {
> + opp-hz = /bits/ 64 <600000000>;
> + opp-microvolt = <1150000>;
> + };
> + };
> +
> thermal-zones {
> cpu0_thermal: cpu0-thermal {
> thermal-sensors = <&tmu_cpu0 0>;
> --
> 2.22.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-18 9:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 20:31 [PATCH 1/2] dt-bindings: gpu: add Exynos Mali vendor specifics Joseph Kogut
2019-06-14 20:31 ` [PATCH 2/2] arm: dts: add ARM Mali GPU node for Odroid XU3 Joseph Kogut
2019-06-14 20:36 ` Rob Herring
2019-06-14 23:57 ` [PATCH v2 " Joseph Kogut
2019-06-16 8:59 ` Krzysztof Kozlowski
2019-06-17 16:15 ` Joseph Kogut
2019-06-17 16:36 ` Krzysztof Kozlowski
2019-06-18 17:41 ` Joseph Kogut
2019-06-18 19:17 ` Krzysztof Kozlowski
2019-06-17 19:16 ` Rob Herring
2019-06-18 9:26 ` Krzysztof Kozlowski [this message]
2019-06-18 14:18 ` Rob Herring
2019-06-18 14:45 ` Krzysztof Kozlowski
2019-06-16 8:15 ` [PATCH 1/2] dt-bindings: gpu: add Exynos Mali vendor specifics Krzysztof Kozlowski
2019-06-17 22:06 ` Rob Herring
2019-06-18 7:23 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJKOXPc-Xztou+xyibb8YZtfz20q3kzr_gTBoE=R3q_CSk9kzQ@mail.gmail.com' \
--to=krzk@kernel.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=joseph.kogut@gmail.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).