From: Peter Robinson <pbrobinson@gmail.com>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Gottfried Haider <gottfried.haider@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Scott Branden <sbranden@broadcom.com>,
devicetree@vger.kernel.org, Ray Jui <rjui@broadcom.com>,
Phil Elwell <phil@raspberrypi.org>, Eric Anholt <eric@anholt.net>,
Rob Herring <robh+dt@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/6] ARM: dts: bcm283x: Fix DTC warning for memory node
Date: Mon, 21 Jan 2019 04:59:34 +0000 [thread overview]
Message-ID: <CALeDE9PAog8B_+19XRRxhgHZ2Jk=9PEn2fV9xHTo+5rpQ6L2kQ@mail.gmail.com> (raw)
In-Reply-To: <1547297008-2740-2-git-send-email-stefan.wahren@i2se.com>
On Sat, Jan 12, 2019 at 12:44 PM Stefan Wahren <stefan.wahren@i2se.com> wrote:
>
> Compiling the bcm283x DTS with W=1 leads to the following warning:
>
> Warning (unit_address_vs_reg): /memory: node has a reg or ranges property,
> but no unit name
>
> Fix this by adding the unit address.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Tested-by: Peter Robinson <pbrobinson@gmail.com>
Tested building RPi bcm283[67] dtb with W=1
> ---
> arch/arm/boot/dts/bcm2835-rpi.dtsi | 2 +-
> arch/arm/boot/dts/bcm2836-rpi-2-b.dts | 2 +-
> arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts | 2 +-
> arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts | 2 +-
> arch/arm/boot/dts/bcm2837-rpi-3-b.dts | 2 +-
> arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi | 2 +-
> 6 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi
> index c6e2b23..e490f2a 100644
> --- a/arch/arm/boot/dts/bcm2835-rpi.dtsi
> +++ b/arch/arm/boot/dts/bcm2835-rpi.dtsi
> @@ -1,7 +1,7 @@
> #include <dt-bindings/power/raspberrypi-power.h>
>
> / {
> - memory {
> + memory@0 {
> device_type = "memory";
> reg = <0 0x10000000>;
> };
> diff --git a/arch/arm/boot/dts/bcm2836-rpi-2-b.dts b/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
> index ac4408b..871fc4a 100644
> --- a/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
> +++ b/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
> @@ -9,7 +9,7 @@
> compatible = "raspberrypi,2-model-b", "brcm,bcm2836";
> model = "Raspberry Pi 2 Model B";
>
> - memory {
> + memory@0 {
> reg = <0 0x40000000>;
> };
>
> diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts b/arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts
> index e9fadd3..7f4437a 100644
> --- a/arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts
> +++ b/arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts
> @@ -13,7 +13,7 @@
> stdout-path = "serial1:115200n8";
> };
>
> - memory {
> + memory@0 {
> reg = <0 0x20000000>;
> };
>
> diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
> index 42bb090..7d65013 100644
> --- a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
> +++ b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
> @@ -14,7 +14,7 @@
> stdout-path = "serial1:115200n8";
> };
>
> - memory {
> + memory@0 {
> reg = <0 0x40000000>;
> };
>
> diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
> index 0c155dd..9abb9c5 100644
> --- a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
> +++ b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
> @@ -14,7 +14,7 @@
> stdout-path = "serial1:115200n8";
> };
>
> - memory {
> + memory@0 {
> reg = <0 0x40000000>;
> };
>
> diff --git a/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi b/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi
> index 4a89a18..81399b2 100644
> --- a/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi
> +++ b/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi
> @@ -4,7 +4,7 @@
> #include "bcm2836-rpi.dtsi"
>
> / {
> - memory {
> + memory@0 {
> reg = <0 0x40000000>;
> };
>
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-21 4:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-12 12:43 [PATCH 0/6] ARM: dts: bcm283x: Several DTS improvements Stefan Wahren
2019-01-12 12:43 ` [PATCH 1/6] ARM: dts: bcm283x: Fix DTC warning for memory node Stefan Wahren
2019-01-21 4:59 ` Peter Robinson [this message]
2019-01-12 12:43 ` [PATCH 2/6] ARM: dts: bcm2835-rpi: Drop unnecessary #address-cells/#size-cells Stefan Wahren
2019-01-12 12:43 ` [PATCH 3/6] ARM: dts: bcm2835: Fix labels for GPIO 0,1 Stefan Wahren
2019-01-12 12:43 ` [PATCH 4/6] ARM: dts: bcm2837-rpi-3-b: Use consistent label for HDMI hotplug Stefan Wahren
2019-01-21 5:02 ` Peter Robinson
2019-01-12 12:43 ` [PATCH 5/6] ARM: dts: bcm2837-rpi-3-b-plus: Clarify label for STATUS_LED Stefan Wahren
2019-01-21 5:00 ` Peter Robinson
2019-01-12 12:43 ` [PATCH 6/6] ARM: dts: bcm283x: Add missing GPIO line names Stefan Wahren
2019-01-21 4:52 ` Peter Robinson
2019-01-21 20:27 ` Eric Anholt
2019-01-22 7:57 ` [PATCH 0/6] ARM: dts: bcm283x: Several DTS improvements Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALeDE9PAog8B_+19XRRxhgHZ2Jk=9PEn2fV9xHTo+5rpQ6L2kQ@mail.gmail.com' \
--to=pbrobinson@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=gottfried.haider@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=phil@raspberrypi.org \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).