From: eric.y.miao@gmail.com (Eric Miao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] ARM: pxa: add irq ack for gpio irq
Date: Thu, 8 Sep 2011 20:22:40 -0700 [thread overview]
Message-ID: <CAMPhdO_Pu8uZcyMtDu=ZfD1++aGX+NkoKk_nyE_Po5BwFOAhXQ@mail.gmail.com> (raw)
In-Reply-To: <1315541894-19504-3-git-send-email-chao.xie@marvell.com>
On Thu, Sep 8, 2011 at 9:18 PM, Chao Xie <chao.xie@marvell.com> wrote:
> For previous pxa3xx and pxa168, pxa9xx, the interrupt controller does
> not need any ack for the interrupt.
> For next ARM V7 SMP core, it will use GIC, and it need ack for the
> interrupt.
>
> Signed-off-by: Chao Xie <chao.xie@marvell.com>
> ---
> ?arch/arm/plat-pxa/gpio.c | ? ?4 ++++
> ?1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-pxa/gpio.c b/arch/arm/plat-pxa/gpio.c
> index 15de09d..66ae80a 100644
> --- a/arch/arm/plat-pxa/gpio.c
> +++ b/arch/arm/plat-pxa/gpio.c
> @@ -19,6 +19,7 @@
> ?#include <linux/slab.h>
>
> ?#include <mach/gpio.h>
> +#include <asm/mach/irq.h>
>
> ?int pxa_last_gpio;
>
> @@ -206,7 +207,9 @@ static void pxa_gpio_demux_handler(unsigned int irq, struct irq_desc *desc)
> ? ? ? ?struct pxa_gpio_chip *c;
> ? ? ? ?int loop, gpio, gpio_base, n;
> ? ? ? ?unsigned long gedr;
> + ? ? ? struct irq_chip *chip = irq_get_chip(irq);
>
> + ? ? ? chained_irq_enter(chip, desc);
> ? ? ? ?do {
> ? ? ? ? ? ? ? ?loop = 0;
> ? ? ? ? ? ? ? ?for_each_gpio_chip(gpio, c) {
> @@ -225,6 +228,7 @@ static void pxa_gpio_demux_handler(unsigned int irq, struct irq_desc *desc)
> ? ? ? ? ? ? ? ? ? ? ? ?}
> ? ? ? ? ? ? ? ?}
> ? ? ? ?} while (loop);
> + ? ? ? chained_irq_exit(chip, desc);
> ?}
>
> ?static void pxa_ack_muxed_gpio(struct irq_data *d)
Looks good to me.
next prev parent reply other threads:[~2011-09-09 3:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 4:18 [PATCH 1/4] ARM: mmp: add irq_disable callback for gpio chip Chao Xie
2011-09-09 3:28 ` Eric Miao
2011-09-09 5:30 ` Chao Xie
2011-09-09 4:18 ` [PATCH 2/4] ARM: mmp: add irq_disable callback for icu chip Chao Xie
2011-09-09 4:18 ` [PATCH 3/4] ARM: pxa: add irq ack for gpio irq Chao Xie
2011-09-09 3:22 ` Eric Miao [this message]
2011-09-09 4:18 ` [PATCH 4/4] ARM: pxa: update gpio number to 192 Chao Xie
2011-09-09 3:28 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMPhdO_Pu8uZcyMtDu=ZfD1++aGX+NkoKk_nyE_Po5BwFOAhXQ@mail.gmail.com' \
--to=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).