From: eric.y.miao@gmail.com (Eric Miao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: mmp: add irq_disable callback for gpio chip
Date: Thu, 8 Sep 2011 20:28:11 -0700 [thread overview]
Message-ID: <CAMPhdO_S4jSFBgDAeSQuMa-LEz1Bcxxbi1eRg_XHbT-=1_0XTw@mail.gmail.com> (raw)
In-Reply-To: <1315541894-19504-1-git-send-email-chao.xie@marvell.com>
Chao,
I actually don't see why do we need irq_disable() here?
On Thu, Sep 8, 2011 at 9:18 PM, Chao Xie <chao.xie@marvell.com> wrote:
> Signed-off-by: Chao Xie <chao.xie@marvell.com>
> ---
> ?arch/arm/plat-pxa/gpio.c | ? ?1 +
> ?1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-pxa/gpio.c b/arch/arm/plat-pxa/gpio.c
> index a11dc36..15de09d 100644
> --- a/arch/arm/plat-pxa/gpio.c
> +++ b/arch/arm/plat-pxa/gpio.c
> @@ -263,6 +263,7 @@ static struct irq_chip pxa_muxed_gpio_chip = {
> ? ? ? ?.irq_ack ? ? ? ?= pxa_ack_muxed_gpio,
> ? ? ? ?.irq_mask ? ? ? = pxa_mask_muxed_gpio,
> ? ? ? ?.irq_unmask ? ? = pxa_unmask_muxed_gpio,
> + ? ? ? .irq_disable ? ?= pxa_mask_muxed_gpio,
> ? ? ? ?.irq_set_type ? = pxa_gpio_irq_type,
> ?};
>
> --
> 1.7.0.4
>
>
next prev parent reply other threads:[~2011-09-09 3:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 4:18 [PATCH 1/4] ARM: mmp: add irq_disable callback for gpio chip Chao Xie
2011-09-09 3:28 ` Eric Miao [this message]
2011-09-09 5:30 ` Chao Xie
2011-09-09 4:18 ` [PATCH 2/4] ARM: mmp: add irq_disable callback for icu chip Chao Xie
2011-09-09 4:18 ` [PATCH 3/4] ARM: pxa: add irq ack for gpio irq Chao Xie
2011-09-09 3:22 ` Eric Miao
2011-09-09 4:18 ` [PATCH 4/4] ARM: pxa: update gpio number to 192 Chao Xie
2011-09-09 3:28 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMPhdO_S4jSFBgDAeSQuMa-LEz1Bcxxbi1eRg_XHbT-=1_0XTw@mail.gmail.com' \
--to=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).