* [PATCH] gpio: GPIO_SAMA5D2_PIOBU should depend on ARCH_AT91
@ 2022-07-11 8:36 Geert Uytterhoeven
2022-07-11 12:03 ` Nicolas Ferre
2022-07-12 10:23 ` Bartosz Golaszewski
0 siblings, 2 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2022-07-11 8:36 UTC (permalink / raw)
To: Ludovic Desroches, Linus Walleij, Bartosz Golaszewski
Cc: linux-gpio, linux-arm-kernel, linux-kernel, Geert Uytterhoeven
The SAMA5D2 PIOBU is only present on some AT91/Microchip SoCs. Hence
add a dependency on ARCH_AT91, to prevent asking the user about this
driver when configuring a kernel without AT91/Microchip SoC support.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/gpio/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 63a89ff7865e374f..1852656d5eb248f6 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -553,6 +553,7 @@ config GPIO_SAMA5D2_PIOBU
tristate "SAMA5D2 PIOBU GPIO support"
depends on MFD_SYSCON
depends on OF_GPIO
+ depends on ARCH_AT91 || COMPILE_TEST
select GPIO_SYSCON
help
Say yes here to use the PIOBU pins as GPIOs.
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio: GPIO_SAMA5D2_PIOBU should depend on ARCH_AT91
2022-07-11 8:36 [PATCH] gpio: GPIO_SAMA5D2_PIOBU should depend on ARCH_AT91 Geert Uytterhoeven
@ 2022-07-11 12:03 ` Nicolas Ferre
2022-07-11 12:08 ` Conor.Dooley
2022-07-12 10:23 ` Bartosz Golaszewski
1 sibling, 1 reply; 4+ messages in thread
From: Nicolas Ferre @ 2022-07-11 12:03 UTC (permalink / raw)
To: Geert Uytterhoeven, Ludovic Desroches, Linus Walleij,
Bartosz Golaszewski, Conor Dooley, Horatiu Vultur,
Kavyasree Kotagiri
Cc: linux-gpio, linux-arm-kernel, linux-kernel
On 11/07/2022 at 10:36, Geert Uytterhoeven wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> The SAMA5D2 PIOBU is only present on some AT91/Microchip SoCs. Hence
> add a dependency on ARCH_AT91, to prevent asking the user about this
> driver when configuring a kernel without AT91/Microchip SoC support.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Looks good to me:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
I'm adding to the thread my colleagues from lan966 and mpfs if it
happens that they use this same IP on their SoC. Anyway, we can add them
afterwards.
Thanks for your heads-up Geert, Best regards,
Nicolas
> ---
> drivers/gpio/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 63a89ff7865e374f..1852656d5eb248f6 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -553,6 +553,7 @@ config GPIO_SAMA5D2_PIOBU
> tristate "SAMA5D2 PIOBU GPIO support"
> depends on MFD_SYSCON
> depends on OF_GPIO
> + depends on ARCH_AT91 || COMPILE_TEST
> select GPIO_SYSCON
> help
> Say yes here to use the PIOBU pins as GPIOs.
> --
> 2.25.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Nicolas Ferre
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio: GPIO_SAMA5D2_PIOBU should depend on ARCH_AT91
2022-07-11 12:03 ` Nicolas Ferre
@ 2022-07-11 12:08 ` Conor.Dooley
0 siblings, 0 replies; 4+ messages in thread
From: Conor.Dooley @ 2022-07-11 12:08 UTC (permalink / raw)
To: Nicolas.Ferre, geert+renesas, Ludovic.Desroches, linus.walleij,
brgl, Horatiu.Vultur, Kavyasree.Kotagiri
Cc: linux-gpio, linux-arm-kernel, linux-kernel
On 11/07/2022 13:03, Nicolas Ferre wrote:
> On 11/07/2022 at 10:36, Geert Uytterhoeven wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> The SAMA5D2 PIOBU is only present on some AT91/Microchip SoCs. Hence
>> add a dependency on ARCH_AT91, to prevent asking the user about this
>> driver when configuring a kernel without AT91/Microchip SoC support.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Looks good to me:
> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
>
> I'm adding to the thread my colleagues from lan966 and mpfs if it
> happens that they use this same IP on their SoC. Anyway, we can
> add them afterwards.
Not on FPGAs, so you're safe there!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio: GPIO_SAMA5D2_PIOBU should depend on ARCH_AT91
2022-07-11 8:36 [PATCH] gpio: GPIO_SAMA5D2_PIOBU should depend on ARCH_AT91 Geert Uytterhoeven
2022-07-11 12:03 ` Nicolas Ferre
@ 2022-07-12 10:23 ` Bartosz Golaszewski
1 sibling, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2022-07-12 10:23 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Ludovic Desroches, Linus Walleij, open list:GPIO SUBSYSTEM,
Linux ARM, Linux Kernel Mailing List
On Mon, Jul 11, 2022 at 12:27 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> The SAMA5D2 PIOBU is only present on some AT91/Microchip SoCs. Hence
> add a dependency on ARCH_AT91, to prevent asking the user about this
> driver when configuring a kernel without AT91/Microchip SoC support.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/gpio/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 63a89ff7865e374f..1852656d5eb248f6 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -553,6 +553,7 @@ config GPIO_SAMA5D2_PIOBU
> tristate "SAMA5D2 PIOBU GPIO support"
> depends on MFD_SYSCON
> depends on OF_GPIO
> + depends on ARCH_AT91 || COMPILE_TEST
> select GPIO_SYSCON
> help
> Say yes here to use the PIOBU pins as GPIOs.
> --
> 2.25.1
>
Applied, thanks!
Bart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-12 10:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-11 8:36 [PATCH] gpio: GPIO_SAMA5D2_PIOBU should depend on ARCH_AT91 Geert Uytterhoeven
2022-07-11 12:03 ` Nicolas Ferre
2022-07-11 12:08 ` Conor.Dooley
2022-07-12 10:23 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).