* Re: [PATCH] irqchip/exiu: Fix the index of fwspec for IRQ type
[not found] <20201117032015.11805-1-cbz@baozis.org>
@ 2020-11-17 8:46 ` Ard Biesheuvel
0 siblings, 0 replies; only message in thread
From: Ard Biesheuvel @ 2020-11-17 8:46 UTC (permalink / raw)
To: Chen Baozi, Marc Zyngier, Linux ARM; +Cc: Linux Kernel Mailing List
(+ Marc)
On Tue, 17 Nov 2020 at 04:20, Chen Baozi <cbz@baozis.org> wrote:
>
> From: Chen Baozi <chenbaozi@phytium.com.cn>
>
> Since fwspec->param_count of ACPI node is two, the index of IRQ type
> in fwspec->param[] should be 1 rather than 2.
>
> Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
> ---
> drivers/irqchip/irq-sni-exiu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-sni-exiu.c b/drivers/irqchip/irq-sni-exiu.c
> index 1d027623c776..abd011fcecf4 100644
> --- a/drivers/irqchip/irq-sni-exiu.c
> +++ b/drivers/irqchip/irq-sni-exiu.c
> @@ -136,7 +136,7 @@ static int exiu_domain_translate(struct irq_domain *domain,
> if (fwspec->param_count != 2)
> return -EINVAL;
> *hwirq = fwspec->param[0];
> - *type = fwspec->param[2] & IRQ_TYPE_SENSE_MASK;
> + *type = fwspec->param[1] & IRQ_TYPE_SENSE_MASK;
> }
> return 0;
> }
> --
> 2.28.0
>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-11-17 8:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20201117032015.11805-1-cbz@baozis.org>
2020-11-17 8:46 ` [PATCH] irqchip/exiu: Fix the index of fwspec for IRQ type Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).