* [PATCH 3/3] arm64: dts: renesas: eagle: add EtherAVB pins
@ 2017-11-10 20:02 Sergei Shtylyov
2017-11-14 8:44 ` Geert Uytterhoeven
0 siblings, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2017-11-10 20:02 UTC (permalink / raw)
To: linux-arm-kernel
Add the (previously omitted) EtherAVB pin data to the Eagle board's
device tree.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 8 ++++++++
1 file changed, 8 insertions(+)
Index: renesas/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
===================================================================
--- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
+++ renesas/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
@@ -34,6 +34,9 @@
};
&avb {
+ pinctrl-0 = <&avb_pins>;
+ pinctrl-names = "default";
+
renesas,no-ether-link;
phy-handle = <&phy0>;
status = "okay";
@@ -53,6 +56,11 @@
};
&pfc {
+ avb_pins: avb {
+ groups = "avb0_mdio", "avb0_mii";
+ function = "avb0";
+ };
+
scif0_pins: scif0 {
groups = "scif0_data";
function = "scif0";
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] arm64: dts: renesas: eagle: add EtherAVB pins
2017-11-10 20:02 [PATCH 3/3] arm64: dts: renesas: eagle: add EtherAVB pins Sergei Shtylyov
@ 2017-11-14 8:44 ` Geert Uytterhoeven
2017-11-14 18:00 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2017-11-14 8:44 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sergei,
On Fri, Nov 10, 2017 at 9:02 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Add the (previously omitted) EtherAVB pin data to the Eagle board's
> device tree.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Thanks for your patch!
> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
> +++ renesas/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
> @@ -34,6 +34,9 @@
> };
>
> &avb {
> + pinctrl-0 = <&avb_pins>;
> + pinctrl-names = "default";
> +
> renesas,no-ether-link;
> phy-handle = <&phy0>;
> status = "okay";
> @@ -53,6 +56,11 @@
> };
>
> &pfc {
> + avb_pins: avb {
> + groups = "avb0_mdio", "avb0_mii";
Oh no, its'called "avb0_mdio" here, but "avb(0)_mdc" on all other
R-Car Gen3 SoCs?
What about "avb0_link", which is connected through "L_LNK"?
> + function = "avb0";
> + };
> +
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] arm64: dts: renesas: eagle: add EtherAVB pins
2017-11-14 8:44 ` Geert Uytterhoeven
@ 2017-11-14 18:00 ` Sergei Shtylyov
2017-11-15 16:21 ` Geert Uytterhoeven
0 siblings, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2017-11-14 18:00 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 11/14/2017 11:44 AM, Geert Uytterhoeven wrote:
>> Add the (previously omitted) EtherAVB pin data to the Eagle board's
>> device tree.
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> Thanks for your patch!
>
>> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
>> +++ renesas/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
>> @@ -34,6 +34,9 @@
[...]
>> @@ -53,6 +56,11 @@
>> };
>>
>> &pfc {
>> + avb_pins: avb {
>> + groups = "avb0_mdio", "avb0_mii";
>
> Oh no, its'called "avb0_mdio" here, but "avb(0)_mdc" on all other
> R-Car Gen3 SoCs?
Can you remember the reason? I don;t want to follow the bad example. :-)
> What about "avb0_link", which is connected through "L_LNK"?
The same as for other gen3 board, the AVB node has renesas,no-ether-link".
I tried to verify that property on Eagle, and left it intact as a result...
Will re-test removing it once more.
[...]
> Gr{oetje,eeting}s,
>
> Geert
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] arm64: dts: renesas: eagle: add EtherAVB pins
2017-11-14 18:00 ` Sergei Shtylyov
@ 2017-11-15 16:21 ` Geert Uytterhoeven
2017-11-15 20:21 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2017-11-15 16:21 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sergei,
On Tue, Nov 14, 2017 at 7:00 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> On 11/14/2017 11:44 AM, Geert Uytterhoeven wrote:
>>> Add the (previously omitted) EtherAVB pin data to the Eagle board's
>>> device tree.
>>> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
>>> +++ renesas/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
>>> @@ -34,6 +34,9 @@
>
> [...]
>>>
>>> @@ -53,6 +56,11 @@
>>> };
>>>
>>> &pfc {
>>> + avb_pins: avb {
>>> + groups = "avb0_mdio", "avb0_mii";
>>
>>
>> Oh no, its'called "avb0_mdio" here, but "avb(0)_mdc" on all other
>> R-Car Gen3 SoCs?
>
>
> Can you remember the reason? I don;t want to follow the bad example. :-)
Sorry, I don't know.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] arm64: dts: renesas: eagle: add EtherAVB pins
2017-11-15 16:21 ` Geert Uytterhoeven
@ 2017-11-15 20:21 ` Sergei Shtylyov
2017-11-16 12:28 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2017-11-15 20:21 UTC (permalink / raw)
To: linux-arm-kernel
Hello!
On 11/15/2017 07:21 PM, Geert Uytterhoeven wrote:
>>>> Add the (previously omitted) EtherAVB pin data to the Eagle board's
>>>> device tree.
>
>>>> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
>>>> +++ renesas/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
>>>> @@ -34,6 +34,9 @@
>>
>> [...]
>>>>
>>>> @@ -53,6 +56,11 @@
>>>> };
>>>>
>>>> &pfc {
>>>> + avb_pins: avb {
>>>> + groups = "avb0_mdio", "avb0_mii";
>>>
>>>
>>> Oh no, its'called "avb0_mdio" here, but "avb(0)_mdc" on all other
>>> R-Car Gen3 SoCs?
>>
>>
>> Can you remember the reason? I don;t want to follow the bad example. :-)
>
> Sorry, I don't know.
Hm, you seem to have participated in the related discussions for H2/M3-W...
The reason was that omlu AVB_MDC signal was multiplexed, AVB_MDIO signal (and
AVB MII signals) was mapped to a dedicated pin without any multiplexing, so
the "avb_mdc" group initially contained only AVB_MDC.
> Gr{oetje,eeting}s,
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] arm64: dts: renesas: eagle: add EtherAVB pins
2017-11-15 20:21 ` Sergei Shtylyov
@ 2017-11-16 12:28 ` Sergei Shtylyov
0 siblings, 0 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2017-11-16 12:28 UTC (permalink / raw)
To: linux-arm-kernel
On 11/15/2017 11:21 PM, Sergei Shtylyov wrote:
>>>>> Add the (previously omitted) EtherAVB pin data to the Eagle board's
>>>>> device tree.
>>
>>>>> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
>>>>> +++ renesas/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
>>>>> @@ -34,6 +34,9 @@
>>>
>>> [...]
>>>>>
>>>>> @@ -53,6 +56,11 @@
>>>>> };
>>>>>
>>>>> &pfc {
>>>>> + avb_pins: avb {
>>>>> + groups = "avb0_mdio", "avb0_mii";
>>>>
>>>>
>>>> Oh no, its'called "avb0_mdio" here, but "avb(0)_mdc" on all other
>>>> R-Car Gen3 SoCs?
>>>
>>>
>>> Can you remember the reason? I don;t want to follow the bad example. :-)
>>
>> Sorry, I don't know.
>
> Hm, you seem to have participated in the related discussions for H2/M3-W...
H3, of course...
> The reason was that omlu AVB_MDC signal was multiplexed, AVB_MDIO signal (and
s/omlu/only/.
> AVB MII signals) was mapped to a dedicated pin without any multiplexing, so
> the "avb_mdc" group initially contained only AVB_MDC.
>
>> Gr{oetje,eeting}s,
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-16 12:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-10 20:02 [PATCH 3/3] arm64: dts: renesas: eagle: add EtherAVB pins Sergei Shtylyov
2017-11-14 8:44 ` Geert Uytterhoeven
2017-11-14 18:00 ` Sergei Shtylyov
2017-11-15 16:21 ` Geert Uytterhoeven
2017-11-15 20:21 ` Sergei Shtylyov
2017-11-16 12:28 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).