linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO
@ 2016-09-01 13:51 Tomi Valkeinen
  2016-09-01 14:09 ` Nishanth Menon
  0 siblings, 1 reply; 11+ messages in thread
From: Tomi Valkeinen @ 2016-09-01 13:51 UTC (permalink / raw)
  To: linux-arm-kernel

LS_OE GPIO was changed from gpio6_28 to gpio2_30 for the Rev B1 board,
and the current .dts file has the old GPIO.

Rev B1 is the earliest board supported, so we can just change the .dts.

This fixes "omapdss error: HDMI I2C Master Error" which causes failure
to read EDID from the monitor.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 arch/arm/boot/dts/am57xx-beagle-x15.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/am57xx-beagle-x15.dts b/arch/arm/boot/dts/am57xx-beagle-x15.dts
index c4d04c5293b9..07603d9e2da7 100644
--- a/arch/arm/boot/dts/am57xx-beagle-x15.dts
+++ b/arch/arm/boot/dts/am57xx-beagle-x15.dts
@@ -120,7 +120,7 @@
 		pinctrl-0 = <&tpd12s015_pins>;
 
 		gpios = <&gpio7 10 GPIO_ACTIVE_HIGH>,	/* gpio7_10, CT CP HPD */
-			<&gpio6 28 GPIO_ACTIVE_HIGH>,	/* gpio6_28, LS OE */
+			<&gpio2 30 GPIO_ACTIVE_HIGH>,	/* gpio2_30, LS OE */
 			<&gpio7 12 GPIO_ACTIVE_HIGH>;	/* gpio7_12/sp1_cs2, HPD */
 
 		ports {
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH] ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO
  2016-09-01 13:51 [PATCH] ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO Tomi Valkeinen
@ 2016-09-01 14:09 ` Nishanth Menon
  2016-09-01 14:12   ` Robert Nelson
  0 siblings, 1 reply; 11+ messages in thread
From: Nishanth Menon @ 2016-09-01 14:09 UTC (permalink / raw)
  To: linux-arm-kernel

On 09/01/2016 08:51 AM, Tomi Valkeinen wrote:
> LS_OE GPIO was changed from gpio6_28 to gpio2_30 for the Rev B1 board,
> and the current .dts file has the old GPIO.
>
> Rev B1 is the earliest board supported, so we can just change the .dts.
>
> This fixes "omapdss error: HDMI I2C Master Error" which causes failure
> to read EDID from the monitor.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
>  arch/arm/boot/dts/am57xx-beagle-x15.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/am57xx-beagle-x15.dts b/arch/arm/boot/dts/am57xx-beagle-x15.dts
> index c4d04c5293b9..07603d9e2da7 100644
> --- a/arch/arm/boot/dts/am57xx-beagle-x15.dts
> +++ b/arch/arm/boot/dts/am57xx-beagle-x15.dts
> @@ -120,7 +120,7 @@
>  		pinctrl-0 = <&tpd12s015_pins>;
>
>  		gpios = <&gpio7 10 GPIO_ACTIVE_HIGH>,	/* gpio7_10, CT CP HPD */
> -			<&gpio6 28 GPIO_ACTIVE_HIGH>,	/* gpio6_28, LS OE */
> +			<&gpio2 30 GPIO_ACTIVE_HIGH>,	/* gpio2_30, LS OE */
>  			<&gpio7 12 GPIO_ACTIVE_HIGH>;	/* gpio7_12/sp1_cs2, HPD */
>
>  		ports {
>

I believe we have A2s being shipped as well. we dont want to break A2s 
either -> I propose we refactor the dts to introduce revb1 X15.

-- 
Regards,
Nishanth Menon

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH] ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO
  2016-09-01 14:09 ` Nishanth Menon
@ 2016-09-01 14:12   ` Robert Nelson
  2016-09-01 14:14     ` Nishanth Menon
  0 siblings, 1 reply; 11+ messages in thread
From: Robert Nelson @ 2016-09-01 14:12 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Sep 1, 2016 at 9:09 AM, Nishanth Menon <nm@ti.com> wrote:
> On 09/01/2016 08:51 AM, Tomi Valkeinen wrote:
>>
>> LS_OE GPIO was changed from gpio6_28 to gpio2_30 for the Rev B1 board,
>> and the current .dts file has the old GPIO.
>>
>> Rev B1 is the earliest board supported, so we can just change the .dts.
>>
>> This fixes "omapdss error: HDMI I2C Master Error" which causes failure
>> to read EDID from the monitor.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> ---
>>  arch/arm/boot/dts/am57xx-beagle-x15.dts | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/am57xx-beagle-x15.dts
>> b/arch/arm/boot/dts/am57xx-beagle-x15.dts
>> index c4d04c5293b9..07603d9e2da7 100644
>> --- a/arch/arm/boot/dts/am57xx-beagle-x15.dts
>> +++ b/arch/arm/boot/dts/am57xx-beagle-x15.dts
>> @@ -120,7 +120,7 @@
>>                 pinctrl-0 = <&tpd12s015_pins>;
>>
>>                 gpios = <&gpio7 10 GPIO_ACTIVE_HIGH>,   /* gpio7_10, CT CP
>> HPD */
>> -                       <&gpio6 28 GPIO_ACTIVE_HIGH>,   /* gpio6_28, LS OE
>> */
>> +                       <&gpio2 30 GPIO_ACTIVE_HIGH>,   /* gpio2_30, LS OE
>> */
>>                         <&gpio7 12 GPIO_ACTIVE_HIGH>;   /*
>> gpio7_12/sp1_cs2, HPD */
>>
>>                 ports {
>>
>
> I believe we have A2s being shipped as well. we dont want to break A2s
> either -> I propose we refactor the dts to introduce revb1 X15.

There are at-least 200 A2's that have been shipped to end users.

http://uk.rs-online.com/web/p/processor-microcontroller-development-kits/8874764/

Regards,

-- 
Robert Nelson
https://rcn-ee.com/

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH] ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO
  2016-09-01 14:12   ` Robert Nelson
@ 2016-09-01 14:14     ` Nishanth Menon
  2016-09-01 14:57       ` Tomi Valkeinen
  2016-09-01 14:57       ` Tony Lindgren
  0 siblings, 2 replies; 11+ messages in thread
From: Nishanth Menon @ 2016-09-01 14:14 UTC (permalink / raw)
  To: linux-arm-kernel

On 09/01/2016 09:12 AM, Robert Nelson wrote:
> On Thu, Sep 1, 2016 at 9:09 AM, Nishanth Menon <nm@ti.com> wrote:
>> On 09/01/2016 08:51 AM, Tomi Valkeinen wrote:
>>>
>>> LS_OE GPIO was changed from gpio6_28 to gpio2_30 for the Rev B1 board,
>>> and the current .dts file has the old GPIO.
>>>
>>> Rev B1 is the earliest board supported, so we can just change the .dts.
>>>
>>> This fixes "omapdss error: HDMI I2C Master Error" which causes failure
>>> to read EDID from the monitor.
>>>
>>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>>> ---
>>>  arch/arm/boot/dts/am57xx-beagle-x15.dts | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/am57xx-beagle-x15.dts
>>> b/arch/arm/boot/dts/am57xx-beagle-x15.dts
>>> index c4d04c5293b9..07603d9e2da7 100644
>>> --- a/arch/arm/boot/dts/am57xx-beagle-x15.dts
>>> +++ b/arch/arm/boot/dts/am57xx-beagle-x15.dts
>>> @@ -120,7 +120,7 @@
>>>                 pinctrl-0 = <&tpd12s015_pins>;
>>>
>>>                 gpios = <&gpio7 10 GPIO_ACTIVE_HIGH>,   /* gpio7_10, CT CP
>>> HPD */
>>> -                       <&gpio6 28 GPIO_ACTIVE_HIGH>,   /* gpio6_28, LS OE
>>> */
>>> +                       <&gpio2 30 GPIO_ACTIVE_HIGH>,   /* gpio2_30, LS OE
>>> */
>>>                         <&gpio7 12 GPIO_ACTIVE_HIGH>;   /*
>>> gpio7_12/sp1_cs2, HPD */
>>>
>>>                 ports {
>>>
>>
>> I believe we have A2s being shipped as well. we dont want to break A2s
>> either -> I propose we refactor the dts to introduce revb1 X15.
>
> There are at-least 200 A2's that have been shipped to end users.
>
> http://uk.rs-online.com/web/p/processor-microcontroller-development-kits/8874764/


Thanks. Tomi: if you are ok - I already do have a refactoring code 
from older kernel. I will rebase to latest and repost.

Tony: is there a branch youd' like me to base the changes on?


-- 
Regards,
Nishanth Menon

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH] ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO
  2016-09-01 14:14     ` Nishanth Menon
@ 2016-09-01 14:57       ` Tomi Valkeinen
  2016-09-01 14:57       ` Tony Lindgren
  1 sibling, 0 replies; 11+ messages in thread
From: Tomi Valkeinen @ 2016-09-01 14:57 UTC (permalink / raw)
  To: linux-arm-kernel

On 01/09/16 17:14, Nishanth Menon wrote:

>>> I believe we have A2s being shipped as well. we dont want to break A2s
>>> either -> I propose we refactor the dts to introduce revb1 X15.
>>
>> There are at-least 200 A2's that have been shipped to end users.
>>
>> http://uk.rs-online.com/web/p/processor-microcontroller-development-kits/8874764/
>>
> 
> 
> Thanks. Tomi: if you are ok - I already do have a refactoring code from
> older kernel. I will rebase to latest and repost.

Sounds good to me.

 Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160901/a81fda17/attachment.sig>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH] ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO
  2016-09-01 14:14     ` Nishanth Menon
  2016-09-01 14:57       ` Tomi Valkeinen
@ 2016-09-01 14:57       ` Tony Lindgren
  2016-09-01 15:00         ` Nishanth Menon
  1 sibling, 1 reply; 11+ messages in thread
From: Tony Lindgren @ 2016-09-01 14:57 UTC (permalink / raw)
  To: linux-arm-kernel

* Nishanth Menon <nm@ti.com> [160901 07:15]:
> On 09/01/2016 09:12 AM, Robert Nelson wrote:
> > On Thu, Sep 1, 2016 at 9:09 AM, Nishanth Menon <nm@ti.com> wrote:
> > > On 09/01/2016 08:51 AM, Tomi Valkeinen wrote:
> > > > 
> > > > LS_OE GPIO was changed from gpio6_28 to gpio2_30 for the Rev B1 board,
> > > > and the current .dts file has the old GPIO.
> > > > 
> > > > Rev B1 is the earliest board supported, so we can just change the .dts.
> > > > 
> > > > This fixes "omapdss error: HDMI I2C Master Error" which causes failure
> > > > to read EDID from the monitor.
...
> > > I believe we have A2s being shipped as well. we dont want to break A2s
> > > either -> I propose we refactor the dts to introduce revb1 X15.
> > 
> > There are at-least 200 A2's that have been shipped to end users.
> > 
> > http://uk.rs-online.com/web/p/processor-microcontroller-development-kits/8874764/
> 
> 
> Thanks. Tomi: if you are ok - I already do have a refactoring code from
> older kernel. I will rebase to latest and repost.
> 
> Tony: is there a branch youd' like me to base the changes on?

Probably best to do it against current omapf-for-v4.9/dt as it has all
the skeleton.dtsi removal now applied.

Regards,

Tony

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH] ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO
  2016-09-01 14:57       ` Tony Lindgren
@ 2016-09-01 15:00         ` Nishanth Menon
  2017-11-14  0:27           ` Bill Traynor
  0 siblings, 1 reply; 11+ messages in thread
From: Nishanth Menon @ 2016-09-01 15:00 UTC (permalink / raw)
  To: linux-arm-kernel

On 09/01/2016 09:57 AM, Tony Lindgren wrote:
> * Nishanth Menon <nm@ti.com> [160901 07:15]:
>> On 09/01/2016 09:12 AM, Robert Nelson wrote:
>>> On Thu, Sep 1, 2016 at 9:09 AM, Nishanth Menon <nm@ti.com> wrote:
>>>> On 09/01/2016 08:51 AM, Tomi Valkeinen wrote:
>>>>>
>>>>> LS_OE GPIO was changed from gpio6_28 to gpio2_30 for the Rev B1 board,
>>>>> and the current .dts file has the old GPIO.
>>>>>
>>>>> Rev B1 is the earliest board supported, so we can just change the .dts.
>>>>>
>>>>> This fixes "omapdss error: HDMI I2C Master Error" which causes failure
>>>>> to read EDID from the monitor.
> ...
>>>> I believe we have A2s being shipped as well. we dont want to break A2s
>>>> either -> I propose we refactor the dts to introduce revb1 X15.
>>>
>>> There are at-least 200 A2's that have been shipped to end users.
>>>
>>> http://uk.rs-online.com/web/p/processor-microcontroller-development-kits/8874764/
>>
>>
>> Thanks. Tomi: if you are ok - I already do have a refactoring code from
>> older kernel. I will rebase to latest and repost.
>>
>> Tony: is there a branch youd' like me to base the changes on?
>
> Probably best to do it against current omapf-for-v4.9/dt as it has all
> the skeleton.dtsi removal now applied.

Ok will do, will try to post this later today or early tomorrow.


-- 
Regards,
Nishanth Menon

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH] ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO
  2016-09-01 15:00         ` Nishanth Menon
@ 2017-11-14  0:27           ` Bill Traynor
  2017-11-14  7:33             ` Tomi Valkeinen
  0 siblings, 1 reply; 11+ messages in thread
From: Bill Traynor @ 2017-11-14  0:27 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Sep 1, 2016 at 11:00 AM, Nishanth Menon <nm@ti.com> wrote:
> On 09/01/2016 09:57 AM, Tony Lindgren wrote:
>>
>> * Nishanth Menon <nm@ti.com> [160901 07:15]:
>>>
>>> On 09/01/2016 09:12 AM, Robert Nelson wrote:
>>>>
>>>> On Thu, Sep 1, 2016 at 9:09 AM, Nishanth Menon <nm@ti.com> wrote:
>>>>>
>>>>> On 09/01/2016 08:51 AM, Tomi Valkeinen wrote:
>>>>>>
>>>>>>
>>>>>> LS_OE GPIO was changed from gpio6_28 to gpio2_30 for the Rev B1 board,
>>>>>> and the current .dts file has the old GPIO.
>>>>>>
>>>>>> Rev B1 is the earliest board supported, so we can just change the
>>>>>> .dts.
>>>>>>
>>>>>> This fixes "omapdss error: HDMI I2C Master Error" which causes failure
>>>>>> to read EDID from the monitor.
>>
>> ...
>>>>>
>>>>> I believe we have A2s being shipped as well. we dont want to break A2s
>>>>> either -> I propose we refactor the dts to introduce revb1 X15.
>>>>
>>>>
>>>> There are at-least 200 A2's that have been shipped to end users.
>>>>
>>>>
>>>> http://uk.rs-online.com/web/p/processor-microcontroller-development-kits/8874764/
>>>
>>>
>>>
>>> Thanks. Tomi: if you are ok - I already do have a refactoring code from
>>> older kernel. I will rebase to latest and repost.
>>>
>>> Tony: is there a branch youd' like me to base the changes on?
>>
>>
>> Probably best to do it against current omapf-for-v4.9/dt as it has all
>> the skeleton.dtsi removal now applied.
>
>
> Ok will do, will try to post this later today or early tomorrow.

I'm getting this error again with the latest X15 image on my A2
version board.  I don't see this patch in the mainline kernel.  Did it
never get applied?

Thanks
Bill

>
>
> --
> Regards,
> Nishanth Menon
>
> --
> You received this message because you are subscribed to the Google Groups
> "beagleboard-x15" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to beagleboard-x15+unsubscribe at googlegroups.com.
> To post to this group, send email to beagleboard-x15 at googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/beagleboard-x15/de3bf6ab-a07a-b82d-1e45-5f96a6e1039e%40ti.com.
>
> For more options, visit https://groups.google.com/d/optout.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH] ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO
  2017-11-14  0:27           ` Bill Traynor
@ 2017-11-14  7:33             ` Tomi Valkeinen
  2017-11-14 14:14               ` Bill Traynor
  0 siblings, 1 reply; 11+ messages in thread
From: Tomi Valkeinen @ 2017-11-14  7:33 UTC (permalink / raw)
  To: linux-arm-kernel

On 14/11/17 02:27, Bill Traynor wrote:

> I'm getting this error again with the latest X15 image on my A2
> version board.  I don't see this patch in the mainline kernel.  Did it
> never get applied?

With am57xx-beagle-x15.dts? That seems be the A2 version.

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH] ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO
  2017-11-14  7:33             ` Tomi Valkeinen
@ 2017-11-14 14:14               ` Bill Traynor
  2017-11-14 16:07                 ` Robert Nelson
  0 siblings, 1 reply; 11+ messages in thread
From: Bill Traynor @ 2017-11-14 14:14 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Nov 14, 2017 at 2:33 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> On 14/11/17 02:27, Bill Traynor wrote:
>
>> I'm getting this error again with the latest X15 image on my A2
>> version board.  I don't see this patch in the mainline kernel.  Did it
>> never get applied?
>
> With am57xx-beagle-x15.dts? That seems be the A2 version.

Yes.
I see the following in the boot message

loading /boot/dtbs/4.9.35-ti-r44/am57xx-beagle-x15.dtb ...

I can get around this by inserting/uninserting an sdcard once the
kernel starts booting.

This is with the Debian 9.0 2017-07-02 4GB SD LXQT image.

Thanks
Bill

>
> --
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH] ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO
  2017-11-14 14:14               ` Bill Traynor
@ 2017-11-14 16:07                 ` Robert Nelson
  0 siblings, 0 replies; 11+ messages in thread
From: Robert Nelson @ 2017-11-14 16:07 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Nov 14, 2017 at 8:14 AM, Bill Traynor <btraynor@gmail.com> wrote:
> On Tue, Nov 14, 2017 at 2:33 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>> On 14/11/17 02:27, Bill Traynor wrote:
>>
>>> I'm getting this error again with the latest X15 image on my A2
>>> version board.  I don't see this patch in the mainline kernel.  Did it
>>> never get applied?
>>
>> With am57xx-beagle-x15.dts? That seems be the A2 version.
>
> Yes.
> I see the following in the boot message
>
> loading /boot/dtbs/4.9.35-ti-r44/am57xx-beagle-x15.dtb ...
>
> I can get around this by inserting/uninserting an sdcard once the
> kernel starts booting.
>
> This is with the Debian 9.0 2017-07-02 4GB SD LXQT image.

Weird, ldo1 is set to always on:

https://github.com/RobertCNelson/linux-stable-rcn-ee/blob/4.9.35-ti-r44/arch/arm/boot/dts/am57xx-beagle-x15-common.dtsi#L276-L283

Something else is going on..

Regards,

-- 
Robert Nelson
https://rcn-ee.com/

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2017-11-14 16:07 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-01 13:51 [PATCH] ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO Tomi Valkeinen
2016-09-01 14:09 ` Nishanth Menon
2016-09-01 14:12   ` Robert Nelson
2016-09-01 14:14     ` Nishanth Menon
2016-09-01 14:57       ` Tomi Valkeinen
2016-09-01 14:57       ` Tony Lindgren
2016-09-01 15:00         ` Nishanth Menon
2017-11-14  0:27           ` Bill Traynor
2017-11-14  7:33             ` Tomi Valkeinen
2017-11-14 14:14               ` Bill Traynor
2017-11-14 16:07                 ` Robert Nelson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).