* Re: [PATCH] MAINTAINERS: Add entries for CoreSight and Arm SPE
[not found] <20200817193140.3659956-1-mathieu.poirier@linaro.org>
@ 2020-08-18 17:54 ` John Garry
2020-08-19 2:24 ` Leo Yan
2020-08-19 17:01 ` Mathieu Poirier
0 siblings, 2 replies; 6+ messages in thread
From: John Garry @ 2020-08-18 17:54 UTC (permalink / raw)
To: Mathieu Poirier, acme, will, leo.yan
Cc: Mark Rutland, Jiri Olsa, linux-kernel, linux-arm-kernel
On 17/08/2020 20:31, Mathieu Poirier wrote:
> Add entries for perf tools elements related to the support of
> Arm CoreSight and Arm SPE.
Thanks for doing this...
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
> MAINTAINERS | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4e2698cc7e23..f9bb76baeec9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -13427,8 +13427,18 @@ F: tools/perf/
> PERFORMANCE EVENTS SUBSYSTEM ARM64 PMU EVENTS
> R: John Garry <john.garry@huawei.com>
> R: Will Deacon <will@kernel.org>
> +R: Mathieu Poirier <mathieu.poirier@linaro.org>
> +R: Leo Yan <leo.yan@linaro.org>
> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> S: Supported
> +F: tools/build/feature/test-libopencsd.c
> +F: tools/perf/arch/arm/util/auxtrace.c
> +F: tools/perf/arch/arm/util/cs-etm.*
> +F: tools/perf/arch/arm/util/pmu.c
> +F: tools/perf/arch/arm64/util/arm-spe.c
> +F: tools/perf/util/arm-spe.h
> +F: tools/perf/util/cs-etm-decoder/*
> +F: tools/perf/util/cs-etm.*
But from the previous discussion, I thought that we wanted an entry to
cover all tools/perf/arch/arm64/ and other related folders. Or was it
just put all special interest parts (like SPE support) under one entry
and leave the other arm/arm64 parts to be caught by "PERFORMANCE EVENTS
SUBSYSTEM" entry?
Cheers,
John
> F: tools/perf/pmu-events/arch/arm64/
>
> PERSONALITY HANDLING
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MAINTAINERS: Add entries for CoreSight and Arm SPE
2020-08-18 17:54 ` [PATCH] MAINTAINERS: Add entries for CoreSight and Arm SPE John Garry
@ 2020-08-19 2:24 ` Leo Yan
2020-08-19 17:01 ` Mathieu Poirier
1 sibling, 0 replies; 6+ messages in thread
From: Leo Yan @ 2020-08-19 2:24 UTC (permalink / raw)
To: John Garry
Cc: Mark Rutland, Mathieu Poirier, will, linux-kernel, acme,
Jiri Olsa, linux-arm-kernel
On Tue, Aug 18, 2020 at 06:54:28PM +0100, John Garry wrote:
> On 17/08/2020 20:31, Mathieu Poirier wrote:
> > Add entries for perf tools elements related to the support of
> > Arm CoreSight and Arm SPE.
>
> Thanks for doing this...
>
> >
> > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> > ---
> > MAINTAINERS | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 4e2698cc7e23..f9bb76baeec9 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -13427,8 +13427,18 @@ F: tools/perf/
> > PERFORMANCE EVENTS SUBSYSTEM ARM64 PMU EVENTS
> > R: John Garry <john.garry@huawei.com>
> > R: Will Deacon <will@kernel.org>
> > +R: Mathieu Poirier <mathieu.poirier@linaro.org>
> > +R: Leo Yan <leo.yan@linaro.org>
> > L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> > S: Supported
> > +F: tools/build/feature/test-libopencsd.c
> > +F: tools/perf/arch/arm/util/auxtrace.c
> > +F: tools/perf/arch/arm/util/cs-etm.*
> > +F: tools/perf/arch/arm/util/pmu.c
> > +F: tools/perf/arch/arm64/util/arm-spe.c
> > +F: tools/perf/util/arm-spe.h
> > +F: tools/perf/util/cs-etm-decoder/*
> > +F: tools/perf/util/cs-etm.*
>
> But from the previous discussion, I thought that we wanted an entry to cover
> all tools/perf/arch/arm64/ and other related folders. Or was it just put all
> special interest parts (like SPE support) under one entry and leave the
> other arm/arm64 parts to be caught by "PERFORMANCE EVENTS SUBSYSTEM" entry?
Yes, I think we need to add below two items for Arm SPE:
F: tools/perf/util/arm-spe-decoder/*
F: tools/perf/util/arm-spe.*
Thanks,
Leo
> > F: tools/perf/pmu-events/arch/arm64/
> > PERSONALITY HANDLING
> >
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MAINTAINERS: Add entries for CoreSight and Arm SPE
2020-08-18 17:54 ` [PATCH] MAINTAINERS: Add entries for CoreSight and Arm SPE John Garry
2020-08-19 2:24 ` Leo Yan
@ 2020-08-19 17:01 ` Mathieu Poirier
2020-08-19 17:30 ` Will Deacon
1 sibling, 1 reply; 6+ messages in thread
From: Mathieu Poirier @ 2020-08-19 17:01 UTC (permalink / raw)
To: John Garry
Cc: Mark Rutland, Will Deacon, Linux Kernel Mailing List,
Arnaldo Carvalho de Melo, Leo Yan, Jiri Olsa, linux-arm-kernel
On Tue, 18 Aug 2020 at 11:56, John Garry <john.garry@huawei.com> wrote:
>
> On 17/08/2020 20:31, Mathieu Poirier wrote:
> > Add entries for perf tools elements related to the support of
> > Arm CoreSight and Arm SPE.
>
> Thanks for doing this...
>
> >
> > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> > ---
> > MAINTAINERS | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 4e2698cc7e23..f9bb76baeec9 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -13427,8 +13427,18 @@ F: tools/perf/
> > PERFORMANCE EVENTS SUBSYSTEM ARM64 PMU EVENTS
> > R: John Garry <john.garry@huawei.com>
> > R: Will Deacon <will@kernel.org>
> > +R: Mathieu Poirier <mathieu.poirier@linaro.org>
> > +R: Leo Yan <leo.yan@linaro.org>
> > L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> > S: Supported
> > +F: tools/build/feature/test-libopencsd.c
> > +F: tools/perf/arch/arm/util/auxtrace.c
> > +F: tools/perf/arch/arm/util/cs-etm.*
> > +F: tools/perf/arch/arm/util/pmu.c
> > +F: tools/perf/arch/arm64/util/arm-spe.c
> > +F: tools/perf/util/arm-spe.h
> > +F: tools/perf/util/cs-etm-decoder/*
> > +F: tools/perf/util/cs-etm.*
>
> But from the previous discussion, I thought that we wanted an entry to
> cover all tools/perf/arch/arm64/ and other related folders. Or was it
> just put all special interest parts (like SPE support) under one entry
> and leave the other arm/arm64 parts to be caught by "PERFORMANCE EVENTS
> SUBSYSTEM" entry?
I do not have the time to maintain anything outside of coresight -
listing individual files as I did removes any ambiguity on that front.
I'm happy to add tools/perf/arch/arm and tools/perf/arch/arm64/ if you
agree to maintain them. In that case you will have to be more
specific about the "other related folders" you are referring to above.
Thanks,
Mathieu
>
> Cheers,
> John
>
> > F: tools/perf/pmu-events/arch/arm64/
> >
> > PERSONALITY HANDLING
> >
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MAINTAINERS: Add entries for CoreSight and Arm SPE
2020-08-19 17:01 ` Mathieu Poirier
@ 2020-08-19 17:30 ` Will Deacon
2020-08-19 19:26 ` Mathieu Poirier
0 siblings, 1 reply; 6+ messages in thread
From: Will Deacon @ 2020-08-19 17:30 UTC (permalink / raw)
To: Mathieu Poirier
Cc: Mark Rutland, John Garry, Linux Kernel Mailing List,
Arnaldo Carvalho de Melo, Leo Yan, Jiri Olsa, linux-arm-kernel
On Wed, Aug 19, 2020 at 11:01:38AM -0600, Mathieu Poirier wrote:
> On Tue, 18 Aug 2020 at 11:56, John Garry <john.garry@huawei.com> wrote:
> > On 17/08/2020 20:31, Mathieu Poirier wrote:
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 4e2698cc7e23..f9bb76baeec9 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -13427,8 +13427,18 @@ F: tools/perf/
> > > PERFORMANCE EVENTS SUBSYSTEM ARM64 PMU EVENTS
> > > R: John Garry <john.garry@huawei.com>
> > > R: Will Deacon <will@kernel.org>
> > > +R: Mathieu Poirier <mathieu.poirier@linaro.org>
> > > +R: Leo Yan <leo.yan@linaro.org>
> > > L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> > > S: Supported
> > > +F: tools/build/feature/test-libopencsd.c
> > > +F: tools/perf/arch/arm/util/auxtrace.c
> > > +F: tools/perf/arch/arm/util/cs-etm.*
> > > +F: tools/perf/arch/arm/util/pmu.c
> > > +F: tools/perf/arch/arm64/util/arm-spe.c
> > > +F: tools/perf/util/arm-spe.h
> > > +F: tools/perf/util/cs-etm-decoder/*
> > > +F: tools/perf/util/cs-etm.*
> >
> > But from the previous discussion, I thought that we wanted an entry to
> > cover all tools/perf/arch/arm64/ and other related folders. Or was it
> > just put all special interest parts (like SPE support) under one entry
> > and leave the other arm/arm64 parts to be caught by "PERFORMANCE EVENTS
> > SUBSYSTEM" entry?
>
> I do not have the time to maintain anything outside of coresight -
> listing individual files as I did removes any ambiguity on that front.
> I'm happy to add tools/perf/arch/arm and tools/perf/arch/arm64/ if you
> agree to maintain them. In that case you will have to be more
> specific about the "other related folders" you are referring to above.
None of us have time for this, hence why I think putting us all in one entry
with all of the files listed there makes the most sense; then people do
whatever they can and try to help each other out based on how much time they
have. I think that's much better than fine-grained maintainership where a
given file has a single point of failure.
So I think it should include:
tools/perf/arch/arm64/
tools/pmu-events/arch/arm64/
along with the SPE and Coresight files.
Arnaldo would still handle the patches, so this is really about giving us a
chance to review incoming patches without having to fish them out from the
lists.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MAINTAINERS: Add entries for CoreSight and Arm SPE
2020-08-19 17:30 ` Will Deacon
@ 2020-08-19 19:26 ` Mathieu Poirier
2020-08-20 7:50 ` John Garry
0 siblings, 1 reply; 6+ messages in thread
From: Mathieu Poirier @ 2020-08-19 19:26 UTC (permalink / raw)
To: Will Deacon
Cc: Mark Rutland, John Garry, Linux Kernel Mailing List,
Arnaldo Carvalho de Melo, Leo Yan, Jiri Olsa, linux-arm-kernel
On Wed, 19 Aug 2020 at 11:30, Will Deacon <will@kernel.org> wrote:
>
> On Wed, Aug 19, 2020 at 11:01:38AM -0600, Mathieu Poirier wrote:
> > On Tue, 18 Aug 2020 at 11:56, John Garry <john.garry@huawei.com> wrote:
> > > On 17/08/2020 20:31, Mathieu Poirier wrote:
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index 4e2698cc7e23..f9bb76baeec9 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -13427,8 +13427,18 @@ F: tools/perf/
> > > > PERFORMANCE EVENTS SUBSYSTEM ARM64 PMU EVENTS
> > > > R: John Garry <john.garry@huawei.com>
> > > > R: Will Deacon <will@kernel.org>
> > > > +R: Mathieu Poirier <mathieu.poirier@linaro.org>
> > > > +R: Leo Yan <leo.yan@linaro.org>
> > > > L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> > > > S: Supported
> > > > +F: tools/build/feature/test-libopencsd.c
> > > > +F: tools/perf/arch/arm/util/auxtrace.c
> > > > +F: tools/perf/arch/arm/util/cs-etm.*
> > > > +F: tools/perf/arch/arm/util/pmu.c
> > > > +F: tools/perf/arch/arm64/util/arm-spe.c
> > > > +F: tools/perf/util/arm-spe.h
> > > > +F: tools/perf/util/cs-etm-decoder/*
> > > > +F: tools/perf/util/cs-etm.*
> > >
> > > But from the previous discussion, I thought that we wanted an entry to
> > > cover all tools/perf/arch/arm64/ and other related folders. Or was it
> > > just put all special interest parts (like SPE support) under one entry
> > > and leave the other arm/arm64 parts to be caught by "PERFORMANCE EVENTS
> > > SUBSYSTEM" entry?
> >
> > I do not have the time to maintain anything outside of coresight -
> > listing individual files as I did removes any ambiguity on that front.
> > I'm happy to add tools/perf/arch/arm and tools/perf/arch/arm64/ if you
> > agree to maintain them. In that case you will have to be more
> > specific about the "other related folders" you are referring to above.
>
> None of us have time for this, hence why I think putting us all in one entry
> with all of the files listed there makes the most sense; then people do
> whatever they can and try to help each other out based on how much time they
> have. I think that's much better than fine-grained maintainership where a
> given file has a single point of failure.
Thanks for the clarification - just wanted to make sure I don't sign
you guys up for something you didn't agree to.
>
> So I think it should include:
>
> tools/perf/arch/arm64/
> tools/pmu-events/arch/arm64/
>
> along with the SPE and Coresight files.
>
> Arnaldo would still handle the patches, so this is really about giving us a
> chance to review incoming patches without having to fish them out from the
> lists.
>
> Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MAINTAINERS: Add entries for CoreSight and Arm SPE
2020-08-19 19:26 ` Mathieu Poirier
@ 2020-08-20 7:50 ` John Garry
0 siblings, 0 replies; 6+ messages in thread
From: John Garry @ 2020-08-20 7:50 UTC (permalink / raw)
To: Mathieu Poirier, Will Deacon
Cc: Mark Rutland, Linux Kernel Mailing List,
Arnaldo Carvalho de Melo, Leo Yan, Jiri Olsa, linux-arm-kernel
On 19/08/2020 20:26, Mathieu Poirier wrote:
> On Wed, 19 Aug 2020 at 11:30, Will Deacon <will@kernel.org> wrote:
>>
>> On Wed, Aug 19, 2020 at 11:01:38AM -0600, Mathieu Poirier wrote:
>>> On Tue, 18 Aug 2020 at 11:56, John Garry <john.garry@huawei.com> wrote:
>>>> On 17/08/2020 20:31, Mathieu Poirier wrote:
>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>>> index 4e2698cc7e23..f9bb76baeec9 100644
>>>>> --- a/MAINTAINERS
>>>>> +++ b/MAINTAINERS
>>>>> @@ -13427,8 +13427,18 @@ F: tools/perf/
>>>>> PERFORMANCE EVENTS SUBSYSTEM ARM64 PMU EVENTS
Maybe "PERFORMANCE EVENTS SUBSYSTEM ARM64" would be more appropriate now.
>>>>> R: John Garry <john.garry@huawei.com>
>>>>> R: Will Deacon <will@kernel.org>
>>>>> +R: Mathieu Poirier <mathieu.poirier@linaro.org>
>>>>> +R: Leo Yan <leo.yan@linaro.org>
>>>>> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
>>>>> S: Supported
>>>>> +F: tools/build/feature/test-libopencsd.c
>>>>> +F: tools/perf/arch/arm/util/auxtrace.c
>>>>> +F: tools/perf/arch/arm/util/cs-etm.*
>>>>> +F: tools/perf/arch/arm/util/pmu.c
>>>>> +F: tools/perf/arch/arm64/util/arm-spe.c
>>>>> +F: tools/perf/util/arm-spe.h
>>>>> +F: tools/perf/util/cs-etm-decoder/*
>>>>> +F: tools/perf/util/cs-etm.*
>>>>
>>>> But from the previous discussion, I thought that we wanted an entry to
>>>> cover all tools/perf/arch/arm64/ and other related folders. Or was it
>>>> just put all special interest parts (like SPE support) under one entry
>>>> and leave the other arm/arm64 parts to be caught by "PERFORMANCE EVENTS
>>>> SUBSYSTEM" entry?
>>>
>>> I do not have the time to maintain anything outside of coresight -
>>> listing individual files as I did removes any ambiguity on that front.
>>> I'm happy to add tools/perf/arch/arm and tools/perf/arch/arm64/ if you
>>> agree to maintain them. In that case you will have to be more
>>> specific about the "other related folders" you are referring to above.
As Leo mentioned, I was thinking of tools/perf/util/arm-spe-decoder/
>>
>> None of us have time for this, hence why I think putting us all in one entry
>> with all of the files listed there makes the most sense; then people do
>> whatever they can and try to help each other out based on how much time they
>> have. I think that's much better than fine-grained maintainership where a
>> given file has a single point of failure.
>
> Thanks for the clarification - just wanted to make sure I don't sign
> you guys up for something you didn't agree to.
And it's "R:" level, so none of the commitment associated with "M:". In
addition - and maybe most important - the linux-arm-kernel list will (or
should) be cc'ed.
>
>>
>> So I think it should include:
>>
>> tools/perf/arch/arm64/
>> tools/pmu-events/arch/arm64/
>>
>> along with the SPE and Coresight files.
>>
>> Arnaldo would still handle the patches, so this is really about giving us a
>> chance to review incoming patches without having to fish them out from the
>> lists.
>>
>> Will
> .
>
Cheers,
John
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-20 7:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200817193140.3659956-1-mathieu.poirier@linaro.org>
2020-08-18 17:54 ` [PATCH] MAINTAINERS: Add entries for CoreSight and Arm SPE John Garry
2020-08-19 2:24 ` Leo Yan
2020-08-19 17:01 ` Mathieu Poirier
2020-08-19 17:30 ` Will Deacon
2020-08-19 19:26 ` Mathieu Poirier
2020-08-20 7:50 ` John Garry
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).