* [PATCH] ARM: dts: imx6qdl-sabreauto: Fix storm of accelerometer interrupts
@ 2019-10-09 20:43 Fabio Estevam
2019-10-25 6:16 ` Shawn Guo
2019-10-26 8:07 ` Shawn Guo
0 siblings, 2 replies; 5+ messages in thread
From: Fabio Estevam @ 2019-10-09 20:43 UTC (permalink / raw)
To: shawnguo
Cc: linux-arm-kernel, leonard.crestez, Fabio Estevam, linux-imx, kernel
Since commit a211b8c55f3c ("ARM: dts: imx6qdl-sabreauto: Add sensors")
a storm of accelerometer interrupts is seen:
[ 114.211283] irq 260: nobody cared (try booting with the "irqpoll" option)
[ 114.218108] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.3.4 #1
[ 114.223960] Hardware name: Freescale i.MX6 Quad/DualLite (Device Tree)
[ 114.230531] [<c0112858>] (unwind_backtrace) from [<c010cdc8>] (show_stack+0x10/0x14)
[ 114.238301] [<c010cdc8>] (show_stack) from [<c0c1aa1c>] (dump_stack+0xd8/0x110)
[ 114.245644] [<c0c1aa1c>] (dump_stack) from [<c0193594>] (__report_bad_irq+0x30/0xc0)
[ 114.253417] [<c0193594>] (__report_bad_irq) from [<c01933ac>] (note_interrupt+0x108/0x298)
[ 114.261707] [<c01933ac>] (note_interrupt) from [<c018ffe4>] (handle_irq_event_percpu+0x70/0x80)
[ 114.270433] [<c018ffe4>] (handle_irq_event_percpu) from [<c019002c>] (handle_irq_event+0x38/0x5c)
[ 114.279326] [<c019002c>] (handle_irq_event) from [<c019438c>] (handle_level_irq+0xc8/0x154)
[ 114.287701] [<c019438c>] (handle_level_irq) from [<c018eda0>] (generic_handle_irq+0x20/0x34)
[ 114.296166] [<c018eda0>] (generic_handle_irq) from [<c0534214>] (mxc_gpio_irq_handler+0x30/0xf0)
[ 114.304975] [<c0534214>] (mxc_gpio_irq_handler) from [<c0534334>] (mx3_gpio_irq_handler+0x60/0xb0)
[ 114.313955] [<c0534334>] (mx3_gpio_irq_handler) from [<c018eda0>] (generic_handle_irq+0x20/0x34)
[ 114.322762] [<c018eda0>] (generic_handle_irq) from [<c018f3ac>] (__handle_domain_irq+0x64/0xe0)
[ 114.331485] [<c018f3ac>] (__handle_domain_irq) from [<c05215a8>] (gic_handle_irq+0x4c/0xa8)
[ 114.339862] [<c05215a8>] (gic_handle_irq) from [<c0101a70>] (__irq_svc+0x70/0x98)
[ 114.347361] Exception stack(0xc1301ec0 to 0xc1301f08)
[ 114.352435] 1ec0: 00000001 00000006 00000000 c130c340 00000001 c130f688 9785636d c13ea2e8
[ 114.360635] 1ee0: 9784907d 0000001a eaf99d78 0000001a 00000000 c1301f10 c0182b00 c0878de4
[ 114.368830] 1f00: 20000013 ffffffff
[ 114.372349] [<c0101a70>] (__irq_svc) from [<c0878de4>] (cpuidle_enter_state+0x168/0x5f4)
[ 114.380464] [<c0878de4>] (cpuidle_enter_state) from [<c08792ac>] (cpuidle_enter+0x28/0x38)
[ 114.388751] [<c08792ac>] (cpuidle_enter) from [<c015ef9c>] (do_idle+0x224/0x2a8)
[ 114.396168] [<c015ef9c>] (do_idle) from [<c015f3b8>] (cpu_startup_entry+0x18/0x20)
[ 114.403765] [<c015f3b8>] (cpu_startup_entry) from [<c1200e54>] (start_kernel+0x43c/0x500)
[ 114.411958] handlers:
[ 114.414302] [<a01028b8>] irq_default_primary_handler threaded [<fd7a3b08>] mma8452_interrupt
[ 114.422974] Disabling IRQ #260
# cat /proc/interrupts
CPU0 CPU1
....
260: 100001 0 gpio-mxc 31 Level mma8451
The MMA8451 interrupt triggers as low level, so the GPIO6_IO31 pin
needs to activate its pull up, otherwise it will stay always at low level
generating multiple interrupts.
The current device tree does not configure the IOMUX for this pin, so
it uses whathever comes configured from the bootloader.
The IOMUXC_SW_PAD_CTL_PAD_EIM_BCLK register value comes as 0x8000 from
the bootloader, which has PKE bit cleared, hence disabling the
pull-up.
Instead of relying on a previous configuration from the bootloader,
configure the GPIO6_IO31 pin with pull-up enabled in order to fix
this problem.
Fixes: a211b8c55f3c ("ARM: dts: imx6qdl-sabreauto: Add sensors")
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
index f3404dd10537..cf628465cd0a 100644
--- a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
@@ -230,6 +230,8 @@
accelerometer@1c {
compatible = "fsl,mma8451";
reg = <0x1c>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_mma8451_int>;
interrupt-parent = <&gpio6>;
interrupts = <31 IRQ_TYPE_LEVEL_LOW>;
};
@@ -628,6 +630,12 @@
>;
};
+ pinctrl_mma8451_int: mma8451intgrp {
+ fsl,pins = <
+ MX6QDL_PAD_EIM_BCLK__GPIO6_IO31 0xb0b1
+ >;
+ };
+
pinctrl_pwm3: pwm1grp {
fsl,pins = <
MX6QDL_PAD_SD4_DAT1__PWM3_OUT 0x1b0b1
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: imx6qdl-sabreauto: Fix storm of accelerometer interrupts
2019-10-09 20:43 [PATCH] ARM: dts: imx6qdl-sabreauto: Fix storm of accelerometer interrupts Fabio Estevam
@ 2019-10-25 6:16 ` Shawn Guo
2019-10-25 16:09 ` Leonard Crestez
2019-10-26 8:07 ` Shawn Guo
1 sibling, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2019-10-25 6:16 UTC (permalink / raw)
To: Fabio Estevam; +Cc: linux-arm-kernel, leonard.crestez, linux-imx, kernel
@Leonard, comment?
Shawn
On Wed, Oct 09, 2019 at 05:43:43PM -0300, Fabio Estevam wrote:
> Since commit a211b8c55f3c ("ARM: dts: imx6qdl-sabreauto: Add sensors")
> a storm of accelerometer interrupts is seen:
>
> [ 114.211283] irq 260: nobody cared (try booting with the "irqpoll" option)
> [ 114.218108] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.3.4 #1
> [ 114.223960] Hardware name: Freescale i.MX6 Quad/DualLite (Device Tree)
> [ 114.230531] [<c0112858>] (unwind_backtrace) from [<c010cdc8>] (show_stack+0x10/0x14)
> [ 114.238301] [<c010cdc8>] (show_stack) from [<c0c1aa1c>] (dump_stack+0xd8/0x110)
> [ 114.245644] [<c0c1aa1c>] (dump_stack) from [<c0193594>] (__report_bad_irq+0x30/0xc0)
> [ 114.253417] [<c0193594>] (__report_bad_irq) from [<c01933ac>] (note_interrupt+0x108/0x298)
> [ 114.261707] [<c01933ac>] (note_interrupt) from [<c018ffe4>] (handle_irq_event_percpu+0x70/0x80)
> [ 114.270433] [<c018ffe4>] (handle_irq_event_percpu) from [<c019002c>] (handle_irq_event+0x38/0x5c)
> [ 114.279326] [<c019002c>] (handle_irq_event) from [<c019438c>] (handle_level_irq+0xc8/0x154)
> [ 114.287701] [<c019438c>] (handle_level_irq) from [<c018eda0>] (generic_handle_irq+0x20/0x34)
> [ 114.296166] [<c018eda0>] (generic_handle_irq) from [<c0534214>] (mxc_gpio_irq_handler+0x30/0xf0)
> [ 114.304975] [<c0534214>] (mxc_gpio_irq_handler) from [<c0534334>] (mx3_gpio_irq_handler+0x60/0xb0)
> [ 114.313955] [<c0534334>] (mx3_gpio_irq_handler) from [<c018eda0>] (generic_handle_irq+0x20/0x34)
> [ 114.322762] [<c018eda0>] (generic_handle_irq) from [<c018f3ac>] (__handle_domain_irq+0x64/0xe0)
> [ 114.331485] [<c018f3ac>] (__handle_domain_irq) from [<c05215a8>] (gic_handle_irq+0x4c/0xa8)
> [ 114.339862] [<c05215a8>] (gic_handle_irq) from [<c0101a70>] (__irq_svc+0x70/0x98)
> [ 114.347361] Exception stack(0xc1301ec0 to 0xc1301f08)
> [ 114.352435] 1ec0: 00000001 00000006 00000000 c130c340 00000001 c130f688 9785636d c13ea2e8
> [ 114.360635] 1ee0: 9784907d 0000001a eaf99d78 0000001a 00000000 c1301f10 c0182b00 c0878de4
> [ 114.368830] 1f00: 20000013 ffffffff
> [ 114.372349] [<c0101a70>] (__irq_svc) from [<c0878de4>] (cpuidle_enter_state+0x168/0x5f4)
> [ 114.380464] [<c0878de4>] (cpuidle_enter_state) from [<c08792ac>] (cpuidle_enter+0x28/0x38)
> [ 114.388751] [<c08792ac>] (cpuidle_enter) from [<c015ef9c>] (do_idle+0x224/0x2a8)
> [ 114.396168] [<c015ef9c>] (do_idle) from [<c015f3b8>] (cpu_startup_entry+0x18/0x20)
> [ 114.403765] [<c015f3b8>] (cpu_startup_entry) from [<c1200e54>] (start_kernel+0x43c/0x500)
> [ 114.411958] handlers:
> [ 114.414302] [<a01028b8>] irq_default_primary_handler threaded [<fd7a3b08>] mma8452_interrupt
> [ 114.422974] Disabling IRQ #260
>
> # cat /proc/interrupts
> CPU0 CPU1
> ....
> 260: 100001 0 gpio-mxc 31 Level mma8451
>
> The MMA8451 interrupt triggers as low level, so the GPIO6_IO31 pin
> needs to activate its pull up, otherwise it will stay always at low level
> generating multiple interrupts.
>
> The current device tree does not configure the IOMUX for this pin, so
> it uses whathever comes configured from the bootloader.
>
> The IOMUXC_SW_PAD_CTL_PAD_EIM_BCLK register value comes as 0x8000 from
> the bootloader, which has PKE bit cleared, hence disabling the
> pull-up.
>
> Instead of relying on a previous configuration from the bootloader,
> configure the GPIO6_IO31 pin with pull-up enabled in order to fix
> this problem.
>
> Fixes: a211b8c55f3c ("ARM: dts: imx6qdl-sabreauto: Add sensors")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
> index f3404dd10537..cf628465cd0a 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
> @@ -230,6 +230,8 @@
> accelerometer@1c {
> compatible = "fsl,mma8451";
> reg = <0x1c>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_mma8451_int>;
> interrupt-parent = <&gpio6>;
> interrupts = <31 IRQ_TYPE_LEVEL_LOW>;
> };
> @@ -628,6 +630,12 @@
> >;
> };
>
> + pinctrl_mma8451_int: mma8451intgrp {
> + fsl,pins = <
> + MX6QDL_PAD_EIM_BCLK__GPIO6_IO31 0xb0b1
> + >;
> + };
> +
> pinctrl_pwm3: pwm1grp {
> fsl,pins = <
> MX6QDL_PAD_SD4_DAT1__PWM3_OUT 0x1b0b1
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: imx6qdl-sabreauto: Fix storm of accelerometer interrupts
2019-10-25 6:16 ` Shawn Guo
@ 2019-10-25 16:09 ` Leonard Crestez
2019-10-25 16:13 ` Fabio Estevam
0 siblings, 1 reply; 5+ messages in thread
From: Leonard Crestez @ 2019-10-25 16:09 UTC (permalink / raw)
To: Shawn Guo, Fabio Estevam; +Cc: linux-arm-kernel, dl-linux-imx, kernel
On 25.10.2019 09:16, Shawn Guo wrote:
> @Leonard, comment?
This worked fine for me but after a bit of digging I was able to
reproduce by using upstream uboot:
U-Boot 2019.10-00181-g17fd9915a4c6 (Oct 25 2019 - 17:28:28 +0300)
...
0x020E0158: 00000000
0x020E046C: 0000B0B1
versus:
U-Boot 2019.04-00890-g6a5534d13b9e (Oct 25 2019 - 18:56:40 +0300)
...
0x020E0158: 00000005
0x020E046C: 0000B0B1
But apparently what I reproduced was due to incorrect mux? Fabio: what
is your exact bootloader?
Anyway, as far as I understand explicitly configuring pins is preferable
to relying on bootloader anyway.
Reviewed-By: Leonard Crestez <leonard.crestez@nxp.com>
> Shawn
>
> On Wed, Oct 09, 2019 at 05:43:43PM -0300, Fabio Estevam wrote:
>> Since commit a211b8c55f3c ("ARM: dts: imx6qdl-sabreauto: Add sensors")
>> a storm of accelerometer interrupts is seen:
>>
>> [ 114.211283] irq 260: nobody cared (try booting with the "irqpoll" option)
>> [ 114.218108] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.3.4 #1
>> [ 114.223960] Hardware name: Freescale i.MX6 Quad/DualLite (Device Tree)
>> [ 114.230531] [<c0112858>] (unwind_backtrace) from [<c010cdc8>] (show_stack+0x10/0x14)
>> [ 114.238301] [<c010cdc8>] (show_stack) from [<c0c1aa1c>] (dump_stack+0xd8/0x110)
>> [ 114.245644] [<c0c1aa1c>] (dump_stack) from [<c0193594>] (__report_bad_irq+0x30/0xc0)
>> [ 114.253417] [<c0193594>] (__report_bad_irq) from [<c01933ac>] (note_interrupt+0x108/0x298)
>> [ 114.261707] [<c01933ac>] (note_interrupt) from [<c018ffe4>] (handle_irq_event_percpu+0x70/0x80)
>> [ 114.270433] [<c018ffe4>] (handle_irq_event_percpu) from [<c019002c>] (handle_irq_event+0x38/0x5c)
>> [ 114.279326] [<c019002c>] (handle_irq_event) from [<c019438c>] (handle_level_irq+0xc8/0x154)
>> [ 114.287701] [<c019438c>] (handle_level_irq) from [<c018eda0>] (generic_handle_irq+0x20/0x34)
>> [ 114.296166] [<c018eda0>] (generic_handle_irq) from [<c0534214>] (mxc_gpio_irq_handler+0x30/0xf0)
>> [ 114.304975] [<c0534214>] (mxc_gpio_irq_handler) from [<c0534334>] (mx3_gpio_irq_handler+0x60/0xb0)
>> [ 114.313955] [<c0534334>] (mx3_gpio_irq_handler) from [<c018eda0>] (generic_handle_irq+0x20/0x34)
>> [ 114.322762] [<c018eda0>] (generic_handle_irq) from [<c018f3ac>] (__handle_domain_irq+0x64/0xe0)
>> [ 114.331485] [<c018f3ac>] (__handle_domain_irq) from [<c05215a8>] (gic_handle_irq+0x4c/0xa8)
>> [ 114.339862] [<c05215a8>] (gic_handle_irq) from [<c0101a70>] (__irq_svc+0x70/0x98)
>> [ 114.347361] Exception stack(0xc1301ec0 to 0xc1301f08)
>> [ 114.352435] 1ec0: 00000001 00000006 00000000 c130c340 00000001 c130f688 9785636d c13ea2e8
>> [ 114.360635] 1ee0: 9784907d 0000001a eaf99d78 0000001a 00000000 c1301f10 c0182b00 c0878de4
>> [ 114.368830] 1f00: 20000013 ffffffff
>> [ 114.372349] [<c0101a70>] (__irq_svc) from [<c0878de4>] (cpuidle_enter_state+0x168/0x5f4)
>> [ 114.380464] [<c0878de4>] (cpuidle_enter_state) from [<c08792ac>] (cpuidle_enter+0x28/0x38)
>> [ 114.388751] [<c08792ac>] (cpuidle_enter) from [<c015ef9c>] (do_idle+0x224/0x2a8)
>> [ 114.396168] [<c015ef9c>] (do_idle) from [<c015f3b8>] (cpu_startup_entry+0x18/0x20)
>> [ 114.403765] [<c015f3b8>] (cpu_startup_entry) from [<c1200e54>] (start_kernel+0x43c/0x500)
>> [ 114.411958] handlers:
>> [ 114.414302] [<a01028b8>] irq_default_primary_handler threaded [<fd7a3b08>] mma8452_interrupt
>> [ 114.422974] Disabling IRQ #260
>>
>> # cat /proc/interrupts
>> CPU0 CPU1
>> ....
>> 260: 100001 0 gpio-mxc 31 Level mma8451
>>
>> The MMA8451 interrupt triggers as low level, so the GPIO6_IO31 pin
>> needs to activate its pull up, otherwise it will stay always at low level
>> generating multiple interrupts.
>>
>> The current device tree does not configure the IOMUX for this pin, so
>> it uses whathever comes configured from the bootloader.
>>
>> The IOMUXC_SW_PAD_CTL_PAD_EIM_BCLK register value comes as 0x8000 from
>> the bootloader, which has PKE bit cleared, hence disabling the
>> pull-up.
>>
>> Instead of relying on a previous configuration from the bootloader,
>> configure the GPIO6_IO31 pin with pull-up enabled in order to fix
>> this problem.
>> Fixes: a211b8c55f3c ("ARM: dts: imx6qdl-sabreauto: Add sensors")
>> Signed-off-by: Fabio Estevam <festevam@gmail.com>
>> ---
>> arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
>> index f3404dd10537..cf628465cd0a 100644
>> --- a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
>> @@ -230,6 +230,8 @@
>> accelerometer@1c {
>> compatible = "fsl,mma8451";
>> reg = <0x1c>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_mma8451_int>;
>> interrupt-parent = <&gpio6>;
>> interrupts = <31 IRQ_TYPE_LEVEL_LOW>;
>> };
>> @@ -628,6 +630,12 @@
>> >;
>> };
>>
>> + pinctrl_mma8451_int: mma8451intgrp {
>> + fsl,pins = <
>> + MX6QDL_PAD_EIM_BCLK__GPIO6_IO31 0xb0b1
>> + >;
>> + };
>> +
>> pinctrl_pwm3: pwm1grp {
>> fsl,pins = <
>> MX6QDL_PAD_SD4_DAT1__PWM3_OUT 0x1b0b1
>> --
>> 2.17.1
>>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: imx6qdl-sabreauto: Fix storm of accelerometer interrupts
2019-10-25 16:09 ` Leonard Crestez
@ 2019-10-25 16:13 ` Fabio Estevam
0 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2019-10-25 16:13 UTC (permalink / raw)
To: Leonard Crestez; +Cc: linux-arm-kernel, Shawn Guo, dl-linux-imx, kernel
Hi Leonard,
On Fri, Oct 25, 2019 at 1:09 PM Leonard Crestez <leonard.crestez@nxp.com> wrote:
>
> On 25.10.2019 09:16, Shawn Guo wrote:
> > @Leonard, comment?
>
> This worked fine for me but after a bit of digging I was able to
> reproduce by using upstream uboot:
>
> U-Boot 2019.10-00181-g17fd9915a4c6 (Oct 25 2019 - 17:28:28 +0300)
> ...
> 0x020E0158: 00000000
> 0x020E046C: 0000B0B1
>
> versus:
>
> U-Boot 2019.04-00890-g6a5534d13b9e (Oct 25 2019 - 18:56:40 +0300)
> ...
> 0x020E0158: 00000005
> 0x020E046C: 0000B0B1
>
> But apparently what I reproduced was due to incorrect mux? Fabio: what
> is your exact bootloader?
I used mainline U-Boot 2019.10.
>
> Anyway, as far as I understand explicitly configuring pins is preferable
> to relying on bootloader anyway.
>
> Reviewed-By: Leonard Crestez <leonard.crestez@nxp.com>
Thanks
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: imx6qdl-sabreauto: Fix storm of accelerometer interrupts
2019-10-09 20:43 [PATCH] ARM: dts: imx6qdl-sabreauto: Fix storm of accelerometer interrupts Fabio Estevam
2019-10-25 6:16 ` Shawn Guo
@ 2019-10-26 8:07 ` Shawn Guo
1 sibling, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2019-10-26 8:07 UTC (permalink / raw)
To: Fabio Estevam; +Cc: linux-arm-kernel, leonard.crestez, linux-imx, kernel
On Wed, Oct 09, 2019 at 05:43:43PM -0300, Fabio Estevam wrote:
> Since commit a211b8c55f3c ("ARM: dts: imx6qdl-sabreauto: Add sensors")
> a storm of accelerometer interrupts is seen:
>
> [ 114.211283] irq 260: nobody cared (try booting with the "irqpoll" option)
> [ 114.218108] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.3.4 #1
> [ 114.223960] Hardware name: Freescale i.MX6 Quad/DualLite (Device Tree)
> [ 114.230531] [<c0112858>] (unwind_backtrace) from [<c010cdc8>] (show_stack+0x10/0x14)
> [ 114.238301] [<c010cdc8>] (show_stack) from [<c0c1aa1c>] (dump_stack+0xd8/0x110)
> [ 114.245644] [<c0c1aa1c>] (dump_stack) from [<c0193594>] (__report_bad_irq+0x30/0xc0)
> [ 114.253417] [<c0193594>] (__report_bad_irq) from [<c01933ac>] (note_interrupt+0x108/0x298)
> [ 114.261707] [<c01933ac>] (note_interrupt) from [<c018ffe4>] (handle_irq_event_percpu+0x70/0x80)
> [ 114.270433] [<c018ffe4>] (handle_irq_event_percpu) from [<c019002c>] (handle_irq_event+0x38/0x5c)
> [ 114.279326] [<c019002c>] (handle_irq_event) from [<c019438c>] (handle_level_irq+0xc8/0x154)
> [ 114.287701] [<c019438c>] (handle_level_irq) from [<c018eda0>] (generic_handle_irq+0x20/0x34)
> [ 114.296166] [<c018eda0>] (generic_handle_irq) from [<c0534214>] (mxc_gpio_irq_handler+0x30/0xf0)
> [ 114.304975] [<c0534214>] (mxc_gpio_irq_handler) from [<c0534334>] (mx3_gpio_irq_handler+0x60/0xb0)
> [ 114.313955] [<c0534334>] (mx3_gpio_irq_handler) from [<c018eda0>] (generic_handle_irq+0x20/0x34)
> [ 114.322762] [<c018eda0>] (generic_handle_irq) from [<c018f3ac>] (__handle_domain_irq+0x64/0xe0)
> [ 114.331485] [<c018f3ac>] (__handle_domain_irq) from [<c05215a8>] (gic_handle_irq+0x4c/0xa8)
> [ 114.339862] [<c05215a8>] (gic_handle_irq) from [<c0101a70>] (__irq_svc+0x70/0x98)
> [ 114.347361] Exception stack(0xc1301ec0 to 0xc1301f08)
> [ 114.352435] 1ec0: 00000001 00000006 00000000 c130c340 00000001 c130f688 9785636d c13ea2e8
> [ 114.360635] 1ee0: 9784907d 0000001a eaf99d78 0000001a 00000000 c1301f10 c0182b00 c0878de4
> [ 114.368830] 1f00: 20000013 ffffffff
> [ 114.372349] [<c0101a70>] (__irq_svc) from [<c0878de4>] (cpuidle_enter_state+0x168/0x5f4)
> [ 114.380464] [<c0878de4>] (cpuidle_enter_state) from [<c08792ac>] (cpuidle_enter+0x28/0x38)
> [ 114.388751] [<c08792ac>] (cpuidle_enter) from [<c015ef9c>] (do_idle+0x224/0x2a8)
> [ 114.396168] [<c015ef9c>] (do_idle) from [<c015f3b8>] (cpu_startup_entry+0x18/0x20)
> [ 114.403765] [<c015f3b8>] (cpu_startup_entry) from [<c1200e54>] (start_kernel+0x43c/0x500)
> [ 114.411958] handlers:
> [ 114.414302] [<a01028b8>] irq_default_primary_handler threaded [<fd7a3b08>] mma8452_interrupt
> [ 114.422974] Disabling IRQ #260
>
> # cat /proc/interrupts
> CPU0 CPU1
> ....
> 260: 100001 0 gpio-mxc 31 Level mma8451
>
> The MMA8451 interrupt triggers as low level, so the GPIO6_IO31 pin
> needs to activate its pull up, otherwise it will stay always at low level
> generating multiple interrupts.
>
> The current device tree does not configure the IOMUX for this pin, so
> it uses whathever comes configured from the bootloader.
>
> The IOMUXC_SW_PAD_CTL_PAD_EIM_BCLK register value comes as 0x8000 from
> the bootloader, which has PKE bit cleared, hence disabling the
> pull-up.
>
> Instead of relying on a previous configuration from the bootloader,
> configure the GPIO6_IO31 pin with pull-up enabled in order to fix
> this problem.
>
> Fixes: a211b8c55f3c ("ARM: dts: imx6qdl-sabreauto: Add sensors")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-10-26 8:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-09 20:43 [PATCH] ARM: dts: imx6qdl-sabreauto: Fix storm of accelerometer interrupts Fabio Estevam
2019-10-25 6:16 ` Shawn Guo
2019-10-25 16:09 ` Leonard Crestez
2019-10-25 16:13 ` Fabio Estevam
2019-10-26 8:07 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).