linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] spi: imx: Don't print error on -EPROBEDEFER
@ 2021-01-18 16:31 Guido Günther
  2021-01-18 19:29 ` Fabio Estevam
  2021-01-19 17:12 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Guido Günther @ 2021-01-18 16:31 UTC (permalink / raw)
  To: Mark Brown, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
	Fabio Estevam, NXP Linux Team, Trent Piepho, Oleksij Rempel,
	linux-spi, linux-arm-kernel, linux-kernel

This avoids

[    0.962538] spi_imx 30820000.spi: bitbang start failed with -517

durig driver probe.

Fixes: 8197f489f4c4 ("spi: imx: Fix failure path leak on GPIO request error correctly")
Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
 drivers/spi/spi-imx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
index 73ca821763d6..5dc4ea4b4450 100644
--- a/drivers/spi/spi-imx.c
+++ b/drivers/spi/spi-imx.c
@@ -1685,7 +1685,7 @@ static int spi_imx_probe(struct platform_device *pdev)
 	master->dev.of_node = pdev->dev.of_node;
 	ret = spi_bitbang_start(&spi_imx->bitbang);
 	if (ret) {
-		dev_err(&pdev->dev, "bitbang start failed with %d\n", ret);
+		dev_err_probe(&pdev->dev, ret, "bitbang start failed\n");
 		goto out_bitbang_start;
 	}
 
-- 
2.29.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] spi: imx: Don't print error on -EPROBEDEFER
  2021-01-18 16:31 [PATCH] spi: imx: Don't print error on -EPROBEDEFER Guido Günther
@ 2021-01-18 19:29 ` Fabio Estevam
  2021-01-19 17:12 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2021-01-18 19:29 UTC (permalink / raw)
  To: Guido Günther
  Cc: Sascha Hauer, linux-kernel, Oleksij Rempel, Mark Brown,
	NXP Linux Team, Pengutronix Kernel Team, linux-spi, Shawn Guo,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	Trent Piepho

On Mon, Jan 18, 2021 at 1:31 PM Guido Günther <agx@sigxcpu.org> wrote:
>
> This avoids
>
> [    0.962538] spi_imx 30820000.spi: bitbang start failed with -517
>
> durig driver probe.
>
> Fixes: 8197f489f4c4 ("spi: imx: Fix failure path leak on GPIO request error correctly")
> Signed-off-by: Guido Günther <agx@sigxcpu.org>

Reviewed-by: Fabio Estevam <festevam@gmail.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] spi: imx: Don't print error on -EPROBEDEFER
  2021-01-18 16:31 [PATCH] spi: imx: Don't print error on -EPROBEDEFER Guido Günther
  2021-01-18 19:29 ` Fabio Estevam
@ 2021-01-19 17:12 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2021-01-19 17:12 UTC (permalink / raw)
  To: Guido Günther, linux-spi, Oleksij Rempel,
	Pengutronix Kernel Team, Fabio Estevam, Shawn Guo, linux-kernel,
	linux-arm-kernel, NXP Linux Team, Trent Piepho, Sascha Hauer

On Mon, 18 Jan 2021 17:31:10 +0100, Guido Günther wrote:
> This avoids
> 
> [    0.962538] spi_imx 30820000.spi: bitbang start failed with -517
> 
> durig driver probe.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: imx: Don't print error on -EPROBEDEFER
      commit: 8346633f2c87713a1852d802305e03555e9a9fce

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-01-19 21:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-18 16:31 [PATCH] spi: imx: Don't print error on -EPROBEDEFER Guido Günther
2021-01-18 19:29 ` Fabio Estevam
2021-01-19 17:12 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).