[RFC PATCH] ARM: dts: imx27-phytec-phycard-s-rdk: Fix the I2C1 pinctrl entries

[RFC PATCH] ARM: dts: imx27-phytec-phycard-s-rdk: Fix the I2C1 pinctrl entries

[Fabio Estevam]

The I2C2 pins are already used and the following errors are seen:

imx27-pinctrl 10015000.iomuxc: pin MX27_PAD_I2C2_SDA already requested by 10012000.i2c; cannot claim for 1001d000.i2c
imx27-pinctrl 10015000.iomuxc: pin-69 (1001d000.i2c) status -22
imx27-pinctrl 10015000.iomuxc: could not request pin 69 (MX27_PAD_I2C2_SDA) from group i2c2grp  on device 10015000.iomuxc
imx-i2c 1001d000.i2c: Error applying setting, reverse things back
imx-i2c: probe of 1001d000.i2c failed with error -22

Fix it by adding the correct I2C1 IOMUX entries for the pinctrl_i2c1 group.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Hi,

I don't have access to this board, nor to its schematics to confirm.

Noticed this error at:
https://storage.kernelci.org/next/master/next-20200326/arm/imx_v4_v5_defconfig/gcc-8/lab-pengutronix/boot-imx27-phytec-phycard-s-rdk.html

Please help to confirm.

 arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts b/arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts
index 0cd75dadf292..188639738dc3 100644
--- a/arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts
+++ b/arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts
@@ -75,8 +75,8 @@
 	imx27-phycard-s-rdk {
 		pinctrl_i2c1: i2c1grp {
 			fsl,pins = <
-				MX27_PAD_I2C2_SDA__I2C2_SDA 0x0
-				MX27_PAD_I2C2_SCL__I2C2_SCL 0x0
+				MX27_PAD_I2C_DATA__I2C_DATA 0x0
+				MX27_PAD_I2C_CLK__I2C_CLK 0x0
 			>;
 		};
 
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [RFC PATCH] ARM: dts: imx27-phytec-phycard-s-rdk: Fix the I2C1 pinctrl entries

[Stefan Riedmüller]

Hi Fabio,

-----Fabio Estevam <festevam@gmail.com> schrieb: -----

>An: shawnguo@kernel.org
>Von: Fabio Estevam <festevam@gmail.com>
>Datum: 26.03.2020 14:50
>Kopie: kernel@pengutronix.de, c.hemp@phytec.de,
>s.riedmueller@phytec.de, linux-arm-kernel@lists.infradead.org, Fabio
>Estevam <festevam@gmail.com>
>Betreff: [RFC PATCH] ARM: dts: imx27-phytec-phycard-s-rdk: Fix the
>I2C1 pinctrl entries
>
>The I2C2 pins are already used and the following errors are seen:
>
>imx27-pinctrl 10015000.iomuxc: pin MX27_PAD_I2C2_SDA already
>requested by 10012000.i2c; cannot claim for 1001d000.i2c
>imx27-pinctrl 10015000.iomuxc: pin-69 (1001d000.i2c) status -22
>imx27-pinctrl 10015000.iomuxc: could not request pin 69
>(MX27_PAD_I2C2_SDA) from group i2c2grp  on device 10015000.iomuxc
>imx-i2c 1001d000.i2c: Error applying setting, reverse things back
>imx-i2c: probe of 1001d000.i2c failed with error -22
>
>Fix it by adding the correct I2C1 IOMUX entries for the pinctrl_i2c1
>group.
>
>Signed-off-by: Fabio Estevam <festevam@gmail.com>
>---
>Hi,
>
>I don't have access to this board, nor to its schematics to confirm.
>
>Noticed this error at:
>https://storage.kernelci.org/next/master/next-20200326/arm/imx_v4_v5_
>defconfig/gcc-8/lab-pengutronix/boot-imx27-phytec-phycard-s-rdk.html
>
>Please help to confirm.

I don't have a board here either but I checked the schematics and your fix looks good.

Regards,
Stefan

>
> arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts
>b/arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts
>index 0cd75dadf292..188639738dc3 100644
>--- a/arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts
>+++ b/arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts
>@@ -75,8 +75,8 @@
>  imx27-phycard-s-rdk {
> 		pinctrl_i2c1: i2c1grp {
> 			fsl,pins = <
>-				MX27_PAD_I2C2_SDA__I2C2_SDA 0x0
>-				MX27_PAD_I2C2_SCL__I2C2_SCL 0x0
>+				MX27_PAD_I2C_DATA__I2C_DATA 0x0
>+				MX27_PAD_I2C_CLK__I2C_CLK 0x0
> 			>;
> 		};
> 
>-- 
>2.17.1
>
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [RFC PATCH] ARM: dts: imx27-phytec-phycard-s-rdk: Fix the I2C1 pinctrl entries

[Fabio Estevam]

Hi Stefan,

On Fri, Mar 27, 2020 at 10:27 AM Stefan Riedmüller
<S.Riedmueller@phytec.de> wrote:

> I don't have a board here either but I checked the schematics and your fix looks good.

Thanks for checking.

I have just resent it without the RFC tag, added stable on Cc and the Fixes tag.

Please reply with your Reviewed-by if possible.

Thanks

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel