* [PATCH] ARM: dts: imx6sx-sdb: Add headphone detection for sound card
@ 2020-08-06 11:50 Shengjiu Wang
2020-08-17 13:44 ` Fabio Estevam
0 siblings, 1 reply; 5+ messages in thread
From: Shengjiu Wang @ 2020-08-06 11:50 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer, kernel, festevam, linux-imx,
devicetree, linux-kernel, linux-arm-kernel
Headphone detection is triggered by GPIO, then driver can
switch between speaker and headphone.
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
arch/arm/boot/dts/imx6sx-sdb.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/imx6sx-sdb.dtsi b/arch/arm/boot/dts/imx6sx-sdb.dtsi
index 3e5fb72f21fc..15f486a15f24 100644
--- a/arch/arm/boot/dts/imx6sx-sdb.dtsi
+++ b/arch/arm/boot/dts/imx6sx-sdb.dtsi
@@ -165,6 +165,7 @@ sound {
"IN3R", "AMIC";
mux-int-port = <2>;
mux-ext-port = <6>;
+ hp-det-gpio = <&gpio1 17 GPIO_ACTIVE_LOW>;
};
panel {
@@ -374,6 +375,9 @@ &wdog1 {
&iomuxc {
imx6x-sdb {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_hog>;
+
pinctrl_audmux: audmuxgrp {
fsl,pins = <
MX6SX_PAD_CSI_DATA00__AUDMUX_AUD6_TXC 0x130b0
@@ -450,6 +454,12 @@ MX6SX_PAD_CSI_DATA05__GPIO1_IO_19 0x17059
>;
};
+ pinctrl_hog: hoggrp {
+ fsl,pins = <
+ MX6SX_PAD_CSI_DATA03__GPIO1_IO_17 0x17059
+ >;
+ };
+
pinctrl_i2c1: i2c1grp {
fsl,pins = <
MX6SX_PAD_GPIO1_IO01__I2C1_SDA 0x4001b8b1
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: imx6sx-sdb: Add headphone detection for sound card
2020-08-06 11:50 [PATCH] ARM: dts: imx6sx-sdb: Add headphone detection for sound card Shengjiu Wang
@ 2020-08-17 13:44 ` Fabio Estevam
0 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2020-08-17 13:44 UTC (permalink / raw)
To: Shengjiu Wang
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Sascha Hauer, linux-kernel, Rob Herring, NXP Linux Team,
Sascha Hauer, Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
Hi Shengjiu,
On Thu, Aug 6, 2020 at 8:55 AM Shengjiu Wang <shengjiu.wang@nxp.com> wrote:
> &iomuxc {
> imx6x-sdb {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_hog>;
Instead of adding a hog group, please add the headphone detect GPIO
under the audmux group like you did in the imx6sl-evk patch.
Thanks
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: imx6sx-sdb: Add headphone detection for sound card
2020-08-23 14:12 ` Fabio Estevam
@ 2020-08-23 23:57 ` Shawn Guo
0 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2020-08-23 23:57 UTC (permalink / raw)
To: Fabio Estevam
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
S.j. Wang, linux-kernel, Rob Herring, dl-linux-imx, Sascha Hauer,
Sascha Hauer,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Sun, Aug 23, 2020 at 11:12:08AM -0300, Fabio Estevam wrote:
> Hi Wang Shengjiu and Shawn,
>
> On Sun, Aug 23, 2020 at 9:31 AM S.j. Wang <shengjiu.wang@nxp.com> wrote:
>
> > I would like to know your opinion, should I move headphone detect GPIO
> > To audmux group?
>
> What about adding a dedicated pinctrl_hp for the headphone detect pin
> like it is done at:
> https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/tree/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi?h=for-next&id=8f0216b006e5f553d28c4c1a991b5234693a49cb#n130
>
> My point is that we should avoid adding a hog group when possible.
I agree. Hog group should be used as the last sort, when there is no
clear client device owning the pins.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: imx6sx-sdb: Add headphone detection for sound card
[not found] <VI1PR0402MB33427CE688DB9D28DDFC000EE3590@VI1PR0402MB3342.eurprd04.prod.outlook.com>
@ 2020-08-23 14:12 ` Fabio Estevam
2020-08-23 23:57 ` Shawn Guo
0 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2020-08-23 14:12 UTC (permalink / raw)
To: S.j. Wang
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Sascha Hauer, linux-kernel, Rob Herring, dl-linux-imx,
Sascha Hauer, Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
Hi Wang Shengjiu and Shawn,
On Sun, Aug 23, 2020 at 9:31 AM S.j. Wang <shengjiu.wang@nxp.com> wrote:
> I would like to know your opinion, should I move headphone detect GPIO
> To audmux group?
What about adding a dedicated pinctrl_hp for the headphone detect pin
like it is done at:
https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/tree/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi?h=for-next&id=8f0216b006e5f553d28c4c1a991b5234693a49cb#n130
My point is that we should avoid adding a hog group when possible.
Thanks
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: imx6sx-sdb: Add headphone detection for sound card
[not found] <VI1PR0402MB334219C2EDDB25D1493DEC7EE35F0@VI1PR0402MB3342.eurprd04.prod.outlook.com>
@ 2020-08-18 0:38 ` Fabio Estevam
0 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2020-08-18 0:38 UTC (permalink / raw)
To: S.j. Wang
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Sascha Hauer, linux-kernel, Rob Herring, dl-linux-imx,
Sascha Hauer, Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Mon, Aug 17, 2020 at 10:57 AM S.j. Wang <shengjiu.wang@nxp.com> wrote:
> I didn't put headphone detect GPIO in audmux group in imx6sl-evk patch,
> Still in hog group.
Ok, sorry. You grouped it with MX6SL_PAD_AUD_MCLK__AUDIO_CLK_OUT,
which I also think should not be part of the hog group.
> And I think headphone detect GPIO is not belong to audmux group, it should
> Be in hog group.
The hog group is better suited when there is no driver that can be
associated with that particular pin.
For the headphone GPIO detect, I think it makes sense to group it with
the other audio-related pinctrl pins.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-08-23 23:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-06 11:50 [PATCH] ARM: dts: imx6sx-sdb: Add headphone detection for sound card Shengjiu Wang
2020-08-17 13:44 ` Fabio Estevam
[not found] <VI1PR0402MB334219C2EDDB25D1493DEC7EE35F0@VI1PR0402MB3342.eurprd04.prod.outlook.com>
2020-08-18 0:38 ` Fabio Estevam
[not found] <VI1PR0402MB33427CE688DB9D28DDFC000EE3590@VI1PR0402MB3342.eurprd04.prod.outlook.com>
2020-08-23 14:12 ` Fabio Estevam
2020-08-23 23:57 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).