* [PATCH v2] arm64: dts: imx8mp: correct usb clocks
@ 2022-09-13 11:10 Li Jun
2022-09-13 11:54 ` Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Li Jun @ 2022-09-13 11:10 UTC (permalink / raw)
To: shawnguo, robh+dt, krzysztof.kozlowski+dt, s.hauer, kernel, festevam
Cc: linux-imx, laurent.pinchart, l.stach, marex, peng.fan,
paul.elder, jun.li, Markus.Niebel, aford173, devicetree,
linux-arm-kernel
After commit cf7f3f4fa9e5 ("clk: imx8mp: fix usb_root_clk parent"),
usb_root_clk is no longer for suspend clock so update dts accordingly
to use right bus clock and suspend clock.
Cc: stable@vger.kernel.org # v5.19+
Signed-off-by: Li Jun <jun.li@nxp.com>
---
change for v2:
- Add stable tag to apply v5.19+
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index fe178b7d063c..2f18778a057f 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -1169,7 +1169,7 @@ usb3_0: usb@32f10100 {
reg = <0x32f10100 0x8>,
<0x381f0000 0x20>;
clocks = <&clk IMX8MP_CLK_HSIO_ROOT>,
- <&clk IMX8MP_CLK_USB_ROOT>;
+ <&clk IMX8MP_CLK_USB_SUSP>;
clock-names = "hsio", "suspend";
interrupts = <GIC_SPI 148 IRQ_TYPE_LEVEL_HIGH>;
power-domains = <&hsio_blk_ctrl IMX8MP_HSIOBLK_PD_USB>;
@@ -1182,9 +1182,9 @@ usb3_0: usb@32f10100 {
usb_dwc3_0: usb@38100000 {
compatible = "snps,dwc3";
reg = <0x38100000 0x10000>;
- clocks = <&clk IMX8MP_CLK_HSIO_AXI>,
+ clocks = <&clk IMX8MP_CLK_USB_ROOT>,
<&clk IMX8MP_CLK_USB_CORE_REF>,
- <&clk IMX8MP_CLK_USB_ROOT>;
+ <&clk IMX8MP_CLK_USB_SUSP>;
clock-names = "bus_early", "ref", "suspend";
interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
phys = <&usb3_phy0>, <&usb3_phy0>;
@@ -1211,7 +1211,7 @@ usb3_1: usb@32f10108 {
reg = <0x32f10108 0x8>,
<0x382f0000 0x20>;
clocks = <&clk IMX8MP_CLK_HSIO_ROOT>,
- <&clk IMX8MP_CLK_USB_ROOT>;
+ <&clk IMX8MP_CLK_USB_SUSP>;
clock-names = "hsio", "suspend";
interrupts = <GIC_SPI 149 IRQ_TYPE_LEVEL_HIGH>;
power-domains = <&hsio_blk_ctrl IMX8MP_HSIOBLK_PD_USB>;
@@ -1224,9 +1224,9 @@ usb3_1: usb@32f10108 {
usb_dwc3_1: usb@38200000 {
compatible = "snps,dwc3";
reg = <0x38200000 0x10000>;
- clocks = <&clk IMX8MP_CLK_HSIO_AXI>,
+ clocks = <&clk IMX8MP_CLK_USB_ROOT>,
<&clk IMX8MP_CLK_USB_CORE_REF>,
- <&clk IMX8MP_CLK_USB_ROOT>;
+ <&clk IMX8MP_CLK_USB_SUSP>;
clock-names = "bus_early", "ref", "suspend";
interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
phys = <&usb3_phy1>, <&usb3_phy1>;
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arm64: dts: imx8mp: correct usb clocks
2022-09-13 11:10 [PATCH v2] arm64: dts: imx8mp: correct usb clocks Li Jun
@ 2022-09-13 11:54 ` Fabio Estevam
2022-09-13 12:24 ` Alexander Stein
2022-09-13 12:25 ` Peng Fan
2 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2022-09-13 11:54 UTC (permalink / raw)
To: Li Jun
Cc: shawnguo, robh+dt, krzysztof.kozlowski+dt, s.hauer, kernel,
linux-imx, laurent.pinchart, l.stach, marex, peng.fan,
paul.elder, Markus.Niebel, aford173, devicetree,
linux-arm-kernel
On Tue, Sep 13, 2022 at 8:28 AM Li Jun <jun.li@nxp.com> wrote:
>
> After commit cf7f3f4fa9e5 ("clk: imx8mp: fix usb_root_clk parent"),
> usb_root_clk is no longer for suspend clock so update dts accordingly
> to use right bus clock and suspend clock.
>
> Cc: stable@vger.kernel.org # v5.19+
> Signed-off-by: Li Jun <jun.li@nxp.com>
Please also add the Fixes tag.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arm64: dts: imx8mp: correct usb clocks
2022-09-13 11:10 [PATCH v2] arm64: dts: imx8mp: correct usb clocks Li Jun
2022-09-13 11:54 ` Fabio Estevam
@ 2022-09-13 12:24 ` Alexander Stein
2022-09-13 12:25 ` Peng Fan
2 siblings, 0 replies; 4+ messages in thread
From: Alexander Stein @ 2022-09-13 12:24 UTC (permalink / raw)
To: jun.li
Cc: shawnguo, robh+dt, krzysztof.kozlowski+dt, s.hauer, kernel,
festevam, linux-arm-kernel, linux-imx, laurent.pinchart, l.stach,
marex, peng.fan, paul.elder, Markus.Niebel, aford173, devicetree,
linux-arm-kernel, Li Jun
Hello,
Am Dienstag, 13. September 2022, 13:10:26 CEST schrieb Li Jun:
> After commit cf7f3f4fa9e5 ("clk: imx8mp: fix usb_root_clk parent"),
> usb_root_clk is no longer for suspend clock so update dts accordingly
> to use right bus clock and suspend clock.
>
> Cc: stable@vger.kernel.org # v5.19+
> Signed-off-by: Li Jun <jun.li@nxp.com>
> ---
> change for v2:
> - Add stable tag to apply v5.19+
>
> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index
> fe178b7d063c..2f18778a057f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -1169,7 +1169,7 @@ usb3_0: usb@32f10100 {
> reg = <0x32f10100 0x8>,
> <0x381f0000 0x20>;
> clocks = <&clk IMX8MP_CLK_HSIO_ROOT>,
> - <&clk IMX8MP_CLK_USB_ROOT>;
> + <&clk IMX8MP_CLK_USB_SUSP>;
> clock-names = "hsio", "suspend";
> interrupts = <GIC_SPI 148
IRQ_TYPE_LEVEL_HIGH>;
> power-domains = <&hsio_blk_ctrl
IMX8MP_HSIOBLK_PD_USB>;
> @@ -1182,9 +1182,9 @@ usb3_0: usb@32f10100 {
> usb_dwc3_0: usb@38100000 {
> compatible = "snps,dwc3";
> reg = <0x38100000 0x10000>;
> - clocks = <&clk
IMX8MP_CLK_HSIO_AXI>,
> + clocks = <&clk
IMX8MP_CLK_USB_ROOT>,
> <&clk
IMX8MP_CLK_USB_CORE_REF>,
> - <&clk
IMX8MP_CLK_USB_ROOT>;
> + <&clk
IMX8MP_CLK_USB_SUSP>;
> clock-names = "bus_early", "ref",
"suspend";
> interrupts = <GIC_SPI 40
IRQ_TYPE_LEVEL_HIGH>;
> phys = <&usb3_phy0>, <&usb3_phy0>;
> @@ -1211,7 +1211,7 @@ usb3_1: usb@32f10108 {
> reg = <0x32f10108 0x8>,
> <0x382f0000 0x20>;
> clocks = <&clk IMX8MP_CLK_HSIO_ROOT>,
> - <&clk IMX8MP_CLK_USB_ROOT>;
> + <&clk IMX8MP_CLK_USB_SUSP>;
> clock-names = "hsio", "suspend";
> interrupts = <GIC_SPI 149
IRQ_TYPE_LEVEL_HIGH>;
> power-domains = <&hsio_blk_ctrl
IMX8MP_HSIOBLK_PD_USB>;
> @@ -1224,9 +1224,9 @@ usb3_1: usb@32f10108 {
> usb_dwc3_1: usb@38200000 {
> compatible = "snps,dwc3";
> reg = <0x38200000 0x10000>;
> - clocks = <&clk
IMX8MP_CLK_HSIO_AXI>,
> + clocks = <&clk
IMX8MP_CLK_USB_ROOT>,
> <&clk
IMX8MP_CLK_USB_CORE_REF>,
> - <&clk
IMX8MP_CLK_USB_ROOT>;
> + <&clk
IMX8MP_CLK_USB_SUSP>;
> clock-names = "bus_early", "ref",
"suspend";
> interrupts = <GIC_SPI 41
IRQ_TYPE_LEVEL_HIGH>;
> phys = <&usb3_phy1>, <&usb3_phy1>;
Together with the series [1] & [2] this fixes devices detection when the
onboard hub is in runtime suspend.
Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com>
[1] https://lore.kernel.org/all/1662547028-22279-1-git-send-email-jun.li@nxp.com/
[2] https://lore.kernel.org/all/20220907144624.2810117-1-alexander.stein@ew.tq-group.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v2] arm64: dts: imx8mp: correct usb clocks
2022-09-13 11:10 [PATCH v2] arm64: dts: imx8mp: correct usb clocks Li Jun
2022-09-13 11:54 ` Fabio Estevam
2022-09-13 12:24 ` Alexander Stein
@ 2022-09-13 12:25 ` Peng Fan
2 siblings, 0 replies; 4+ messages in thread
From: Peng Fan @ 2022-09-13 12:25 UTC (permalink / raw)
To: Jun Li, shawnguo, robh+dt, krzysztof.kozlowski+dt, s.hauer,
kernel, festevam
Cc: dl-linux-imx, laurent.pinchart, l.stach, marex, paul.elder,
Markus.Niebel, aford173, devicetree, linux-arm-kernel
> Subject: [PATCH v2] arm64: dts: imx8mp: correct usb clocks
>
> After commit cf7f3f4fa9e5 ("clk: imx8mp: fix usb_root_clk parent"),
> usb_root_clk is no longer for suspend clock so update dts accordingly to use
> right bus clock and suspend clock.
>
> Cc: stable@vger.kernel.org # v5.19+
> Signed-off-by: Li Jun <jun.li@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
> ---
> change for v2:
> - Add stable tag to apply v5.19+
>
> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index fe178b7d063c..2f18778a057f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -1169,7 +1169,7 @@ usb3_0: usb@32f10100 {
> reg = <0x32f10100 0x8>,
> <0x381f0000 0x20>;
> clocks = <&clk IMX8MP_CLK_HSIO_ROOT>,
> - <&clk IMX8MP_CLK_USB_ROOT>;
> + <&clk IMX8MP_CLK_USB_SUSP>;
> clock-names = "hsio", "suspend";
> interrupts = <GIC_SPI 148 IRQ_TYPE_LEVEL_HIGH>;
> power-domains = <&hsio_blk_ctrl
> IMX8MP_HSIOBLK_PD_USB>; @@ -1182,9 +1182,9 @@ usb3_0:
> usb@32f10100 {
> usb_dwc3_0: usb@38100000 {
> compatible = "snps,dwc3";
> reg = <0x38100000 0x10000>;
> - clocks = <&clk IMX8MP_CLK_HSIO_AXI>,
> + clocks = <&clk IMX8MP_CLK_USB_ROOT>,
> <&clk
> IMX8MP_CLK_USB_CORE_REF>,
> - <&clk IMX8MP_CLK_USB_ROOT>;
> + <&clk IMX8MP_CLK_USB_SUSP>;
> clock-names = "bus_early", "ref", "suspend";
> interrupts = <GIC_SPI 40
> IRQ_TYPE_LEVEL_HIGH>;
> phys = <&usb3_phy0>, <&usb3_phy0>;
> @@ -1211,7 +1211,7 @@ usb3_1: usb@32f10108 {
> reg = <0x32f10108 0x8>,
> <0x382f0000 0x20>;
> clocks = <&clk IMX8MP_CLK_HSIO_ROOT>,
> - <&clk IMX8MP_CLK_USB_ROOT>;
> + <&clk IMX8MP_CLK_USB_SUSP>;
> clock-names = "hsio", "suspend";
> interrupts = <GIC_SPI 149 IRQ_TYPE_LEVEL_HIGH>;
> power-domains = <&hsio_blk_ctrl
> IMX8MP_HSIOBLK_PD_USB>; @@ -1224,9 +1224,9 @@ usb3_1:
> usb@32f10108 {
> usb_dwc3_1: usb@38200000 {
> compatible = "snps,dwc3";
> reg = <0x38200000 0x10000>;
> - clocks = <&clk IMX8MP_CLK_HSIO_AXI>,
> + clocks = <&clk IMX8MP_CLK_USB_ROOT>,
> <&clk
> IMX8MP_CLK_USB_CORE_REF>,
> - <&clk IMX8MP_CLK_USB_ROOT>;
> + <&clk IMX8MP_CLK_USB_SUSP>;
> clock-names = "bus_early", "ref", "suspend";
> interrupts = <GIC_SPI 41
> IRQ_TYPE_LEVEL_HIGH>;
> phys = <&usb3_phy1>, <&usb3_phy1>;
> --
> 2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-13 12:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-13 11:10 [PATCH v2] arm64: dts: imx8mp: correct usb clocks Li Jun
2022-09-13 11:54 ` Fabio Estevam
2022-09-13 12:24 ` Alexander Stein
2022-09-13 12:25 ` Peng Fan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).