* [PATCH] ARM: dts: imx6qdl-gw52xx: Remove unnecessary #address-cells/#size-cells
@ 2020-11-24 11:57 Fabio Estevam
2020-11-30 18:41 ` Tim Harvey
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2020-11-24 11:57 UTC (permalink / raw)
To: shawnguo; +Cc: tharvey, Fabio Estevam, linux-arm-kernel
The following W=1 build warning is observed:
arch/arm/boot/dts/imx6qdl-gw52xx.dtsi:33.12-78.4: Warning (avoid_unnecessary_addr_size): /gpio-keys: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
Remove the unnecessary #address-cells/#size-cells to avoid such a warning.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
arch/arm/boot/dts/imx6qdl-gw52xx.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
index 736074f1c3ef..1fb9e972b390 100644
--- a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
@@ -32,8 +32,6 @@
gpio-keys {
compatible = "gpio-keys";
- #address-cells = <1>;
- #size-cells = <0>;
user-pb {
label = "user_pb";
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: imx6qdl-gw52xx: Remove unnecessary #address-cells/#size-cells
2020-11-24 11:57 [PATCH] ARM: dts: imx6qdl-gw52xx: Remove unnecessary #address-cells/#size-cells Fabio Estevam
@ 2020-11-30 18:41 ` Tim Harvey
2020-11-30 18:51 ` Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Tim Harvey @ 2020-11-30 18:41 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Shawn Guo, Linux ARM Mailing List
On Tue, Nov 24, 2020 at 3:57 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> The following W=1 build warning is observed:
>
> arch/arm/boot/dts/imx6qdl-gw52xx.dtsi:33.12-78.4: Warning (avoid_unnecessary_addr_size): /gpio-keys: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>
> Remove the unnecessary #address-cells/#size-cells to avoid such a warning.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> arch/arm/boot/dts/imx6qdl-gw52xx.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
> index 736074f1c3ef..1fb9e972b390 100644
> --- a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
> @@ -32,8 +32,6 @@
>
> gpio-keys {
> compatible = "gpio-keys";
> - #address-cells = <1>;
> - #size-cells = <0>;
>
> user-pb {
> label = "user_pb";
> --
> 2.17.1
>
Fabio,
Thanks for noticing this. I have the same issue in most of the other
imx6qdl-gw*.dtsi files. I can address all at once and drop this patch
if that makes sense?
Best Regards,
Tim
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: imx6qdl-gw52xx: Remove unnecessary #address-cells/#size-cells
2020-11-30 18:41 ` Tim Harvey
@ 2020-11-30 18:51 ` Fabio Estevam
0 siblings, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2020-11-30 18:51 UTC (permalink / raw)
To: Tim Harvey; +Cc: Shawn Guo, Linux ARM Mailing List
Hi Tim,
On Mon, Nov 30, 2020 at 3:41 PM Tim Harvey <tharvey@gateworks.com> wrote:
> Thanks for noticing this. I have the same issue in most of the other
> imx6qdl-gw*.dtsi files. I can address all at once and drop this patch
> if that makes sense?
Sure, that's fine.
Cheers
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-30 18:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-24 11:57 [PATCH] ARM: dts: imx6qdl-gw52xx: Remove unnecessary #address-cells/#size-cells Fabio Estevam
2020-11-30 18:41 ` Tim Harvey
2020-11-30 18:51 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).