* [PATCH] ARM: dts: imx7d-pico: Add LCD support
@ 2019-10-25 8:22 Joris Offouga
2019-10-25 13:42 ` Fabio Estevam
2019-10-25 18:45 ` Marco Felsch
0 siblings, 2 replies; 6+ messages in thread
From: Joris Offouga @ 2019-10-25 8:22 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Otavio Salvador, Shawn Guo, Sascha Hauer, open list,
Joris Offouga, Rob Herring, NXP Linux Team,
Pengutronix Kernel Team, Fabio Estevam
Add support for the VXT VL050-8048NT-C01 panel connected through
the 24 bit parallel LCDIF interface.
Signed-off-by: Joris Offouga <offougajoris@gmail.com>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
arch/arm/boot/dts/imx7d-pico.dtsi | 84 +++++++++++++++++++++++++++++++
1 file changed, 84 insertions(+)
diff --git a/arch/arm/boot/dts/imx7d-pico.dtsi b/arch/arm/boot/dts/imx7d-pico.dtsi
index 6f50ebf31a0a..9042b1e6f1db 100644
--- a/arch/arm/boot/dts/imx7d-pico.dtsi
+++ b/arch/arm/boot/dts/imx7d-pico.dtsi
@@ -69,6 +69,37 @@
clocks = <&clks IMX7D_CLKO2_ROOT_DIV>;
clock-names = "ext_clock";
};
+
+ backlight: backlight {
+ compatible = "pwm-backlight";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_backlight>;
+ pwms = <&pwm4 0 50000 0>;
+ brightness-levels = <0 36 72 108 144 180 216 255>;
+ default-brightness-level = <6>;
+ status = "okay";
+ };
+
+ reg_lcd_3v3: regulator-lcd-3v3 {
+ compatible = "regulator-fixed";
+ regulator-name = "lcd-3v3";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ gpio = <&gpio1 6 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+
+ panel {
+ compatible = "vxt,vl050-8048nt-c01";
+ backlight = <&backlight>;
+ power-supply = <®_lcd_3v3>;
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&display_out>;
+ };
+ };
+ };
};
&clks {
@@ -230,6 +261,18 @@
};
};
+&lcdif {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_lcdif>;
+ status = "okay";
+
+ port {
+ display_out: endpoint {
+ remote-endpoint = <&panel_in>;
+ };
+ };
+};
+
&sai1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_sai1>;
@@ -349,6 +392,13 @@
};
&iomuxc {
+
+ pinctrl_backlight: backlight {
+ fsl,pins = <
+ MX7D_PAD_GPIO1_IO11__PWM4_OUT 0x0
+ >;
+ };
+
pinctrl_ecspi3: ecspi3grp {
fsl,pins = <
MX7D_PAD_I2C1_SCL__ECSPI3_MISO 0x2
@@ -413,6 +463,40 @@
>;
};
+ pinctrl_lcdif: lcdifgrp {
+ fsl,pins = <
+ MX7D_PAD_LCD_DATA00__LCD_DATA0 0x79
+ MX7D_PAD_LCD_DATA01__LCD_DATA1 0x79
+ MX7D_PAD_LCD_DATA02__LCD_DATA2 0x79
+ MX7D_PAD_LCD_DATA03__LCD_DATA3 0x79
+ MX7D_PAD_LCD_DATA04__LCD_DATA4 0x79
+ MX7D_PAD_LCD_DATA05__LCD_DATA5 0x79
+ MX7D_PAD_LCD_DATA06__LCD_DATA6 0x79
+ MX7D_PAD_LCD_DATA07__LCD_DATA7 0x79
+ MX7D_PAD_LCD_DATA08__LCD_DATA8 0x79
+ MX7D_PAD_LCD_DATA09__LCD_DATA9 0x79
+ MX7D_PAD_LCD_DATA10__LCD_DATA10 0x79
+ MX7D_PAD_LCD_DATA11__LCD_DATA11 0x79
+ MX7D_PAD_LCD_DATA12__LCD_DATA12 0x79
+ MX7D_PAD_LCD_DATA13__LCD_DATA13 0x79
+ MX7D_PAD_LCD_DATA14__LCD_DATA14 0x79
+ MX7D_PAD_LCD_DATA15__LCD_DATA15 0x79
+ MX7D_PAD_LCD_DATA16__LCD_DATA16 0x79
+ MX7D_PAD_LCD_DATA17__LCD_DATA17 0x79
+ MX7D_PAD_LCD_DATA18__LCD_DATA18 0x79
+ MX7D_PAD_LCD_DATA19__LCD_DATA19 0x79
+ MX7D_PAD_LCD_DATA20__LCD_DATA20 0x79
+ MX7D_PAD_LCD_DATA21__LCD_DATA21 0x79
+ MX7D_PAD_LCD_DATA22__LCD_DATA22 0x79
+ MX7D_PAD_LCD_DATA23__LCD_DATA23 0x79
+ MX7D_PAD_LCD_CLK__LCD_CLK 0x79
+ MX7D_PAD_LCD_ENABLE__LCD_ENABLE 0x78
+ MX7D_PAD_LCD_VSYNC__LCD_VSYNC 0x78
+ MX7D_PAD_LCD_HSYNC__LCD_HSYNC 0x78
+ MX7D_PAD_LCD_RESET__GPIO3_IO4 0x14
+ >;
+ };
+
pinctrl_pwm1: pwm1 {
fsl,pins = <
MX7D_PAD_GPIO1_IO08__PWM1_OUT 0x7f
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: imx7d-pico: Add LCD support
2019-10-25 8:22 [PATCH] ARM: dts: imx7d-pico: Add LCD support Joris Offouga
@ 2019-10-25 13:42 ` Fabio Estevam
2019-10-25 18:45 ` Marco Felsch
1 sibling, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2019-10-25 13:42 UTC (permalink / raw)
To: Joris Offouga
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Otavio Salvador, Sascha Hauer, open list, Rob Herring,
NXP Linux Team, Pengutronix Kernel Team, Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
Hi Joris,
On Fri, Oct 25, 2019 at 5:22 AM Joris Offouga <offougajoris@gmail.com> wrote:
>
> Add support for the VXT VL050-8048NT-C01 panel connected through
> the 24 bit parallel LCDIF interface.
>
> Signed-off-by: Joris Offouga <offougajoris@gmail.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
When you send someone else's patch you need to keep the original From line.
In this case it needs to be:
From: Fabio Estevam <festevam@gmail.com>
Your Signed-off-by should come as the last one, since you are one
final person submitting upstream.
Please send a v2 with these fixes.
Thanks
> ---
> arch/arm/boot/dts/imx7d-pico.dtsi | 84 +++++++++++++++++++++++++++++++
> 1 file changed, 84 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx7d-pico.dtsi b/arch/arm/boot/dts/imx7d-pico.dtsi
> index 6f50ebf31a0a..9042b1e6f1db 100644
> --- a/arch/arm/boot/dts/imx7d-pico.dtsi
> +++ b/arch/arm/boot/dts/imx7d-pico.dtsi
> @@ -69,6 +69,37 @@
> clocks = <&clks IMX7D_CLKO2_ROOT_DIV>;
> clock-names = "ext_clock";
> };
> +
> + backlight: backlight {
> + compatible = "pwm-backlight";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_backlight>;
> + pwms = <&pwm4 0 50000 0>;
> + brightness-levels = <0 36 72 108 144 180 216 255>;
> + default-brightness-level = <6>;
> + status = "okay";
> + };
> +
> + reg_lcd_3v3: regulator-lcd-3v3 {
> + compatible = "regulator-fixed";
> + regulator-name = "lcd-3v3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpio = <&gpio1 6 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> + panel {
> + compatible = "vxt,vl050-8048nt-c01";
> + backlight = <&backlight>;
> + power-supply = <®_lcd_3v3>;
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&display_out>;
> + };
> + };
> + };
> };
>
> &clks {
> @@ -230,6 +261,18 @@
> };
> };
>
> +&lcdif {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_lcdif>;
> + status = "okay";
> +
> + port {
> + display_out: endpoint {
> + remote-endpoint = <&panel_in>;
> + };
> + };
> +};
> +
> &sai1 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_sai1>;
> @@ -349,6 +392,13 @@
> };
>
> &iomuxc {
> +
> + pinctrl_backlight: backlight {
> + fsl,pins = <
> + MX7D_PAD_GPIO1_IO11__PWM4_OUT 0x0
> + >;
> + };
> +
> pinctrl_ecspi3: ecspi3grp {
> fsl,pins = <
> MX7D_PAD_I2C1_SCL__ECSPI3_MISO 0x2
> @@ -413,6 +463,40 @@
> >;
> };
>
> + pinctrl_lcdif: lcdifgrp {
> + fsl,pins = <
> + MX7D_PAD_LCD_DATA00__LCD_DATA0 0x79
> + MX7D_PAD_LCD_DATA01__LCD_DATA1 0x79
> + MX7D_PAD_LCD_DATA02__LCD_DATA2 0x79
> + MX7D_PAD_LCD_DATA03__LCD_DATA3 0x79
> + MX7D_PAD_LCD_DATA04__LCD_DATA4 0x79
> + MX7D_PAD_LCD_DATA05__LCD_DATA5 0x79
> + MX7D_PAD_LCD_DATA06__LCD_DATA6 0x79
> + MX7D_PAD_LCD_DATA07__LCD_DATA7 0x79
> + MX7D_PAD_LCD_DATA08__LCD_DATA8 0x79
> + MX7D_PAD_LCD_DATA09__LCD_DATA9 0x79
> + MX7D_PAD_LCD_DATA10__LCD_DATA10 0x79
> + MX7D_PAD_LCD_DATA11__LCD_DATA11 0x79
> + MX7D_PAD_LCD_DATA12__LCD_DATA12 0x79
> + MX7D_PAD_LCD_DATA13__LCD_DATA13 0x79
> + MX7D_PAD_LCD_DATA14__LCD_DATA14 0x79
> + MX7D_PAD_LCD_DATA15__LCD_DATA15 0x79
> + MX7D_PAD_LCD_DATA16__LCD_DATA16 0x79
> + MX7D_PAD_LCD_DATA17__LCD_DATA17 0x79
> + MX7D_PAD_LCD_DATA18__LCD_DATA18 0x79
> + MX7D_PAD_LCD_DATA19__LCD_DATA19 0x79
> + MX7D_PAD_LCD_DATA20__LCD_DATA20 0x79
> + MX7D_PAD_LCD_DATA21__LCD_DATA21 0x79
> + MX7D_PAD_LCD_DATA22__LCD_DATA22 0x79
> + MX7D_PAD_LCD_DATA23__LCD_DATA23 0x79
> + MX7D_PAD_LCD_CLK__LCD_CLK 0x79
> + MX7D_PAD_LCD_ENABLE__LCD_ENABLE 0x78
> + MX7D_PAD_LCD_VSYNC__LCD_VSYNC 0x78
> + MX7D_PAD_LCD_HSYNC__LCD_HSYNC 0x78
> + MX7D_PAD_LCD_RESET__GPIO3_IO4 0x14
> + >;
> + };
> +
> pinctrl_pwm1: pwm1 {
> fsl,pins = <
> MX7D_PAD_GPIO1_IO08__PWM1_OUT 0x7f
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: imx7d-pico: Add LCD support
2019-10-25 8:22 [PATCH] ARM: dts: imx7d-pico: Add LCD support Joris Offouga
2019-10-25 13:42 ` Fabio Estevam
@ 2019-10-25 18:45 ` Marco Felsch
2019-10-25 21:16 ` Joris Offouga
1 sibling, 1 reply; 6+ messages in thread
From: Marco Felsch @ 2019-10-25 18:45 UTC (permalink / raw)
To: Joris Offouga
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Otavio Salvador, Fabio Estevam, Sascha Hauer, open list,
Rob Herring, NXP Linux Team, Pengutronix Kernel Team, Shawn Guo,
linux-arm-kernel
Hi Joris,
On 19-10-25 10:22, Joris Offouga wrote:
> Add support for the VXT VL050-8048NT-C01 panel connected through
> the 24 bit parallel LCDIF interface.
>
> Signed-off-by: Joris Offouga <offougajoris@gmail.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> arch/arm/boot/dts/imx7d-pico.dtsi | 84 +++++++++++++++++++++++++++++++
> 1 file changed, 84 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx7d-pico.dtsi b/arch/arm/boot/dts/imx7d-pico.dtsi
> index 6f50ebf31a0a..9042b1e6f1db 100644
> --- a/arch/arm/boot/dts/imx7d-pico.dtsi
> +++ b/arch/arm/boot/dts/imx7d-pico.dtsi
> @@ -69,6 +69,37 @@
> clocks = <&clks IMX7D_CLKO2_ROOT_DIV>;
> clock-names = "ext_clock";
> };
> +
> + backlight: backlight {
> + compatible = "pwm-backlight";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_backlight>;
> + pwms = <&pwm4 0 50000 0>;
^
If not inverted please drop the this flag.
Also you need to add
&pwm4 {
status = "okay";
};
And so you can do the pwm pinctrl within that node, see below.
> + brightness-levels = <0 36 72 108 144 180 216 255>;
> + default-brightness-level = <6>;
> + status = "okay";
status can be dropped too.
> + };
> +
> + reg_lcd_3v3: regulator-lcd-3v3 {
> + compatible = "regulator-fixed";
> + regulator-name = "lcd-3v3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpio = <&gpio1 6 GPIO_ACTIVE_HIGH>;
Missing the muxing?
> + enable-active-high;
> + };
> +
> + panel {
> + compatible = "vxt,vl050-8048nt-c01";
> + backlight = <&backlight>;
> + power-supply = <®_lcd_3v3>;
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&display_out>;
> + };
> + };
> + };
Please sort the nodes alphabetical.
> };
>
> &clks {
> @@ -230,6 +261,18 @@
> };
> };
>
> +&lcdif {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_lcdif>;
> + status = "okay";
> +
> + port {
> + display_out: endpoint {
> + remote-endpoint = <&panel_in>;
> + };
> + };
> +};
> +
> &sai1 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_sai1>;
> @@ -349,6 +392,13 @@
> };
>
> &iomuxc {
> +
> + pinctrl_backlight: backlight {
^
please add 'grp'
> + fsl,pins = <
> + MX7D_PAD_GPIO1_IO11__PWM4_OUT 0x0
> + >;
> + };
IMHO the muxing is part of the pwm4 node. So rename it to
'pinctrl_pwm4: pwm4grp'.
Regards,
Marco
> +
> pinctrl_ecspi3: ecspi3grp {
> fsl,pins = <
> MX7D_PAD_I2C1_SCL__ECSPI3_MISO 0x2
> @@ -413,6 +463,40 @@
> >;
> };
>
> + pinctrl_lcdif: lcdifgrp {
> + fsl,pins = <
> + MX7D_PAD_LCD_DATA00__LCD_DATA0 0x79
> + MX7D_PAD_LCD_DATA01__LCD_DATA1 0x79
> + MX7D_PAD_LCD_DATA02__LCD_DATA2 0x79
> + MX7D_PAD_LCD_DATA03__LCD_DATA3 0x79
> + MX7D_PAD_LCD_DATA04__LCD_DATA4 0x79
> + MX7D_PAD_LCD_DATA05__LCD_DATA5 0x79
> + MX7D_PAD_LCD_DATA06__LCD_DATA6 0x79
> + MX7D_PAD_LCD_DATA07__LCD_DATA7 0x79
> + MX7D_PAD_LCD_DATA08__LCD_DATA8 0x79
> + MX7D_PAD_LCD_DATA09__LCD_DATA9 0x79
> + MX7D_PAD_LCD_DATA10__LCD_DATA10 0x79
> + MX7D_PAD_LCD_DATA11__LCD_DATA11 0x79
> + MX7D_PAD_LCD_DATA12__LCD_DATA12 0x79
> + MX7D_PAD_LCD_DATA13__LCD_DATA13 0x79
> + MX7D_PAD_LCD_DATA14__LCD_DATA14 0x79
> + MX7D_PAD_LCD_DATA15__LCD_DATA15 0x79
> + MX7D_PAD_LCD_DATA16__LCD_DATA16 0x79
> + MX7D_PAD_LCD_DATA17__LCD_DATA17 0x79
> + MX7D_PAD_LCD_DATA18__LCD_DATA18 0x79
> + MX7D_PAD_LCD_DATA19__LCD_DATA19 0x79
> + MX7D_PAD_LCD_DATA20__LCD_DATA20 0x79
> + MX7D_PAD_LCD_DATA21__LCD_DATA21 0x79
> + MX7D_PAD_LCD_DATA22__LCD_DATA22 0x79
> + MX7D_PAD_LCD_DATA23__LCD_DATA23 0x79
> + MX7D_PAD_LCD_CLK__LCD_CLK 0x79
> + MX7D_PAD_LCD_ENABLE__LCD_ENABLE 0x78
> + MX7D_PAD_LCD_VSYNC__LCD_VSYNC 0x78
> + MX7D_PAD_LCD_HSYNC__LCD_HSYNC 0x78
> + MX7D_PAD_LCD_RESET__GPIO3_IO4 0x14
> + >;
> + };
> +
> pinctrl_pwm1: pwm1 {
> fsl,pins = <
> MX7D_PAD_GPIO1_IO08__PWM1_OUT 0x7f
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: imx7d-pico: Add LCD support
2019-10-25 18:45 ` Marco Felsch
@ 2019-10-25 21:16 ` Joris Offouga
2019-10-26 19:20 ` Fabio Estevam
0 siblings, 1 reply; 6+ messages in thread
From: Joris Offouga @ 2019-10-25 21:16 UTC (permalink / raw)
To: Marco Felsch
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Otavio Salvador, Fabio Estevam, Sascha Hauer, open list,
Rob Herring, NXP Linux Team, Pengutronix Kernel Team, Shawn Guo,
linux-arm-kernel
Hi Marco,
Le 25/10/2019 à 20:45, Marco Felsch a écrit :
> Hi Joris,
>
> On 19-10-25 10:22, Joris Offouga wrote:
>> Add support for the VXT VL050-8048NT-C01 panel connected through
>> the 24 bit parallel LCDIF interface.
>>
>> Signed-off-by: Joris Offouga <offougajoris@gmail.com>
>> Signed-off-by: Fabio Estevam <festevam@gmail.com>
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>> arch/arm/boot/dts/imx7d-pico.dtsi | 84 +++++++++++++++++++++++++++++++
>> 1 file changed, 84 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx7d-pico.dtsi b/arch/arm/boot/dts/imx7d-pico.dtsi
>> index 6f50ebf31a0a..9042b1e6f1db 100644
>> --- a/arch/arm/boot/dts/imx7d-pico.dtsi
>> +++ b/arch/arm/boot/dts/imx7d-pico.dtsi
>> @@ -69,6 +69,37 @@
>> clocks = <&clks IMX7D_CLKO2_ROOT_DIV>;
>> clock-names = "ext_clock";
>> };
>> +
>> + backlight: backlight {
>> + compatible = "pwm-backlight";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_backlight>;
>> + pwms = <&pwm4 0 50000 0>;
> ^
> If not inverted please drop the this flag.
> Also you need to add
>
> &pwm4 {
> status = "okay";
> };
This node is already provide but i agree with you i move pinctrl in
pwm4 node and rename the muxing
>
> And so you can do the pwm pinctrl within that node, see below.
>
>> + brightness-levels = <0 36 72 108 144 180 216 255>;
>> + default-brightness-level = <6>;
>> + status = "okay";
> status can be dropped too.
>
>> + };
>> +
>> + reg_lcd_3v3: regulator-lcd-3v3 {
>> + compatible = "regulator-fixed";
>> + regulator-name = "lcd-3v3";
>> + regulator-min-microvolt = <3300000>;
>> + regulator-max-microvolt = <3300000>;
>> + gpio = <&gpio1 6 GPIO_ACTIVE_HIGH>;
> Missing the muxing?
No this pin is already drive
>
>> + enable-active-high;
>> + };
>> +
>> + panel {
>> + compatible = "vxt,vl050-8048nt-c01";
>> + backlight = <&backlight>;
>> + power-supply = <®_lcd_3v3>;
>> +
>> + port {
>> + panel_in: endpoint {
>> + remote-endpoint = <&display_out>;
>> + };
>> + };
>> + };
> Please sort the nodes alphabetical.
okay thanks for your review
otherwise Fabio made me notice that I should leave his From however with
the changes made I should put mine?
Best regards,
Joris
>
>> };
>>
>> &clks {
>> @@ -230,6 +261,18 @@
>> };
>> };
>>
>> +&lcdif {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_lcdif>;
>> + status = "okay";
>> +
>> + port {
>> + display_out: endpoint {
>> + remote-endpoint = <&panel_in>;
>> + };
>> + };
>> +};
>> +
>> &sai1 {
>> pinctrl-names = "default";
>> pinctrl-0 = <&pinctrl_sai1>;
>> @@ -349,6 +392,13 @@
>> };
>>
>> &iomuxc {
>> +
>> + pinctrl_backlight: backlight {
> ^
> please add 'grp'
>> + fsl,pins = <
>> + MX7D_PAD_GPIO1_IO11__PWM4_OUT 0x0
>> + >;
>> + };
> IMHO the muxing is part of the pwm4 node. So rename it to
> 'pinctrl_pwm4: pwm4grp'.
>
> Regards,
> Marco
>
>> +
>> pinctrl_ecspi3: ecspi3grp {
>> fsl,pins = <
>> MX7D_PAD_I2C1_SCL__ECSPI3_MISO 0x2
>> @@ -413,6 +463,40 @@
>> >;
>> };
>>
>> + pinctrl_lcdif: lcdifgrp {
>> + fsl,pins = <
>> + MX7D_PAD_LCD_DATA00__LCD_DATA0 0x79
>> + MX7D_PAD_LCD_DATA01__LCD_DATA1 0x79
>> + MX7D_PAD_LCD_DATA02__LCD_DATA2 0x79
>> + MX7D_PAD_LCD_DATA03__LCD_DATA3 0x79
>> + MX7D_PAD_LCD_DATA04__LCD_DATA4 0x79
>> + MX7D_PAD_LCD_DATA05__LCD_DATA5 0x79
>> + MX7D_PAD_LCD_DATA06__LCD_DATA6 0x79
>> + MX7D_PAD_LCD_DATA07__LCD_DATA7 0x79
>> + MX7D_PAD_LCD_DATA08__LCD_DATA8 0x79
>> + MX7D_PAD_LCD_DATA09__LCD_DATA9 0x79
>> + MX7D_PAD_LCD_DATA10__LCD_DATA10 0x79
>> + MX7D_PAD_LCD_DATA11__LCD_DATA11 0x79
>> + MX7D_PAD_LCD_DATA12__LCD_DATA12 0x79
>> + MX7D_PAD_LCD_DATA13__LCD_DATA13 0x79
>> + MX7D_PAD_LCD_DATA14__LCD_DATA14 0x79
>> + MX7D_PAD_LCD_DATA15__LCD_DATA15 0x79
>> + MX7D_PAD_LCD_DATA16__LCD_DATA16 0x79
>> + MX7D_PAD_LCD_DATA17__LCD_DATA17 0x79
>> + MX7D_PAD_LCD_DATA18__LCD_DATA18 0x79
>> + MX7D_PAD_LCD_DATA19__LCD_DATA19 0x79
>> + MX7D_PAD_LCD_DATA20__LCD_DATA20 0x79
>> + MX7D_PAD_LCD_DATA21__LCD_DATA21 0x79
>> + MX7D_PAD_LCD_DATA22__LCD_DATA22 0x79
>> + MX7D_PAD_LCD_DATA23__LCD_DATA23 0x79
>> + MX7D_PAD_LCD_CLK__LCD_CLK 0x79
>> + MX7D_PAD_LCD_ENABLE__LCD_ENABLE 0x78
>> + MX7D_PAD_LCD_VSYNC__LCD_VSYNC 0x78
>> + MX7D_PAD_LCD_HSYNC__LCD_HSYNC 0x78
>> + MX7D_PAD_LCD_RESET__GPIO3_IO4 0x14
>> + >;
>> + };
>> +
>> pinctrl_pwm1: pwm1 {
>> fsl,pins = <
>> MX7D_PAD_GPIO1_IO08__PWM1_OUT 0x7f
>> --
>> 2.17.1
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: imx7d-pico: Add LCD support
2019-10-25 21:16 ` Joris Offouga
@ 2019-10-26 19:20 ` Fabio Estevam
2019-10-26 20:29 ` Joris Offouga
0 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2019-10-26 19:20 UTC (permalink / raw)
To: Joris Offouga
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Otavio Salvador, Sascha Hauer, Marco Felsch, open list,
Rob Herring, NXP Linux Team, Pengutronix Kernel Team, Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
Hi Joris,
On Fri, Oct 25, 2019 at 6:16 PM Joris Offouga <offougajoris@gmail.com> wrote:
> otherwise Fabio made me notice that I should leave his From however with
> the changes made I should put mine?
It is normal when we submit someone else's patch and we need to change
a few things based on review feedback.
Even so, the original From should be kept.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx7d-pico: Add LCD support
2019-10-26 19:20 ` Fabio Estevam
@ 2019-10-26 20:29 ` Joris Offouga
0 siblings, 0 replies; 6+ messages in thread
From: Joris Offouga @ 2019-10-26 20:29 UTC (permalink / raw)
To: Fabio Estevam
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Otavio Salvador, Sascha Hauer, Marco Felsch, open list,
Rob Herring, NXP Linux Team, Pengutronix Kernel Team, Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
Hi Fabio,
Le 26/10/2019 à 21:20, Fabio Estevam a écrit :
> Hi Joris,
>
> On Fri, Oct 25, 2019 at 6:16 PM Joris Offouga <offougajoris@gmail.com> wrote:
>
>> otherwise Fabio made me notice that I should leave his From however with
>> the changes made I should put mine?
> It is normal when we submit someone else's patch and we need to change
> a few things based on review feedback.
>
> Even so, the original From should be kept.
Thanks for your reply, i send v3 with Marco's feedback
Best regards,
Joris
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-26 20:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-25 8:22 [PATCH] ARM: dts: imx7d-pico: Add LCD support Joris Offouga
2019-10-25 13:42 ` Fabio Estevam
2019-10-25 18:45 ` Marco Felsch
2019-10-25 21:16 ` Joris Offouga
2019-10-26 19:20 ` Fabio Estevam
2019-10-26 20:29 ` Joris Offouga
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).