linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* bug in error message
@ 2016-07-16 21:51 Frank Mori Hess
  2016-07-16 22:39 ` Fabio Estevam
  2016-07-16 23:43 ` Fabio Estevam
  0 siblings, 2 replies; 3+ messages in thread
From: Frank Mori Hess @ 2016-07-16 21:51 UTC (permalink / raw)
  To: linux-arm-kernel

There is a bug in arch/arm/mm/dma-mapping.c where it prints a number
in an error message in hex when it should be decimal:

pr_err("DMA: failed to allocate %zx KiB pool for atomic coherent allocation\n",
        atomic_pool_size / 1024);

patch (literally one character) here:

https://github.com/fmhess/linux/commit/dce53a26afe31c63b88bc5b5c75b41ec86579291

-- 
Frank

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug in error message
  2016-07-16 21:51 bug in error message Frank Mori Hess
@ 2016-07-16 22:39 ` Fabio Estevam
  2016-07-16 23:43 ` Fabio Estevam
  1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2016-07-16 22:39 UTC (permalink / raw)
  To: linux-arm-kernel

On Sat, Jul 16, 2016 at 6:51 PM, Frank Mori Hess <fmh6jj@gmail.com> wrote:
> There is a bug in arch/arm/mm/dma-mapping.c where it prints a number
> in an error message in hex when it should be decimal:
>
> pr_err("DMA: failed to allocate %zx KiB pool for atomic coherent allocation\n",
>         atomic_pool_size / 1024);
>
> patch (literally one character) here:
>
> https://github.com/fmhess/linux/commit/dce53a26afe31c63b88bc5b5c75b41ec86579291

Please submit a formal patch.  Check Documentation/SubmittingPatches.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug in error message
  2016-07-16 21:51 bug in error message Frank Mori Hess
  2016-07-16 22:39 ` Fabio Estevam
@ 2016-07-16 23:43 ` Fabio Estevam
  1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2016-07-16 23:43 UTC (permalink / raw)
  To: linux-arm-kernel

On Sat, Jul 16, 2016 at 6:51 PM, Frank Mori Hess <fmh6jj@gmail.com> wrote:
> There is a bug in arch/arm/mm/dma-mapping.c where it prints a number
> in an error message in hex when it should be decimal:
>
> pr_err("DMA: failed to allocate %zx KiB pool for atomic coherent allocation\n",
>         atomic_pool_size / 1024);
>
> patch (literally one character) here:
>
> https://github.com/fmhess/linux/commit/dce53a26afe31c63b88bc5b5c75b41ec86579291

Your proposed fix is not correct. You should use %zu instead.

Thanks for reporting it anyway. Will submit a patch.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-07-16 23:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-16 21:51 bug in error message Frank Mori Hess
2016-07-16 22:39 ` Fabio Estevam
2016-07-16 23:43 ` Fabio Estevam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).