linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx6qdl-udoo: Add Pincfgs for UART4
       [not found] <1538663639-3427-1-git-send-email-kueffner.markus@gmail.com>
@ 2018-10-08  6:05 ` Shawn Guo
  2018-10-10 21:57   ` Maciej S. Szmigiero
  2018-10-08 20:51 ` Fabio Estevam
  1 sibling, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2018-10-08  6:05 UTC (permalink / raw)
  To: linux-arm-kernel

Add a few udoo board users for comment.

On Thu, Oct 04, 2018 at 04:33:59PM +0200, Markus Kueffner wrote:
> From: Markus Kueffner <kueffner.markus@gmail.com>
> 
> Add Pincfgs for UART4 to enable Communication with the onboard SAM3X
> 
> Signed-off-by: Markus Kueffner <kueffner.markus@gmail.com>
> ---
>  arch/arm/boot/dts/imx6qdl-udoo.dtsi | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-udoo.dtsi b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
> index 4f27861..5614170 100644
> --- a/arch/arm/boot/dts/imx6qdl-udoo.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
> @@ -195,6 +195,13 @@
>  			>;
>  		};
>  
> +		pinctrl_uart4: uart4grp {
> +			fsl,pins = <
> +				MX6QDL_PAD_KEY_COL0__UART4_TX_DATA	0x1b0b1
> +				MX6QDL_PAD_KEY_ROW0__UART4_RX_DATA	0x1b0b1
> +			>;
> +		};
> +
>  		pinctrl_usbh: usbhgrp {
>  			fsl,pins = <
>  				MX6QDL_PAD_GPIO_17__GPIO7_IO12 0x80000000
> @@ -265,6 +272,12 @@
>  	status = "okay";
>  };
>  
> +&uart4 { // iMX6-Arduino internal serial port - ttymxc3
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_uart4>;
> +	status = "okay";
> +};
> +
>  &usbh1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_usbh>;
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: imx6qdl-udoo: Add Pincfgs for UART4
       [not found] <1538663639-3427-1-git-send-email-kueffner.markus@gmail.com>
  2018-10-08  6:05 ` [PATCH] ARM: dts: imx6qdl-udoo: Add Pincfgs for UART4 Shawn Guo
@ 2018-10-08 20:51 ` Fabio Estevam
  2018-10-10  8:19   ` Markus Kueffner
  1 sibling, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2018-10-08 20:51 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Oct 4, 2018 at 11:35 AM Markus Kueffner
<kueffner.markus@gmail.com> wrote:
>
> From: Markus Kueffner <kueffner.markus@gmail.com>
>
> Add Pincfgs for UART4 to enable Communication with the onboard SAM3X
>
> Signed-off-by: Markus Kueffner <kueffner.markus@gmail.com>

Looks good as per the schematics:

Reviewed-by: Fabio Estevam <festevam@gmail.com>

> +&uart4 { // iMX6-Arduino internal serial port - ttymxc3

Minor nit: // style comment should be avoided.

Actually the whole comment could de dropped IMHO.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: imx6qdl-udoo: Add Pincfgs for UART4
  2018-10-08 20:51 ` Fabio Estevam
@ 2018-10-10  8:19   ` Markus Kueffner
  2018-10-10 22:20     ` Fabio Estevam
  2018-10-11 13:12     ` Shawn Guo
  0 siblings, 2 replies; 6+ messages in thread
From: Markus Kueffner @ 2018-10-10  8:19 UTC (permalink / raw)
  To: linux-arm-kernel

>From b25738867245688e0a1eafeb78379efc6a73b66e Mon Sep 17 00:00:00 2001
From: Markus Kueffner <kueffner.markus@gmail.com>
Date: Wed, 10 Oct 2018 08:32:09 +0200
Subject: [PATCH v2] ARM: dts: imx6qdl-udoo: Add Pincfgs for UART4

Add Pincfgs for UART4 to enable Communication with the onboard SAM3X

Signed-off-by: Markus Kueffner <kueffner.markus@gmail.com>
---
Changes in v2:
  - Removed // style Comment.

 arch/arm/boot/dts/imx6qdl-udoo.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-udoo.dtsi b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
index 4f27861..40d1b0d 100644
--- a/arch/arm/boot/dts/imx6qdl-udoo.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
@@ -195,6 +195,13 @@
 			>;
 		};
 
+		pinctrl_uart4: uart4grp {
+			fsl,pins = <
+				MX6QDL_PAD_KEY_COL0__UART4_TX_DATA	0x1b0b1
+				MX6QDL_PAD_KEY_ROW0__UART4_RX_DATA	0x1b0b1
+			>;
+		};
+
 		pinctrl_usbh: usbhgrp {
 			fsl,pins = <
 				MX6QDL_PAD_GPIO_17__GPIO7_IO12 0x80000000
@@ -265,6 +272,12 @@
 	status = "okay";
 };
 
+&uart4 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart4>;
+	status = "okay";
+};
+
 &usbh1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_usbh>;
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: imx6qdl-udoo: Add Pincfgs for UART4
  2018-10-08  6:05 ` [PATCH] ARM: dts: imx6qdl-udoo: Add Pincfgs for UART4 Shawn Guo
@ 2018-10-10 21:57   ` Maciej S. Szmigiero
  0 siblings, 0 replies; 6+ messages in thread
From: Maciej S. Szmigiero @ 2018-10-10 21:57 UTC (permalink / raw)
  To: linux-arm-kernel

On 08.10.2018 08:05, Shawn Guo wrote:
> Add a few udoo board users for comment.
> 
> On Thu, Oct 04, 2018 at 04:33:59PM +0200, Markus Kueffner wrote:
>> From: Markus Kueffner <kueffner.markus@gmail.com>
>>
>> Add Pincfgs for UART4 to enable Communication with the onboard SAM3X

Although I can't test this patch on a real board, verifying it with
UDOO schematic and docs suggests that this change does make sense.

Maciej

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: imx6qdl-udoo: Add Pincfgs for UART4
  2018-10-10  8:19   ` Markus Kueffner
@ 2018-10-10 22:20     ` Fabio Estevam
  2018-10-11 13:12     ` Shawn Guo
  1 sibling, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2018-10-10 22:20 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Oct 10, 2018 at 5:19 AM Markus Kueffner
<kueffner.markus@gmail.com> wrote:
>
> From b25738867245688e0a1eafeb78379efc6a73b66e Mon Sep 17 00:00:00 2001
> From: Markus Kueffner <kueffner.markus@gmail.com>
> Date: Wed, 10 Oct 2018 08:32:09 +0200
> Subject: [PATCH v2] ARM: dts: imx6qdl-udoo: Add Pincfgs for UART4
>
> Add Pincfgs for UART4 to enable Communication with the onboard SAM3X
>
> Signed-off-by: Markus Kueffner <kueffner.markus@gmail.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: imx6qdl-udoo: Add Pincfgs for UART4
  2018-10-10  8:19   ` Markus Kueffner
  2018-10-10 22:20     ` Fabio Estevam
@ 2018-10-11 13:12     ` Shawn Guo
  1 sibling, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2018-10-11 13:12 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Oct 10, 2018 at 10:19:04AM +0200, Markus Kueffner wrote:
> From: Markus Kueffner <kueffner.markus@gmail.com>
> Date: Wed, 10 Oct 2018 08:32:09 +0200
> Subject: [PATCH v2] ARM: dts: imx6qdl-udoo: Add Pincfgs for UART4
> 
> Add Pincfgs for UART4 to enable Communication with the onboard SAM3X
> 
> Signed-off-by: Markus Kueffner <kueffner.markus@gmail.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-11 13:12 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1538663639-3427-1-git-send-email-kueffner.markus@gmail.com>
2018-10-08  6:05 ` [PATCH] ARM: dts: imx6qdl-udoo: Add Pincfgs for UART4 Shawn Guo
2018-10-10 21:57   ` Maciej S. Szmigiero
2018-10-08 20:51 ` Fabio Estevam
2018-10-10  8:19   ` Markus Kueffner
2018-10-10 22:20     ` Fabio Estevam
2018-10-11 13:12     ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).