linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: imx6q: Enable CAN in board DTS
@ 2019-09-17 14:37 Marek Vasut
  2019-09-17 14:37 ` [PATCH 2/2] ARM: dts: imx6q: Add ethernet PHY power GPIO Marek Vasut
  2019-09-17 15:29 ` [PATCH 1/2] ARM: dts: imx6q: Enable CAN in board DTS Fabio Estevam
  0 siblings, 2 replies; 4+ messages in thread
From: Marek Vasut @ 2019-09-17 14:37 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Marek Vasut, Shawn Guo, Fabio Estevam, NXP Linux Team, Ludwig Zenz

Move the CAN enablement from SoM DTSi to board DTS, as each board might need
different CAN configuration. Moreover, disable CAN2 on the PDK2 as it is not
available on any connector. This also fixes on-SoM SD slot operation, as it
shares pins with the CAN2.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Ludwig Zenz <lzenz@dh-electronics.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: NXP Linux Team <linux-imx@nxp.com>
To: linux-arm-kernel@lists.infradead.org
---
 arch/arm/boot/dts/imx6q-dhcom-pdk2.dts | 8 ++++++++
 arch/arm/boot/dts/imx6q-dhcom-som.dtsi | 2 --
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx6q-dhcom-pdk2.dts b/arch/arm/boot/dts/imx6q-dhcom-pdk2.dts
index 9c61e3be2d9a..5219553df1e7 100644
--- a/arch/arm/boot/dts/imx6q-dhcom-pdk2.dts
+++ b/arch/arm/boot/dts/imx6q-dhcom-pdk2.dts
@@ -43,6 +43,14 @@
 	status = "okay";
 };
 
+&can1 {
+	status = "okay";
+};
+
+&can2 {
+	status = "disabled";
+};
+
 &hdmi {
 	ddc-i2c-bus = <&i2c2>;
 	status = "okay";
diff --git a/arch/arm/boot/dts/imx6q-dhcom-som.dtsi b/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
index 387801dde02e..845cfad99bf9 100644
--- a/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
+++ b/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
@@ -51,13 +51,11 @@
 &can1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_flexcan1>;
-	status = "okay";
 };
 
 &can2 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_flexcan2>;
-	status = "okay";
 };
 
 &ecspi1 {
-- 
2.23.0.rc1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] ARM: dts: imx6q: Add ethernet PHY power GPIO
  2019-09-17 14:37 [PATCH 1/2] ARM: dts: imx6q: Enable CAN in board DTS Marek Vasut
@ 2019-09-17 14:37 ` Marek Vasut
  2019-09-17 15:30   ` Fabio Estevam
  2019-09-17 15:29 ` [PATCH 1/2] ARM: dts: imx6q: Enable CAN in board DTS Fabio Estevam
  1 sibling, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2019-09-17 14:37 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Marek Vasut, Shawn Guo, Fabio Estevam, NXP Linux Team, Ludwig Zenz

Add missing ethernet PHY power GPIO.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Ludwig Zenz <lzenz@dh-electronics.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: NXP Linux Team <linux-imx@nxp.com>
To: linux-arm-kernel@lists.infradead.org
---
 arch/arm/boot/dts/imx6q-dhcom-som.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/imx6q-dhcom-som.dtsi b/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
index 845cfad99bf9..687caedf0784 100644
--- a/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
+++ b/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
@@ -86,6 +86,7 @@
 	pinctrl-0 = <&pinctrl_enet_100M>;
 	phy-mode = "rmii";
 	phy-handle = <&ethphy0>;
+	power-gpios = <&gpio1 7 GPIO_ACTIVE_LOW>;
 	status = "okay";
 
 	mdio {
-- 
2.23.0.rc1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] ARM: dts: imx6q: Enable CAN in board DTS
  2019-09-17 14:37 [PATCH 1/2] ARM: dts: imx6q: Enable CAN in board DTS Marek Vasut
  2019-09-17 14:37 ` [PATCH 2/2] ARM: dts: imx6q: Add ethernet PHY power GPIO Marek Vasut
@ 2019-09-17 15:29 ` Fabio Estevam
  1 sibling, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2019-09-17 15:29 UTC (permalink / raw)
  To: Marek Vasut
  Cc: Shawn Guo, Ludwig Zenz,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	NXP Linux Team

Hi Marek,

On Tue, Sep 17, 2019 at 11:37 AM Marek Vasut <marex@denx.de> wrote:

In the Subject, please make it more specific by stating the board name:

ARM: dts: imx6q-dhcom: Enable CAN

> Move the CAN enablement from SoM DTSi to board DTS, as each board might need
> different CAN configuration. Moreover, disable CAN2 on the PDK2 as it is not
> available on any connector. This also fixes on-SoM SD slot operation, as it
> shares pins with the CAN2.
>
> Signed-off-by: Marek Vasut <marex@denx.de>

Apart from that:

Reviewed-by: Fabio Estevam <festevam@gmail.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] ARM: dts: imx6q: Add ethernet PHY power GPIO
  2019-09-17 14:37 ` [PATCH 2/2] ARM: dts: imx6q: Add ethernet PHY power GPIO Marek Vasut
@ 2019-09-17 15:30   ` Fabio Estevam
  0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2019-09-17 15:30 UTC (permalink / raw)
  To: Marek Vasut
  Cc: Shawn Guo, Ludwig Zenz,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	NXP Linux Team

Hi Marek,

On Tue, Sep 17, 2019 at 11:37 AM Marek Vasut <marex@denx.de> wrote:

> diff --git a/arch/arm/boot/dts/imx6q-dhcom-som.dtsi b/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
> index 845cfad99bf9..687caedf0784 100644
> --- a/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
> +++ b/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
> @@ -86,6 +86,7 @@
>         pinctrl-0 = <&pinctrl_enet_100M>;
>         phy-mode = "rmii";
>         phy-handle = <&ethphy0>;
> +       power-gpios = <&gpio1 7 GPIO_ACTIVE_LOW>;

This is not a documented property.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-09-17 15:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-17 14:37 [PATCH 1/2] ARM: dts: imx6q: Enable CAN in board DTS Marek Vasut
2019-09-17 14:37 ` [PATCH 2/2] ARM: dts: imx6q: Add ethernet PHY power GPIO Marek Vasut
2019-09-17 15:30   ` Fabio Estevam
2019-09-17 15:29 ` [PATCH 1/2] ARM: dts: imx6q: Enable CAN in board DTS Fabio Estevam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).