* [PATCH 1/3] dt-bindings: mmc: imx: fix the wrongly dropped imx8qm compatible string
@ 2020-11-19 12:53 Dong Aisheng
2020-11-19 12:53 ` [PATCH 2/3] dt-bindings: arm: fsl: add imx8qm boards " Dong Aisheng
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Dong Aisheng @ 2020-11-19 12:53 UTC (permalink / raw)
To: devicetree
Cc: Dong Aisheng, Ulf Hansson, linux-mmc, Krzysztof Kozlowski,
Haibo Chen, linux-arm-kernel, linux-imx
The compatible string "fsl,imx8qm-usdhc" was wrongly dropped in patch:
80fd350b9590 ("dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 compatible matching")
Add it back.
Cc: Haibo Chen <haibo.chen@nxp.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org
Fixes: 80fd350b9590 ("dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 compatible matching")
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
index e71d13c2d109..802c9df23752 100644
--- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
+++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
@@ -39,6 +39,7 @@ properties:
- fsl,imx8mn-usdhc
- fsl,imx8mp-usdhc
- fsl,imx8mq-usdhc
+ - fsl,imx8qm-usdhc
- fsl,imx8qxp-usdhc
- const: fsl,imx7d-usdhc
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/3] dt-bindings: arm: fsl: add imx8qm boards compatible string
2020-11-19 12:53 [PATCH 1/3] dt-bindings: mmc: imx: fix the wrongly dropped imx8qm compatible string Dong Aisheng
@ 2020-11-19 12:53 ` Dong Aisheng
2020-11-19 13:22 ` Krzysztof Kozlowski
2020-11-19 12:53 ` [PATCH 3/3] dt-bindings: mailbox: mu: add imx8qm support Dong Aisheng
2020-11-19 13:17 ` [PATCH 1/3] dt-bindings: mmc: imx: fix the wrongly dropped imx8qm compatible string Krzysztof Kozlowski
2 siblings, 1 reply; 14+ messages in thread
From: Dong Aisheng @ 2020-11-19 12:53 UTC (permalink / raw)
To: devicetree
Cc: Dong Aisheng, Rob Herring, Shawn Guo, linux-imx, linux-arm-kernel
Add imx8qm boards compatible string
Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index f793f90fe2e6..d69ac5c0554e 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -726,6 +726,12 @@ properties:
- const: zii,imx8mq-ultra
- const: fsl,imx8mq
+ - description: i.MX8QM based Boards
+ items:
+ - enum:
+ - fsl,imx8qm-mek # i.MX8QM MEK Board
+ - const: fsl,imx8qm
+
- description: i.MX8QXP based Boards
items:
- enum:
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 3/3] dt-bindings: mailbox: mu: add imx8qm support
2020-11-19 12:53 [PATCH 1/3] dt-bindings: mmc: imx: fix the wrongly dropped imx8qm compatible string Dong Aisheng
2020-11-19 12:53 ` [PATCH 2/3] dt-bindings: arm: fsl: add imx8qm boards " Dong Aisheng
@ 2020-11-19 12:53 ` Dong Aisheng
2020-11-19 13:23 ` Krzysztof Kozlowski
2020-11-19 13:17 ` [PATCH 1/3] dt-bindings: mmc: imx: fix the wrongly dropped imx8qm compatible string Krzysztof Kozlowski
2 siblings, 1 reply; 14+ messages in thread
From: Dong Aisheng @ 2020-11-19 12:53 UTC (permalink / raw)
To: devicetree
Cc: Dong Aisheng, Rob Herring, Shawn Guo, linux-imx, linux-arm-kernel
Add imx8qm support
Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
Documentation/devicetree/bindings/mailbox/fsl,mu.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
index 15cef82cd356..1a3dff277e2b 100644
--- a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
+++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
@@ -34,12 +34,15 @@ properties:
- fsl,imx8mm-mu
- fsl,imx8mn-mu
- fsl,imx8mp-mu
+ - fsl,imx8qm-mu
- fsl,imx8qxp-mu
- const: fsl,imx6sx-mu
- description: To communicate with i.MX8 SCU with fast IPC
items:
- const: fsl,imx8-mu-scu
- - const: fsl,imx8qxp-mu
+ - enum:
+ - fsl,imx8qm-mu
+ - fsl,imx8qxp-mu
- const: fsl,imx6sx-mu
reg:
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] dt-bindings: mmc: imx: fix the wrongly dropped imx8qm compatible string
2020-11-19 12:53 [PATCH 1/3] dt-bindings: mmc: imx: fix the wrongly dropped imx8qm compatible string Dong Aisheng
2020-11-19 12:53 ` [PATCH 2/3] dt-bindings: arm: fsl: add imx8qm boards " Dong Aisheng
2020-11-19 12:53 ` [PATCH 3/3] dt-bindings: mailbox: mu: add imx8qm support Dong Aisheng
@ 2020-11-19 13:17 ` Krzysztof Kozlowski
2020-11-19 15:21 ` Aisheng Dong
2 siblings, 1 reply; 14+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-19 13:17 UTC (permalink / raw)
To: Dong Aisheng
Cc: devicetree, Ulf Hansson, linux-mmc, Haibo Chen, linux-imx,
linux-arm-kernel
On Thu, Nov 19, 2020 at 08:53:02PM +0800, Dong Aisheng wrote:
> The compatible string "fsl,imx8qm-usdhc" was wrongly dropped in patch:
> 80fd350b9590 ("dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 compatible matching")
> Add it back.
Although the compatible was dropped, by why wrongly? Please describe it.
The compatible is nowhere to be found, it is not used.
Best regards,
Krzysztof
>
> Cc: Haibo Chen <haibo.chen@nxp.com>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: linux-mmc@vger.kernel.org
> Fixes: 80fd350b9590 ("dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 compatible matching")
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/3] dt-bindings: arm: fsl: add imx8qm boards compatible string
2020-11-19 12:53 ` [PATCH 2/3] dt-bindings: arm: fsl: add imx8qm boards " Dong Aisheng
@ 2020-11-19 13:22 ` Krzysztof Kozlowski
2020-11-19 15:25 ` Aisheng Dong
0 siblings, 1 reply; 14+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-19 13:22 UTC (permalink / raw)
To: Dong Aisheng
Cc: devicetree, Rob Herring, Shawn Guo, linux-imx, linux-arm-kernel
On Thu, Nov 19, 2020 at 08:53:03PM +0800, Dong Aisheng wrote:
> Add imx8qm boards compatible string
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: Shawn Guo <shawnguo@kernel.org>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index f793f90fe2e6..d69ac5c0554e 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -726,6 +726,12 @@ properties:
> - const: zii,imx8mq-ultra
> - const: fsl,imx8mq
>
> + - description: i.MX8QM based Boards
> + items:
> + - enum:
> + - fsl,imx8qm-mek # i.MX8QM MEK Board
No, please include the boards DTS in this patchset.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] dt-bindings: mailbox: mu: add imx8qm support
2020-11-19 12:53 ` [PATCH 3/3] dt-bindings: mailbox: mu: add imx8qm support Dong Aisheng
@ 2020-11-19 13:23 ` Krzysztof Kozlowski
2020-11-19 15:24 ` Aisheng Dong
0 siblings, 1 reply; 14+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-19 13:23 UTC (permalink / raw)
To: Dong Aisheng
Cc: devicetree, Rob Herring, Shawn Guo, linux-imx, linux-arm-kernel
On Thu, Nov 19, 2020 at 08:53:04PM +0800, Dong Aisheng wrote:
> Add imx8qm support
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: Shawn Guo <shawnguo@kernel.org>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> Documentation/devicetree/bindings/mailbox/fsl,mu.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> index 15cef82cd356..1a3dff277e2b 100644
> --- a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> @@ -34,12 +34,15 @@ properties:
> - fsl,imx8mm-mu
> - fsl,imx8mn-mu
> - fsl,imx8mp-mu
> + - fsl,imx8qm-mu
You add the compatible below, so decide which one is it. Please provide
also users of this compatible - DTS.
Best regards,
Krzysztof
> - fsl,imx8qxp-mu
> - const: fsl,imx6sx-mu
> - description: To communicate with i.MX8 SCU with fast IPC
> items:
> - const: fsl,imx8-mu-scu
> - - const: fsl,imx8qxp-mu
> + - enum:
> + - fsl,imx8qm-mu
> + - fsl,imx8qxp-mu
> - const: fsl,imx6sx-mu
>
> reg:
> --
> 2.23.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH 1/3] dt-bindings: mmc: imx: fix the wrongly dropped imx8qm compatible string
2020-11-19 13:17 ` [PATCH 1/3] dt-bindings: mmc: imx: fix the wrongly dropped imx8qm compatible string Krzysztof Kozlowski
@ 2020-11-19 15:21 ` Aisheng Dong
2020-11-19 15:25 ` Krzysztof Kozlowski
0 siblings, 1 reply; 14+ messages in thread
From: Aisheng Dong @ 2020-11-19 15:21 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Ulf Hansson, linux-mmc, Bough Chen, dl-linux-imx,
linux-arm-kernel
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Thursday, November 19, 2020 9:17 PM
>
> On Thu, Nov 19, 2020 at 08:53:02PM +0800, Dong Aisheng wrote:
> > The compatible string "fsl,imx8qm-usdhc" was wrongly dropped in patch:
> > 80fd350b9590 ("dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 compatible
> > matching") Add it back.
>
> Although the compatible was dropped, by why wrongly? Please describe it.
> The compatible is nowhere to be found, it is not used.
The DT patch using it is still under review. So we need it.
Regards
Aisheng
>
> Best regards,
> Krzysztof
>
> >
> > Cc: Haibo Chen <haibo.chen@nxp.com>
> > Cc: Krzysztof Kozlowski <krzk@kernel.org>
> > Cc: Ulf Hansson <ulf.hansson@linaro.org>
> > Cc: linux-mmc@vger.kernel.org
> > Fixes: 80fd350b9590 ("dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8
> > compatible matching")
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > ---
> > Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH 3/3] dt-bindings: mailbox: mu: add imx8qm support
2020-11-19 13:23 ` Krzysztof Kozlowski
@ 2020-11-19 15:24 ` Aisheng Dong
2020-11-19 15:27 ` Krzysztof Kozlowski
0 siblings, 1 reply; 14+ messages in thread
From: Aisheng Dong @ 2020-11-19 15:24 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Rob Herring, Shawn Guo, dl-linux-imx, linux-arm-kernel
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Thursday, November 19, 2020 9:23 PM
>
> On Thu, Nov 19, 2020 at 08:53:04PM +0800, Dong Aisheng wrote:
> > Add imx8qm support
> >
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: devicetree@vger.kernel.org
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > ---
> > Documentation/devicetree/bindings/mailbox/fsl,mu.yaml | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > index 15cef82cd356..1a3dff277e2b 100644
> > --- a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > +++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > @@ -34,12 +34,15 @@ properties:
> > - fsl,imx8mm-mu
> > - fsl,imx8mn-mu
> > - fsl,imx8mp-mu
> > + - fsl,imx8qm-mu
>
> You add the compatible below, so decide which one is it. Please provide also
> users of this compatible - DTS.
There're two SCU MU protocol bindings, both can be used, just like exist fsl,imx8qxp-mu.
Regards
Aisheng
Both can be used, depends on which proto
>
> Best regards,
> Krzysztof
>
> > - fsl,imx8qxp-mu
> > - const: fsl,imx6sx-mu
> > - description: To communicate with i.MX8 SCU with fast IPC
> > items:
> > - const: fsl,imx8-mu-scu
> > - - const: fsl,imx8qxp-mu
> > + - enum:
> > + - fsl,imx8qm-mu
> > + - fsl,imx8qxp-mu
> > - const: fsl,imx6sx-mu
> >
> > reg:
> > --
> > 2.23.0
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] dt-bindings: mmc: imx: fix the wrongly dropped imx8qm compatible string
2020-11-19 15:21 ` Aisheng Dong
@ 2020-11-19 15:25 ` Krzysztof Kozlowski
2020-11-23 12:28 ` Ulf Hansson
0 siblings, 1 reply; 14+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-19 15:25 UTC (permalink / raw)
To: Aisheng Dong
Cc: devicetree, Ulf Hansson, linux-mmc, Bough Chen, dl-linux-imx,
linux-arm-kernel
On Thu, Nov 19, 2020 at 03:21:59PM +0000, Aisheng Dong wrote:
> > From: Krzysztof Kozlowski <krzk@kernel.org>
> > Sent: Thursday, November 19, 2020 9:17 PM
> >
> > On Thu, Nov 19, 2020 at 08:53:02PM +0800, Dong Aisheng wrote:
> > > The compatible string "fsl,imx8qm-usdhc" was wrongly dropped in patch:
> > > 80fd350b9590 ("dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 compatible
> > > matching") Add it back.
> >
> > Although the compatible was dropped, by why wrongly? Please describe it.
> > The compatible is nowhere to be found, it is not used.
>
> The DT patch using it is still under review. So we need it.
It looks like other patches here follow similar process of sending
and applying dt-bindings separately from patches with users of these
bindings. Please don't do it like this. Send the bindings as the first
patch in the series implementing the users (so usually the series with
driver and DTS changes). The new bindings then are applied by the
driver subsystem maintainer.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH 2/3] dt-bindings: arm: fsl: add imx8qm boards compatible string
2020-11-19 13:22 ` Krzysztof Kozlowski
@ 2020-11-19 15:25 ` Aisheng Dong
2020-11-19 15:30 ` Krzysztof Kozlowski
0 siblings, 1 reply; 14+ messages in thread
From: Aisheng Dong @ 2020-11-19 15:25 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Rob Herring, Shawn Guo, dl-linux-imx, linux-arm-kernel
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Thursday, November 19, 2020 9:22 PM
>
> On Thu, Nov 19, 2020 at 08:53:03PM +0800, Dong Aisheng wrote:
> > Add imx8qm boards compatible string
> >
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: devicetree@vger.kernel.org
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > ---
> > Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml
> b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index f793f90fe2e6..d69ac5c0554e 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -726,6 +726,12 @@ properties:
> > - const: zii,imx8mq-ultra
> > - const: fsl,imx8mq
> >
> > + - description: i.MX8QM based Boards
> > + items:
> > + - enum:
> > + - fsl,imx8qm-mek # i.MX8QM MEK Board
>
> No, please include the boards DTS in this patchset.
Good suggestion. Should I resend as DT patchset using it was also under review?
Regards
Aisheng
>
> Best regards,
> Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] dt-bindings: mailbox: mu: add imx8qm support
2020-11-19 15:24 ` Aisheng Dong
@ 2020-11-19 15:27 ` Krzysztof Kozlowski
0 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-19 15:27 UTC (permalink / raw)
To: Aisheng Dong
Cc: devicetree, Rob Herring, Shawn Guo, dl-linux-imx, linux-arm-kernel
On Thu, Nov 19, 2020 at 03:24:21PM +0000, Aisheng Dong wrote:
> > From: Krzysztof Kozlowski <krzk@kernel.org>
> > Sent: Thursday, November 19, 2020 9:23 PM
> >
> > On Thu, Nov 19, 2020 at 08:53:04PM +0800, Dong Aisheng wrote:
> > > Add imx8qm support
> > >
> > > Cc: Rob Herring <robh+dt@kernel.org>
> > > Cc: devicetree@vger.kernel.org
> > > Cc: Shawn Guo <shawnguo@kernel.org>
> > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > > ---
> > > Documentation/devicetree/bindings/mailbox/fsl,mu.yaml | 5 ++++-
> > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > > b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > > index 15cef82cd356..1a3dff277e2b 100644
> > > --- a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > > +++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > > @@ -34,12 +34,15 @@ properties:
> > > - fsl,imx8mm-mu
> > > - fsl,imx8mn-mu
> > > - fsl,imx8mp-mu
> > > + - fsl,imx8qm-mu
> >
> > You add the compatible below, so decide which one is it. Please provide also
> > users of this compatible - DTS.
>
> There're two SCU MU protocol bindings, both can be used, just like exist fsl,imx8qxp-mu.
Makes sense. Still please send the bindings as first patch in series
implementing them. Upstream also the DTS with the bindings - the best in
the same series.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/3] dt-bindings: arm: fsl: add imx8qm boards compatible string
2020-11-19 15:25 ` Aisheng Dong
@ 2020-11-19 15:30 ` Krzysztof Kozlowski
0 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-19 15:30 UTC (permalink / raw)
To: Aisheng Dong
Cc: devicetree, Rob Herring, Shawn Guo, dl-linux-imx, linux-arm-kernel
On Thu, Nov 19, 2020 at 03:25:38PM +0000, Aisheng Dong wrote:
> > From: Krzysztof Kozlowski <krzk@kernel.org>
> > Sent: Thursday, November 19, 2020 9:22 PM
> >
> > On Thu, Nov 19, 2020 at 08:53:03PM +0800, Dong Aisheng wrote:
> > > Add imx8qm boards compatible string
> > >
> > > Cc: Rob Herring <robh+dt@kernel.org>
> > > Cc: devicetree@vger.kernel.org
> > > Cc: Shawn Guo <shawnguo@kernel.org>
> > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > > ---
> > > Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml
> > b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > index f793f90fe2e6..d69ac5c0554e 100644
> > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > @@ -726,6 +726,12 @@ properties:
> > > - const: zii,imx8mq-ultra
> > > - const: fsl,imx8mq
> > >
> > > + - description: i.MX8QM based Boards
> > > + items:
> > > + - enum:
> > > + - fsl,imx8qm-mek # i.MX8QM MEK Board
> >
> > No, please include the boards DTS in this patchset.
>
> Good suggestion. Should I resend as DT patchset using it was also under review?
Patchsets bringing new boards should be organized like this one:
https://lore.kernel.org/lkml/20201107144811.1977108-1-aford173@gmail.com/
First the vendor prefix binding (skipped above), then the board binding
and finally DTS patches.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] dt-bindings: mmc: imx: fix the wrongly dropped imx8qm compatible string
2020-11-19 15:25 ` Krzysztof Kozlowski
@ 2020-11-23 12:28 ` Ulf Hansson
2020-11-24 7:02 ` Aisheng Dong
0 siblings, 1 reply; 14+ messages in thread
From: Ulf Hansson @ 2020-11-23 12:28 UTC (permalink / raw)
To: Krzysztof Kozlowski, Aisheng Dong
Cc: devicetree, Bough Chen, linux-mmc, dl-linux-imx, linux-arm-kernel
On Thu, 19 Nov 2020 at 16:25, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Thu, Nov 19, 2020 at 03:21:59PM +0000, Aisheng Dong wrote:
> > > From: Krzysztof Kozlowski <krzk@kernel.org>
> > > Sent: Thursday, November 19, 2020 9:17 PM
> > >
> > > On Thu, Nov 19, 2020 at 08:53:02PM +0800, Dong Aisheng wrote:
> > > > The compatible string "fsl,imx8qm-usdhc" was wrongly dropped in patch:
> > > > 80fd350b9590 ("dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 compatible
> > > > matching") Add it back.
> > >
> > > Although the compatible was dropped, by why wrongly? Please describe it.
> > > The compatible is nowhere to be found, it is not used.
> >
> > The DT patch using it is still under review. So we need it.
Where? Is there a corresponding update to the mmc driver?
>
> It looks like other patches here follow similar process of sending
> and applying dt-bindings separately from patches with users of these
> bindings. Please don't do it like this. Send the bindings as the first
> patch in the series implementing the users (so usually the series with
> driver and DTS changes). The new bindings then are applied by the
> driver subsystem maintainer.
Yep, I fully agree, that's the preferred approach.
Perhaps it's simply better if the series is reposted to linux-mmc
(including the DT doc).
Kind regards
Uffe
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH 1/3] dt-bindings: mmc: imx: fix the wrongly dropped imx8qm compatible string
2020-11-23 12:28 ` Ulf Hansson
@ 2020-11-24 7:02 ` Aisheng Dong
0 siblings, 0 replies; 14+ messages in thread
From: Aisheng Dong @ 2020-11-24 7:02 UTC (permalink / raw)
To: Ulf Hansson, Krzysztof Kozlowski
Cc: devicetree, Bough Chen, linux-mmc, dl-linux-imx, linux-arm-kernel
> From: Ulf Hansson <ulf.hansson@linaro.org>
> Sent: Monday, November 23, 2020 8:28 PM
>
> On Thu, 19 Nov 2020 at 16:25, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > On Thu, Nov 19, 2020 at 03:21:59PM +0000, Aisheng Dong wrote:
> > > > From: Krzysztof Kozlowski <krzk@kernel.org>
> > > > Sent: Thursday, November 19, 2020 9:17 PM
> > > >
> > > > On Thu, Nov 19, 2020 at 08:53:02PM +0800, Dong Aisheng wrote:
> > > > > The compatible string "fsl,imx8qm-usdhc" was wrongly dropped in
> patch:
> > > > > 80fd350b9590 ("dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8
> > > > > compatible
> > > > > matching") Add it back.
> > > >
> > > > Although the compatible was dropped, by why wrongly? Please describe it.
> > > > The compatible is nowhere to be found, it is not used.
> > >
> > > The DT patch using it is still under review. So we need it.
>
> Where? Is there a corresponding update to the mmc driver?
>
> >
> > It looks like other patches here follow similar process of sending and
> > applying dt-bindings separately from patches with users of these
> > bindings. Please don't do it like this. Send the bindings as the first
> > patch in the series implementing the users (so usually the series with
> > driver and DTS changes). The new bindings then are applied by the
> > driver subsystem maintainer.
>
> Yep, I fully agree, that's the preferred approach.
>
> Perhaps it's simply better if the series is reposted to linux-mmc (including the DT
> doc).
I'm going to resend the series with dt-binding patches first.
Thanks for the advice.
Regards
Aisheng
>
> Kind regards
> Uffe
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2020-11-24 7:03 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-19 12:53 [PATCH 1/3] dt-bindings: mmc: imx: fix the wrongly dropped imx8qm compatible string Dong Aisheng
2020-11-19 12:53 ` [PATCH 2/3] dt-bindings: arm: fsl: add imx8qm boards " Dong Aisheng
2020-11-19 13:22 ` Krzysztof Kozlowski
2020-11-19 15:25 ` Aisheng Dong
2020-11-19 15:30 ` Krzysztof Kozlowski
2020-11-19 12:53 ` [PATCH 3/3] dt-bindings: mailbox: mu: add imx8qm support Dong Aisheng
2020-11-19 13:23 ` Krzysztof Kozlowski
2020-11-19 15:24 ` Aisheng Dong
2020-11-19 15:27 ` Krzysztof Kozlowski
2020-11-19 13:17 ` [PATCH 1/3] dt-bindings: mmc: imx: fix the wrongly dropped imx8qm compatible string Krzysztof Kozlowski
2020-11-19 15:21 ` Aisheng Dong
2020-11-19 15:25 ` Krzysztof Kozlowski
2020-11-23 12:28 ` Ulf Hansson
2020-11-24 7:02 ` Aisheng Dong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).