* [PATCH] mmc: mmci: stm32: make sdmmc_idma_validate_data static
@ 2019-10-09 11:54 Ben Dooks
2019-10-18 10:58 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2019-10-09 11:54 UTC (permalink / raw)
To: linux-kernel
Cc: Ulf Hansson, Alexandre Torgue, linux-mmc, Ben Dooks,
Maxime Coquelin, linux-stm32, linux-arm-kernel
Make sdmmc_idma_validate_data to avoid the following warning
from sparse:
drivers/mmc/host/mmci_stm32_sdmmc.c:28:5: warning: symbol 'sdmmc_idma_validate_data' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: linux-mmc@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-arm-kernel@lists.infradead.org
---
drivers/mmc/host/mmci_stm32_sdmmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/mmci_stm32_sdmmc.c b/drivers/mmc/host/mmci_stm32_sdmmc.c
index 8e83ae6920ae..296be8a060a6 100644
--- a/drivers/mmc/host/mmci_stm32_sdmmc.c
+++ b/drivers/mmc/host/mmci_stm32_sdmmc.c
@@ -25,8 +25,8 @@ struct sdmmc_priv {
void *sg_cpu;
};
-int sdmmc_idma_validate_data(struct mmci_host *host,
- struct mmc_data *data)
+static int sdmmc_idma_validate_data(struct mmci_host *host,
+ struct mmc_data *data)
{
struct scatterlist *sg;
int i;
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mmc: mmci: stm32: make sdmmc_idma_validate_data static
2019-10-09 11:54 [PATCH] mmc: mmci: stm32: make sdmmc_idma_validate_data static Ben Dooks
@ 2019-10-18 10:58 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2019-10-18 10:58 UTC (permalink / raw)
To: Ben Dooks
Cc: linux-kernel, Alexandre Torgue, linux-mmc, Maxime Coquelin,
linux-stm32, Linux ARM
On Wed, 9 Oct 2019 at 13:54, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>
> Make sdmmc_idma_validate_data to avoid the following warning
> from sparse:
>
> drivers/mmc/host/mmci_stm32_sdmmc.c:28:5: warning: symbol 'sdmmc_idma_validate_data' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Applied for next, thanks!
Kind regards
Uffe
> ---
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: linux-mmc@vger.kernel.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> drivers/mmc/host/mmci_stm32_sdmmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/mmci_stm32_sdmmc.c b/drivers/mmc/host/mmci_stm32_sdmmc.c
> index 8e83ae6920ae..296be8a060a6 100644
> --- a/drivers/mmc/host/mmci_stm32_sdmmc.c
> +++ b/drivers/mmc/host/mmci_stm32_sdmmc.c
> @@ -25,8 +25,8 @@ struct sdmmc_priv {
> void *sg_cpu;
> };
>
> -int sdmmc_idma_validate_data(struct mmci_host *host,
> - struct mmc_data *data)
> +static int sdmmc_idma_validate_data(struct mmci_host *host,
> + struct mmc_data *data)
> {
> struct scatterlist *sg;
> int i;
> --
> 2.23.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-18 10:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-09 11:54 [PATCH] mmc: mmci: stm32: make sdmmc_idma_validate_data static Ben Dooks
2019-10-18 10:58 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).