From: Ulf Hansson <ulf.hansson@linaro.org>
To: "Zulkifli, Muhammad Husaini" <muhammad.husaini.zulkifli@intel.com>
Cc: "Raja Subramanian,
Lakshmi Bai" <lakshmi.bai.raja.subramanian@intel.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>,
"David E. Box" <david.e.box@linux.intel.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay SOC
Date: Mon, 16 Nov 2020 12:41:08 +0100 [thread overview]
Message-ID: <CAPDyKFrq0Wsc7bNS0QPMitNqpkzK87VAuTnjDqrqTrVDGCwxgg@mail.gmail.com> (raw)
In-Reply-To: <20201106120933.7190-2-muhammad.husaini.zulkifli@intel.com>
On Fri, 6 Nov 2020 at 05:10, <muhammad.husaini.zulkifli@intel.com> wrote:
>
> From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
>
> Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations handling")
> introduces platform specific SDHCI clock operation.
>
> This patch declares the clock operation for Keem Bay.
> Add clk_ops for SD, EMMC and SDIO operations.
The above commit message doesn't really tell why or what goes on here.
Can please try to clarify that.
>
> Fixes: 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support for Intel Keem Bay")
Is $subject patch fixing a bug/regression?
Kind regards
Uffe
>
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
> Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-of-arasan.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index 829ccef87426..012d52e1abee 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -1199,16 +1199,19 @@ static struct sdhci_arasan_of_data sdhci_arasan_versal_data = {
> static struct sdhci_arasan_of_data intel_keembay_emmc_data = {
> .soc_ctl_map = &intel_keembay_soc_ctl_map,
> .pdata = &sdhci_keembay_emmc_pdata,
> + .clk_ops = &arasan_clk_ops,
> };
>
> static struct sdhci_arasan_of_data intel_keembay_sd_data = {
> .soc_ctl_map = &intel_keembay_soc_ctl_map,
> .pdata = &sdhci_keembay_sd_pdata,
> + .clk_ops = &arasan_clk_ops,
> };
>
> static struct sdhci_arasan_of_data intel_keembay_sdio_data = {
> .soc_ctl_map = &intel_keembay_soc_ctl_map,
> .pdata = &sdhci_keembay_sdio_pdata,
> + .clk_ops = &arasan_clk_ops,
> };
>
> static const struct of_device_id sdhci_arasan_of_match[] = {
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-16 12:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 12:09 [PATCH v1 0/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay SOC muhammad.husaini.zulkifli
2020-11-06 12:09 ` [PATCH v1 1/1] " muhammad.husaini.zulkifli
2020-11-16 11:41 ` Ulf Hansson [this message]
2020-11-16 14:22 ` Zulkifli, Muhammad Husaini
2020-11-17 11:27 ` Ulf Hansson
2020-11-17 13:46 ` Zulkifli, Muhammad Husaini
2020-11-17 17:14 ` Ulf Hansson
2020-11-18 1:04 ` Zulkifli, Muhammad Husaini
2020-11-12 14:15 ` [PATCH v1 0/1] " Zulkifli, Muhammad Husaini
[not found] ` <DM6PR11MB28767CEEAD0FA1E20614B797B8E60@DM6PR11MB2876.namprd11.prod.outlook.com>
2020-11-13 0:15 ` Zulkifli, Muhammad Husaini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFrq0Wsc7bNS0QPMitNqpkzK87VAuTnjDqrqTrVDGCwxgg@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=david.e.box@linux.intel.com \
--cc=lakshmi.bai.raja.subramanian@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=wan.ahmad.zainie.wan.mohamad@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).