From: Anson Huang <anson.huang@nxp.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
Abel Vesa <abel.vesa@nxp.com>,
"ccaione@baylibre.com" <ccaione@baylibre.com>,
"angus@akkea.ca" <angus@akkea.ca>,
"andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>,
"agx@sigxcpu.org" <agx@sigxcpu.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Cc: dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH RESEND V2 2/3] clocksource: imx-sysctr: Make timer work with clock driver using platform driver model
Date: Thu, 27 Jun 2019 12:49:17 +0000 [thread overview]
Message-ID: <DB3PR0402MB3916A7348E71A33E4746D5FAF5FD0@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <41ab1a50-f431-ec73-8444-11ecca1412d8@linaro.org>
Hi, Daniel
> On 23/06/2019 14:38, Anson.Huang@nxp.com wrote:
> > From: Anson Huang <Anson.Huang@nxp.com>
> >
> > On some i.MX8M platforms, clock driver uses platform driver model and
> > it is NOT ready during timer initialization phase, the clock
> > operations will fail and system counter driver will fail too. As all
> > the i.MX8M platforms' system counter clock are from OSC which is
> > always enabled, so it is no need to enable clock for system counter
> > driver, the ONLY thing is to pass clock frequence to driver.
> >
> > To make system counter driver work for upper scenario, add an option
> > of skipping of_clk operation for system counter driver, an optional
> > property "clock-frequency" is introduced to pass the frequency value
> > to system counter driver and indicate driver to skip of_clk
> > operations.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> > Changes since V1:
> > - improve commit log, no content change.
> > ---
> > drivers/clocksource/timer-imx-sysctr.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/clocksource/timer-imx-sysctr.c
> > b/drivers/clocksource/timer-imx-sysctr.c
> > index fd7d680..8ff3d7e 100644
> > --- a/drivers/clocksource/timer-imx-sysctr.c
> > +++ b/drivers/clocksource/timer-imx-sysctr.c
> > @@ -129,6 +129,14 @@ static void __init sysctr_clockevent_init(void)
> > static int __init sysctr_timer_init(struct device_node *np) {
> > int ret = 0;
> > + u32 rate;
> > +
> > + if (!of_property_read_u32(np, "clock-frequency",
> > + &rate)) {
> > + to_sysctr.of_clk.rate = rate;
> > + to_sysctr.of_clk.period = DIV_ROUND_UP(rate, HZ);
> > + to_sysctr.flags &= ~TIMER_OF_CLOCK;
> > + }
>
> Please take the opportunity to add the TIMER_OF_CLOCK_FREQUENCY flag in
> timer-of and the corresponding code above.
OK, so another patch for timer-of is necessary, if TIMER_OF_CLOCK_FREQUENCY flag
is present, just read the "clock-frequency" from DT instead of getting clock rate from
clock tree, right? I think this becomes a common case for timer driver, as more and more
platforms will use platform driver model for clock driver, it would be good if timer-of can
provide solution.
>
> Then check the clock-frequency presence and add TIMER_OF_CLOCK or
> TIMER_OF_CLOCK_FREQUENCY flag to the timer-of structure.
>
> eg:
>
> to_sysctr.flags |= of_find_property(np, "clock-frequency", NULL) ?
> TIMER_OF_CLOCK_FREQUENCY : TIMER_OF_CLOCK;
>
OK.
Thanks,
Anson.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-27 12:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-23 12:38 [PATCH RESEND V2 1/3] clocksource/drivers/sysctr: Add optional clock-frequency property Anson.Huang
2019-06-23 12:38 ` [PATCH RESEND V2 2/3] clocksource: imx-sysctr: Make timer work with clock driver using platform driver model Anson.Huang
2019-06-27 12:36 ` Daniel Lezcano
2019-06-27 12:49 ` Anson Huang [this message]
2019-06-23 12:38 ` [PATCH RESEND V2 3/3] arm64: dts: imx8mq: Add system counter node Anson.Huang
2019-06-25 21:12 ` [PATCH RESEND V2 1/3] clocksource/drivers/sysctr: Add optional clock-frequency property Daniel Lezcano
2019-06-26 1:42 ` Anson Huang
2019-06-26 10:37 ` Daniel Lezcano
2019-06-27 0:43 ` Anson Huang
2019-06-27 8:07 ` Daniel Lezcano
2019-06-27 8:11 ` Anson Huang
2019-06-27 10:27 ` Daniel Lezcano
2019-06-27 10:34 ` Daniel Lezcano
2019-06-27 13:11 ` Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0402MB3916A7348E71A33E4746D5FAF5FD0@DB3PR0402MB3916.eurprd04.prod.outlook.com \
--to=anson.huang@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=agx@sigxcpu.org \
--cc=andrew.smirnov@gmail.com \
--cc=angus@akkea.ca \
--cc=ccaione@baylibre.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).