From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Anson.Huang@nxp.com, tglx@linutronix.de, robh+dt@kernel.org,
mark.rutland@arm.com, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, l.stach@pengutronix.de, abel.vesa@nxp.com,
ccaione@baylibre.com, angus@akkea.ca, andrew.smirnov@gmail.com,
agx@sigxcpu.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Linux-imx@nxp.com
Subject: Re: [PATCH RESEND V2 1/3] clocksource/drivers/sysctr: Add optional clock-frequency property
Date: Thu, 27 Jun 2019 12:34:19 +0200 [thread overview]
Message-ID: <bb362db6-9c50-5d2c-349a-4097dea0449f@linaro.org> (raw)
In-Reply-To: <20190623123850.22584-1-Anson.Huang@nxp.com>
On 23/06/2019 14:38, Anson.Huang@nxp.com wrote:
> From: Anson Huang <Anson.Huang@nxp.com>
>
> Systems which use platform driver model for clock driver require the
> clock frequency to be supplied via device tree when system counter
> driver is enabled.
>
> This is necessary as in the platform driver model the of_clk operations
> do not work correctly because system counter driver is initialized in
> early phase of system boot up, and clock driver using platform driver
> model is NOT ready at that time, it will cause system counter driver
> initialization failed.
>
> Add the optinal clock-frequency to the device tree bindings of the NXP
> system counter, so the frequency can be handed in and the of_clk
> operations can be skipped.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> Changes since V1:
> - improve commit log, no content change.
> ---
> Documentation/devicetree/bindings/timer/nxp,sysctr-timer.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/timer/nxp,sysctr-timer.txt b/Documentation/devicetree/bindings/timer/nxp,sysctr-timer.txt
> index d576599..c9907a0 100644
> --- a/Documentation/devicetree/bindings/timer/nxp,sysctr-timer.txt
> +++ b/Documentation/devicetree/bindings/timer/nxp,sysctr-timer.txt
> @@ -14,6 +14,11 @@ Required properties:
> - clocks : Specifies the counter clock.
> - clock-names: Specifies the clock's name of this module
>
> +Optional properties:
> +
> +- clock-frequency : Specifies system counter clock frequency and indicates system
> + counter driver to skip clock operations.
> +
Shouldn't it be required and mutually exclusive with clocks/clock-names?
> Example:
>
> system_counter: timer@306a0000 {
> @@ -22,4 +27,5 @@ Example:
> clocks = <&clk_8m>;
> clock-names = "per";
> interrupts = <GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>;
> + clock-frequency = <8333333>;
> };
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-27 10:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-23 12:38 [PATCH RESEND V2 1/3] clocksource/drivers/sysctr: Add optional clock-frequency property Anson.Huang
2019-06-23 12:38 ` [PATCH RESEND V2 2/3] clocksource: imx-sysctr: Make timer work with clock driver using platform driver model Anson.Huang
2019-06-27 12:36 ` Daniel Lezcano
2019-06-27 12:49 ` Anson Huang
2019-06-23 12:38 ` [PATCH RESEND V2 3/3] arm64: dts: imx8mq: Add system counter node Anson.Huang
2019-06-25 21:12 ` [PATCH RESEND V2 1/3] clocksource/drivers/sysctr: Add optional clock-frequency property Daniel Lezcano
2019-06-26 1:42 ` Anson Huang
2019-06-26 10:37 ` Daniel Lezcano
2019-06-27 0:43 ` Anson Huang
2019-06-27 8:07 ` Daniel Lezcano
2019-06-27 8:11 ` Anson Huang
2019-06-27 10:27 ` Daniel Lezcano
2019-06-27 10:34 ` Daniel Lezcano [this message]
2019-06-27 13:11 ` Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb362db6-9c50-5d2c-349a-4097dea0449f@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=agx@sigxcpu.org \
--cc=andrew.smirnov@gmail.com \
--cc=angus@akkea.ca \
--cc=ccaione@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).