RE: [PATCH V9 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding

[Anson Huang <anson.huang@nxp.com>]

Hi, Rob

Best Regards!
Anson Huang

> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: 2019年3月26日 4:42
> To: Anson Huang <anson.huang@nxp.com>
> Cc: thierry.reding@gmail.com; mark.rutland@arm.com;
> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
> festevam@gmail.com; linux@armlinux.org.uk; stefan@agner.ch;
> otavio@ossystems.com.br; Leonard Crestez <leonard.crestez@nxp.com>;
> Robin Gong <yibin.gong@nxp.com>; jan.tuerk@emtrion.com; linux-
> pwm@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; u.kleine-
> koenig@pengutronix.de; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH V9 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding
> 
> On Fri, Mar 22, 2019 at 01:48:05AM +0000, Anson Huang wrote:
> > Add i.MX TPM(Low Power Timer/Pulse Width Modulation Module) PWM
> binding.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> > No changes.
> 
> v9? I don't recall seeing any previous versions.

I checked my mailbox, you are in the "to" list in every version. The first version's subject is:
[PATCH 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding...

> 
> > ---
> >  .../devicetree/bindings/pwm/imx-tpm-pwm.txt        | 22
> ++++++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
> >
> > diff --git a/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
> > b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
> > new file mode 100644
> > index 0000000..94f1ad5
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
> > @@ -0,0 +1,22 @@
> > +Freescale i.MX TPM PWM controller
> > +
> > +Required properties:
> > +- compatible : Should be "fsl,imx-tpm".
> 
> Needs to be SoC specific.

OK, will change it to "fsl,imx7ulp-tpm" in next verson.

> 
> > +- reg: Physical base address and length of the controller's registers.
> > +- #pwm-cells: Should be 3. See pwm.txt in this directory for a description
> of the cells format.
> > +- clocks : The clock provided by the SoC to drive the PWM.
> > +- interrupts: The interrupt for the PWM controller.
> > +
> > +Note: The TPM counter and period counter are shared between multiple
> > +channels, so all channels should use same period setting.
> > +
> > +Example:
> > +
> > +pwm0: tpm@40250000 {
> 
> pwm@...

I forgot to update the example in DT binding, sorry for that, will update it according to
below dts node:

                 pwm0: pwm@40250000 {

Anson.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel