From: Anson Huang <anson.huang@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
Robin Gong <yibin.gong@nxp.com>,
"otavio@ossystems.com.br" <otavio@ossystems.com.br>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"jan.tuerk@emtrion.com" <jan.tuerk@emtrion.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"stefan@agner.ch" <stefan@agner.ch>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
Leonard Crestez <leonard.crestez@nxp.com>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH V9 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding
Date: Tue, 26 Mar 2019 06:53:33 +0000 [thread overview]
Message-ID: <DB3PR0402MB3916C72A8FE827F965627E91F55F0@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <DB3PR0402MB3916B84081393C46609FD178F55F0@DB3PR0402MB3916.eurprd04.prod.outlook.com>
Hi, Rob
Best Regards!
Anson Huang
> -----Original Message-----
> From: Anson Huang
> Sent: 2019年3月26日 8:56
> To: 'Rob Herring' <robh@kernel.org>
> Cc: thierry.reding@gmail.com; mark.rutland@arm.com;
> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
> festevam@gmail.com; linux@armlinux.org.uk; stefan@agner.ch;
> otavio@ossystems.com.br; Leonard Crestez <leonard.crestez@nxp.com>;
> Robin Gong <yibin.gong@nxp.com>; jan.tuerk@emtrion.com; linux-
> pwm@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; u.kleine-
> koenig@pengutronix.de; dl-linux-imx <linux-imx@nxp.com>
> Subject: RE: [PATCH V9 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding
>
> Hi, Rob
>
> Best Regards!
> Anson Huang
>
> > -----Original Message-----
> > From: Rob Herring [mailto:robh@kernel.org]
> > Sent: 2019年3月26日 4:42
> > To: Anson Huang <anson.huang@nxp.com>
> > Cc: thierry.reding@gmail.com; mark.rutland@arm.com;
> > shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
> > festevam@gmail.com; linux@armlinux.org.uk; stefan@agner.ch;
> > otavio@ossystems.com.br; Leonard Crestez <leonard.crestez@nxp.com>;
> > Robin Gong <yibin.gong@nxp.com>; jan.tuerk@emtrion.com; linux-
> > pwm@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
> > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; u.kleine-
> > koenig@pengutronix.de; dl-linux-imx <linux-imx@nxp.com>
> > Subject: Re: [PATCH V9 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding
> >
> > On Fri, Mar 22, 2019 at 01:48:05AM +0000, Anson Huang wrote:
> > > Add i.MX TPM(Low Power Timer/Pulse Width Modulation Module) PWM
> > binding.
> > >
> > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > > ---
> > > No changes.
> >
> > v9? I don't recall seeing any previous versions.
>
> I checked my mailbox, you are in the "to" list in every version. The first
> version's subject is:
> [PATCH 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding...
>
> >
> > > ---
> > > .../devicetree/bindings/pwm/imx-tpm-pwm.txt | 22
> > ++++++++++++++++++++++
> > > 1 file changed, 22 insertions(+)
> > > create mode 100644
> > > Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
> > > b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
> > > new file mode 100644
> > > index 0000000..94f1ad5
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
> > > @@ -0,0 +1,22 @@
> > > +Freescale i.MX TPM PWM controller
> > > +
> > > +Required properties:
> > > +- compatible : Should be "fsl,imx-tpm".
> >
> > Needs to be SoC specific.
>
> OK, will change it to "fsl,imx7ulp-tpm" in next verson.
As " fsl,imx7ulp-tpm " is already used for timer, TPM can work as a timer
or PWM, so I have to use " fsl,imx7ulp-pwm" in the V10 patch I just sent.
Anson.
>
> >
> > > +- reg: Physical base address and length of the controller's registers.
> > > +- #pwm-cells: Should be 3. See pwm.txt in this directory for a
> > > +description
> > of the cells format.
> > > +- clocks : The clock provided by the SoC to drive the PWM.
> > > +- interrupts: The interrupt for the PWM controller.
> > > +
> > > +Note: The TPM counter and period counter are shared between
> > > +multiple channels, so all channels should use same period setting.
> > > +
> > > +Example:
> > > +
> > > +pwm0: tpm@40250000 {
> >
> > pwm@...
>
> I forgot to update the example in DT binding, sorry for that, will update it
> according to below dts node:
>
> pwm0: pwm@40250000 {
>
> Anson.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-26 6:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 1:47 [PATCH V9 0/5] Add i.MX7ULP EVK PWM backlight support Anson Huang
2019-03-22 1:48 ` [PATCH V9 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding Anson Huang
2019-03-25 20:41 ` Rob Herring
2019-03-25 20:59 ` Uwe Kleine-König
2019-03-26 18:51 ` Rob Herring
2019-03-26 0:56 ` Anson Huang
2019-03-26 6:53 ` Anson Huang [this message]
2019-03-22 1:48 ` [PATCH V9 2/5] pwm: Add i.MX TPM PWM driver support Anson Huang
2019-03-25 9:30 ` Uwe Kleine-König
2019-03-25 11:58 ` Anson Huang
2019-03-26 6:56 ` Anson Huang
2019-03-22 1:48 ` [PATCH V9 3/5] ARM: imx_v6_v7_defconfig: Add TPM PWM support by default Anson Huang
2019-03-22 1:48 ` [PATCH V9 4/5] ARM: dts: imx7ulp: Add pwm0 support Anson Huang
2019-03-22 1:48 ` [PATCH V9 5/5] ARM: dts: imx7ulp-evk: Add backlight support Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0402MB3916C72A8FE827F965627E91F55F0@DB3PR0402MB3916.eurprd04.prod.outlook.com \
--to=anson.huang@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jan.tuerk@emtrion.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=otavio@ossystems.com.br \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).