From: Aisheng Dong <aisheng.dong@nxp.com>
To: Jing Xiangfeng <jingxiangfeng@huawei.com>,
Frank Li <frank.li@nxp.com>, "will@kernel.org" <will@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] drivers/perf: fix the missed ida_simple_remove() in ddr_perf_probe()
Date: Thu, 17 Jun 2021 12:24:12 +0000 [thread overview]
Message-ID: <DB9PR04MB84777974EF797DA08E9DFD6F800E9@DB9PR04MB8477.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20210617122614.166823-1-jingxiangfeng@huawei.com>
> From: Jing Xiangfeng <jingxiangfeng@huawei.com>
> Sent: Thursday, June 17, 2021 8:26 PM
> Subject: [PATCH] drivers/perf: fix the missed ida_simple_remove() in
> ddr_perf_probe()
>
drivers/perf: imx8_ddr: xxxx
Otherwise:
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Regards
Aisheng
> ddr_perf_probe() misses to call ida_simple_remove() in an error path.
> Jump to cpuhp_state_err to fix it.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> ---
> drivers/perf/fsl_imx8_ddr_perf.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/perf/fsl_imx8_ddr_perf.c b/drivers/perf/fsl_imx8_ddr_perf.c
> index 2bbb93188064..7b87aaf267d5 100644
> --- a/drivers/perf/fsl_imx8_ddr_perf.c
> +++ b/drivers/perf/fsl_imx8_ddr_perf.c
> @@ -705,8 +705,10 @@ static int ddr_perf_probe(struct platform_device
> *pdev)
>
> name = devm_kasprintf(&pdev->dev, GFP_KERNEL,
> DDR_PERF_DEV_NAME "%d",
> num);
> - if (!name)
> - return -ENOMEM;
> + if (!name) {
> + ret = -ENOMEM;
> + goto cpuhp_state_err;
> + }
>
> pmu->devtype_data = of_device_get_match_data(&pdev->dev);
>
> --
> 2.26.0.106.g9fadedd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-17 12:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 12:26 [PATCH] drivers/perf: fix the missed ida_simple_remove() in ddr_perf_probe() Jing Xiangfeng
2021-06-17 12:24 ` Aisheng Dong [this message]
2021-06-17 22:38 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB9PR04MB84777974EF797DA08E9DFD6F800E9@DB9PR04MB8477.eurprd04.prod.outlook.com \
--to=aisheng.dong@nxp.com \
--cc=festevam@gmail.com \
--cc=frank.li@nxp.com \
--cc=jingxiangfeng@huawei.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).