linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: lx2160a-clearfog-itx: add SFP support  [*experimental*]
@ 2021-03-09 16:36 Russell King
  2021-03-15  7:03 ` Shawn Guo
  0 siblings, 1 reply; 4+ messages in thread
From: Russell King @ 2021-03-09 16:36 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Li Yang, Rob Herring, linux-arm-kernel, devicetree, Jon Nettleton

Add 2x2 SFP+ cage support for clearfog-itx boards.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 .../boot/dts/freescale/fsl-lx2160a-cex7.dtsi  | 24 +++++++
 .../freescale/fsl-lx2160a-clearfog-itx.dtsi   | 64 +++++++++++++++++++
 2 files changed, 88 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
index 459dccad8326..afb455210bd0 100644
--- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
@@ -122,6 +122,30 @@
 				vcc-supply = <&sb_3v3>;
 			};
 		};
+
+		sfp0_i2c: i2c@4 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <4>;
+		};
+
+		sfp1_i2c: i2c@5 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <5>;
+		};
+
+		sfp2_i2c: i2c@6 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <6>;
+		};
+
+		sfp3_i2c: i2c@7 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <7>;
+		};
 	};
 };
 
diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
index 2b63235ca627..17f8e733972a 100644
--- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
@@ -30,6 +30,54 @@
 			gpios = <&gpio2 6 GPIO_ACTIVE_LOW>;
 		};
 	};
+
+	sfp0: sfp-0 {
+		compatible = "sff,sfp";
+		i2c-bus = <&sfp0_i2c>;
+		mod-def0-gpio = <&gpio2 0 GPIO_ACTIVE_LOW>;
+		maximum-power-milliwatt = <2000>;
+	};
+
+	sfp1: sfp-1 {
+		compatible = "sff,sfp";
+		i2c-bus = <&sfp1_i2c>;
+		mod-def0-gpio = <&gpio2 9 GPIO_ACTIVE_LOW>;
+		maximum-power-milliwatt = <2000>;
+	};
+
+	sfp2: sfp-2 {
+		compatible = "sff,sfp";
+		i2c-bus = <&sfp2_i2c>;
+		mod-def0-gpio = <&gpio2 10 GPIO_ACTIVE_LOW>;
+		maximum-power-milliwatt = <2000>;
+	};
+
+	sfp3: sfp-3 {
+		compatible = "sff,sfp";
+		i2c-bus = <&sfp3_i2c>;
+		mod-def0-gpio = <&gpio2 11 GPIO_ACTIVE_LOW>;
+		maximum-power-milliwatt = <2000>;
+	};
+};
+
+&dpmac7 {
+	sfp = <&sfp0>;
+	managed = "in-band-status";
+};
+
+&dpmac8 {
+	sfp = <&sfp1>;
+	managed = "in-band-status";
+};
+
+&dpmac9 {
+	sfp = <&sfp2>;
+	managed = "in-band-status";
+};
+
+&dpmac10 {
+	sfp = <&sfp3>;
+	managed = "in-band-status";
 };
 
 &emdio2 {
@@ -44,6 +92,22 @@
 	status = "okay";
 };
 
+&pcs_mdio7 {
+	status = "okay";
+};
+
+&pcs_mdio8 {
+	status = "okay";
+};
+
+&pcs_mdio9 {
+	status = "okay";
+};
+
+&pcs_mdio10 {
+	status = "okay";
+};
+
 &sata0 {
 	status = "okay";
 };
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: lx2160a-clearfog-itx: add SFP support [*experimental*]
  2021-03-09 16:36 [PATCH] arm64: dts: lx2160a-clearfog-itx: add SFP support [*experimental*] Russell King
@ 2021-03-15  7:03 ` Shawn Guo
  2021-03-15 10:02   ` Russell King - ARM Linux admin
  0 siblings, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2021-03-15  7:03 UTC (permalink / raw)
  To: Russell King
  Cc: Li Yang, Rob Herring, linux-arm-kernel, devicetree, Jon Nettleton

On Tue, Mar 09, 2021 at 04:36:58PM +0000, Russell King wrote:
> Add 2x2 SFP+ cage support for clearfog-itx boards.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

What is the implication of [*experimental*] in subject?

Shawn

> ---
>  .../boot/dts/freescale/fsl-lx2160a-cex7.dtsi  | 24 +++++++
>  .../freescale/fsl-lx2160a-clearfog-itx.dtsi   | 64 +++++++++++++++++++
>  2 files changed, 88 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> index 459dccad8326..afb455210bd0 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> @@ -122,6 +122,30 @@
>  				vcc-supply = <&sb_3v3>;
>  			};
>  		};
> +
> +		sfp0_i2c: i2c@4 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <4>;
> +		};
> +
> +		sfp1_i2c: i2c@5 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <5>;
> +		};
> +
> +		sfp2_i2c: i2c@6 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <6>;
> +		};
> +
> +		sfp3_i2c: i2c@7 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <7>;
> +		};
>  	};
>  };
>  
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
> index 2b63235ca627..17f8e733972a 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
> @@ -30,6 +30,54 @@
>  			gpios = <&gpio2 6 GPIO_ACTIVE_LOW>;
>  		};
>  	};
> +
> +	sfp0: sfp-0 {
> +		compatible = "sff,sfp";
> +		i2c-bus = <&sfp0_i2c>;
> +		mod-def0-gpio = <&gpio2 0 GPIO_ACTIVE_LOW>;
> +		maximum-power-milliwatt = <2000>;
> +	};
> +
> +	sfp1: sfp-1 {
> +		compatible = "sff,sfp";
> +		i2c-bus = <&sfp1_i2c>;
> +		mod-def0-gpio = <&gpio2 9 GPIO_ACTIVE_LOW>;
> +		maximum-power-milliwatt = <2000>;
> +	};
> +
> +	sfp2: sfp-2 {
> +		compatible = "sff,sfp";
> +		i2c-bus = <&sfp2_i2c>;
> +		mod-def0-gpio = <&gpio2 10 GPIO_ACTIVE_LOW>;
> +		maximum-power-milliwatt = <2000>;
> +	};
> +
> +	sfp3: sfp-3 {
> +		compatible = "sff,sfp";
> +		i2c-bus = <&sfp3_i2c>;
> +		mod-def0-gpio = <&gpio2 11 GPIO_ACTIVE_LOW>;
> +		maximum-power-milliwatt = <2000>;
> +	};
> +};
> +
> +&dpmac7 {
> +	sfp = <&sfp0>;
> +	managed = "in-band-status";
> +};
> +
> +&dpmac8 {
> +	sfp = <&sfp1>;
> +	managed = "in-band-status";
> +};
> +
> +&dpmac9 {
> +	sfp = <&sfp2>;
> +	managed = "in-band-status";
> +};
> +
> +&dpmac10 {
> +	sfp = <&sfp3>;
> +	managed = "in-band-status";
>  };
>  
>  &emdio2 {
> @@ -44,6 +92,22 @@
>  	status = "okay";
>  };
>  
> +&pcs_mdio7 {
> +	status = "okay";
> +};
> +
> +&pcs_mdio8 {
> +	status = "okay";
> +};
> +
> +&pcs_mdio9 {
> +	status = "okay";
> +};
> +
> +&pcs_mdio10 {
> +	status = "okay";
> +};
> +
>  &sata0 {
>  	status = "okay";
>  };
> -- 
> 2.20.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: lx2160a-clearfog-itx: add SFP support [*experimental*]
  2021-03-15  7:03 ` Shawn Guo
@ 2021-03-15 10:02   ` Russell King - ARM Linux admin
  2021-03-17  7:55     ` Shawn Guo
  0 siblings, 1 reply; 4+ messages in thread
From: Russell King - ARM Linux admin @ 2021-03-15 10:02 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Li Yang, Rob Herring, linux-arm-kernel, devicetree, Jon Nettleton

On Mon, Mar 15, 2021 at 03:03:15PM +0800, Shawn Guo wrote:
> On Tue, Mar 09, 2021 at 04:36:58PM +0000, Russell King wrote:
> > Add 2x2 SFP+ cage support for clearfog-itx boards.
> > 
> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> 
> What is the implication of [*experimental*] in subject?

Oh, I should've dropped that, thanks for pointing it out.

It was experimental as we didn't know which direction NXP were heading
with the PCS support on the LX2160A until it was finally merged into
net-next.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: lx2160a-clearfog-itx: add SFP support [*experimental*]
  2021-03-15 10:02   ` Russell King - ARM Linux admin
@ 2021-03-17  7:55     ` Shawn Guo
  0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2021-03-17  7:55 UTC (permalink / raw)
  To: Russell King - ARM Linux admin
  Cc: Li Yang, Rob Herring, linux-arm-kernel, devicetree, Jon Nettleton

On Mon, Mar 15, 2021 at 10:02:07AM +0000, Russell King - ARM Linux admin wrote:
> On Mon, Mar 15, 2021 at 03:03:15PM +0800, Shawn Guo wrote:
> > On Tue, Mar 09, 2021 at 04:36:58PM +0000, Russell King wrote:
> > > Add 2x2 SFP+ cage support for clearfog-itx boards.
> > > 
> > > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> > 
> > What is the implication of [*experimental*] in subject?
> 
> Oh, I should've dropped that, thanks for pointing it out.
> 
> It was experimental as we didn't know which direction NXP were heading
> with the PCS support on the LX2160A until it was finally merged into
> net-next.

Fixed it up and applied, thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-17  7:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-09 16:36 [PATCH] arm64: dts: lx2160a-clearfog-itx: add SFP support [*experimental*] Russell King
2021-03-15  7:03 ` Shawn Guo
2021-03-15 10:02   ` Russell King - ARM Linux admin
2021-03-17  7:55     ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).