From: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
To: Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Rob Herring <robh+dt@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux API <linux-api@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Phil Edworthy <phil.edworthy@renesas.com>,
"REE dirk.behme@de.bosch.com" <dirk.behme@de.bosch.com>,
Peter Erben <Peter.Erben@de.bosch.com>
Subject: RE: [PATCH 1/7] clk: renesas: r8a77990: Add DAB clock
Date: Wed, 3 Mar 2021 10:22:34 +0000 [thread overview]
Message-ID: <OSAPR01MB27379B9046FB5B4F4214B0E2C2989@OSAPR01MB2737.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <OSAPR01MB27376625ABDAEDA41BA00E5CC29A9@OSAPR01MB2737.jpnprd01.prod.outlook.com>
Hi Geert,
> From: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> Sent: 01 March 2021 14:47
> Subject: RE: [PATCH 1/7] clk: renesas: r8a77990: Add DAB clock
>
> Hi Geert,
>
> Thanks for your feedback!
>
> > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > Sent: 26 February 2021 08:35
> > Subject: Re: [PATCH 1/7] clk: renesas: r8a77990: Add DAB clock
> >
> > Hi Fabrizio,
> >
> > On Thu, Feb 25, 2021 at 11:52 PM Fabrizio Castro
> > <fabrizio.castro.jz@renesas.com> wrote:
> > > This patch adds the DAB clock to the R8A77990 SoC.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> >
> > Thanks for your patch!
> >
> > > --- a/drivers/clk/renesas/r8a77990-cpg-mssr.c
> > > +++ b/drivers/clk/renesas/r8a77990-cpg-mssr.c
> > > @@ -232,6 +232,7 @@ static const struct mssr_mod_clk
> r8a77990_mod_clks[]
> > __initconst = {
> > > DEF_MOD("ssi2", 1013, MOD_CLK_ID(1005)),
> > > DEF_MOD("ssi1", 1014, MOD_CLK_ID(1005)),
> > > DEF_MOD("ssi0", 1015, MOD_CLK_ID(1005)),
> > > + DEF_MOD("dab", 1016, R8A77990_CLK_S3D1),
> >
> > Unfortunately this bit is not documented in the R-Car Gen3 Hardware
> > User's Manual, so I have to trust you on this.
>
> Yeah, unfortunately there is no official document with this information
> as of yet.
I think this patch is worth taking.
Thanks,
Fab
>
> Cheers,
> Fab
>
> >
> > > DEF_MOD("scu-all", 1017, R8A77990_CLK_S3D4),
> > > DEF_MOD("scu-dvc1", 1018, MOD_CLK_ID(1017)),
> > > DEF_MOD("scu-dvc0", 1019, MOD_CLK_ID(1017)),
> >
> > Gr{oetje,eeting}s,
> >
> > Geert
> >
> > --
> > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> > m68k.org
> >
> > In personal conversations with technical people, I call myself a hacker.
> > But
> > when I'm talking to journalists I just say "programmer" or something
> like
> > that.
> > -- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-03 14:44 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 22:51 [PATCH 0/7] Add FFT Support for R-Car Gen3 devices Fabrizio Castro
2021-02-25 22:51 ` [PATCH 1/7] clk: renesas: r8a77990: Add DAB clock Fabrizio Castro
2021-02-26 8:34 ` Geert Uytterhoeven
2021-03-01 14:47 ` Fabrizio Castro
2021-03-03 10:22 ` Fabrizio Castro [this message]
2021-02-25 22:51 ` [PATCH 2/7] clk: renesas: r8a77965: " Fabrizio Castro
2021-02-26 8:45 ` Geert Uytterhoeven
2021-02-26 12:48 ` Laurent Pinchart
2021-03-01 15:01 ` Fabrizio Castro
2021-03-03 10:23 ` Fabrizio Castro
2021-03-01 14:58 ` Fabrizio Castro
2021-02-25 22:51 ` [PATCH 3/7] dt-bindings: misc: Add binding for R-Car DAB Fabrizio Castro
2021-02-26 8:41 ` Geert Uytterhoeven
2021-03-01 15:10 ` Fabrizio Castro
2021-02-26 9:06 ` Sergei Shtylyov
2021-03-01 15:11 ` Fabrizio Castro
2021-02-26 13:01 ` Laurent Pinchart
2021-03-01 15:13 ` Fabrizio Castro
2021-02-25 22:51 ` [PATCH 4/7] misc: Add driver for DAB IP found on Renesas R-Car devices Fabrizio Castro
2021-02-26 9:34 ` Geert Uytterhoeven
2021-03-01 16:19 ` Fabrizio Castro
2021-02-26 10:37 ` Arnd Bergmann
2021-02-26 13:05 ` Laurent Pinchart
2021-03-01 17:54 ` Fabrizio Castro
2021-03-01 17:26 ` Fabrizio Castro
2021-03-02 11:16 ` Ezequiel Garcia
2021-03-02 12:20 ` Fabrizio Castro
2021-03-02 12:32 ` Laurent Pinchart
2021-03-03 10:20 ` Fabrizio Castro
2021-03-03 10:26 ` Geert Uytterhoeven
2021-03-03 10:43 ` Fabrizio Castro
2021-02-25 22:51 ` [PATCH 5/7] arm64: dts: renesas: r8a77990: Add DAB support Fabrizio Castro
2021-02-26 9:37 ` Geert Uytterhoeven
2021-03-01 14:51 ` Fabrizio Castro
2021-02-26 12:47 ` Laurent Pinchart
2021-03-01 14:53 ` Fabrizio Castro
2021-02-25 22:51 ` [PATCH 6/7] arm64: dts: renesas: r8a77965: " Fabrizio Castro
2021-02-26 9:37 ` Geert Uytterhoeven
2021-03-01 14:54 ` Fabrizio Castro
2021-02-26 12:47 ` Laurent Pinchart
2021-03-01 14:55 ` Fabrizio Castro
2021-02-25 22:51 ` [PATCH 7/7] arm64: configs: Add R-Car " Fabrizio Castro
2021-02-26 12:52 ` Laurent Pinchart
2021-02-26 13:05 ` Geert Uytterhoeven
2021-02-26 12:20 ` [PATCH 0/7] Add FFT Support for R-Car Gen3 devices Laurent Pinchart
2021-03-01 14:50 ` Fabrizio Castro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSAPR01MB27379B9046FB5B4F4214B0E2C2989@OSAPR01MB2737.jpnprd01.prod.outlook.com \
--to=fabrizio.castro.jz@renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=Peter.Erben@de.bosch.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dirk.behme@de.bosch.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=phil.edworthy@renesas.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).