RE: [PATCH 3/7] dt-bindings: misc: Add binding for R-Car DAB

From: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
To: Sergei Shtylyov <sergei.shtylyov@gmail.com>,
	Rob Herring <robh+dt@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Phil Edworthy <phil.edworthy@renesas.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Peter Erben <Peter.Erben@de.bosch.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	"REE dirk.behme@de.bosch.com" <dirk.behme@de.bosch.com>,
	"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
	Will Deacon <will@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 3/7] dt-bindings: misc: Add binding for R-Car DAB
Date: Mon, 1 Mar 2021 15:11:42 +0000	[thread overview]
Message-ID: <OSAPR01MB27379DB2150F87B1EFB34BEEC29A9@OSAPR01MB2737.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <c907737b-dffd-e5f3-6e4f-2e8a7781bc95@gmail.com>

Hello Sergei,

Thanks for your feedback!

> From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
> Sent: 26 February 2021 09:07
> Subject: Re: [PATCH 3/7] dt-bindings: misc: Add binding for R-Car DAB
> 
> Hello!
> 
> On 26.02.2021 1:51, Fabrizio Castro wrote:
> 
> > Document bindings for R-Car DAB hardware accelerator, currently
> > found on the r8a77990 SoC (a.k.a. R-Car E3) and on the r8a77965
> > SoC (a.k.a. R-Car M3-N).
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> > ---
> >   .../devicetree/bindings/misc/renesas,dab.yaml | 75 +++++++++++++++++++
> >   1 file changed, 75 insertions(+)
> >   create mode 100644
> Documentation/devicetree/bindings/misc/renesas,dab.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/misc/renesas,dab.yaml
> b/Documentation/devicetree/bindings/misc/renesas,dab.yaml
> > new file mode 100644
> > index 000000000000..e9494add13d7
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/misc/renesas,dab.yaml
> > @@ -0,0 +1,75 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +# Copyright (C) 2021 Renesas Electronics Corporation
> > +%YAML 1.2
> > +---
> > +$id:
> https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetre
> e.org%2Fschemas%2Fmisc%2Frenesas%2Cdab.yaml%23&amp;data=04%7C01%7Cfabrizio
> .castro.jz%40renesas.com%7C4ea11a8f46fc4f4642ad08d8da35d682%7C53d82571da19
> 47e49cb4625a166a4a2a%7C0%7C0%7C637499272091083125%7CUnknown%7CTWFpbGZsb3d8
> eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&
> amp;sdata=p5MNncCLOIMaYLyBtmOl%2Br%2BIKe9ByUqxv1k05FbYj94%3D&amp;reserved=
> 0
> > +$schema:
> https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetre
> e.org%2Fmeta-
> schemas%2Fcore.yaml%23&amp;data=04%7C01%7Cfabrizio.castro.jz%40renesas.com
> %7C4ea11a8f46fc4f4642ad08d8da35d682%7C53d82571da1947e49cb4625a166a4a2a%7C0
> %7C0%7C637499272091083125%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQ
> IjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=dBI8WMPjxAEvhY
> 3cj7WKJW4FjCrfN5JpAoqC9XSPNaY%3D&amp;reserved=0
> > +
> > +title: Renesas R-Car DAB Hardware Accelerator
> > +
> > +maintainers:
> > +  - Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> > +
> > +description:
> > +  The DAB hardware accelerator found on some R-Car devices is a
> hardware
> > +  accelerator for software DAB demodulators.
> > +  It consists of one FFT (Fast Fourier Transform) module and one
> decoder module,
> > +  compatible with DAB specification (ETSI EN 300 401 and ETSI TS 102
> 563).
> > +  The decoder module can perform FIC decoding and MSC decoding
> processing from
> > +  de-puncture to final decoded result.
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - renesas,dab-r8a77965     # R-Car M3-N
> > +          - renesas,dab-r8a77990     # R-Car E3
> 
>     Why not renesas,<soc>-dab?

Will change.

Thanks,
Fab

> 
> > +      - const: renesas,rcar-gen3-dab # Generic fallback for R-Car Gen3
> devices
> [...]
> 
> MBR, Sergei

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel