From: stern@rowland.harvard.edu (Alan Stern)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] usb: host: st-hcd: Add USB HCD support for STi SoCs
Date: Mon, 14 Jul 2014 10:58:54 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1407141054010.10763-100000@netrider.rowland.org> (raw)
In-Reply-To: <20140714083549.GK2954@lee--X1>
On Mon, 14 Jul 2014, Lee Jones wrote:
> On Fri, 11 Jul 2014, Alan Stern wrote:
> > On Fri, 11 Jul 2014, Peter Griffin wrote:
> > > On Thu, 10 Jul 2014, Alan Stern wrote:
> > >
> > > > On Thu, 10 Jul 2014, Peter Griffin wrote:
> > > >
> > > > > This driver adds support for the USB HCD present in STi
> > > > > SoC's from STMicroelectronics. It has been tested on the
> > > > > stih416-b2020 board.
> > > >
> > > > This driver file, along with the Kconfig changes, belongs in the
> > > > arch/platform-specific source directory. Not in drivers/usb/host/.
> > > > It is, after all, a platform driver that registers two platform
> > > > devices.
> > >
> > > Why do think that?
> >
> > Because it is true. One can easily see that st-hcd.c is a platform
> > driver: It contains a module_platform_driver() line and a struct
> > platform_driver definition near the end. And it registers a platform
> > device by calling platform_device_add() in st_hcd_device_create(),
> > which is called twice by st_hcd_probe().
>
> You are correct that this is indeed a platform driver and in the 'old
> days' these would have been stuffed into the ARM sub-architecture
> directories. However, these became far too bloated and created too
> much churn which angered Linus. A great deal has changed since his
> ARM rant [1]. All drivers (platform or otherwise) are now to live in
> 'drivers', which makes a great deal of sense really, doesn't it?
>
> Did you grep kernel wide for module_platform_driver()?
>
> $ git grep module_platform_driver -- arch/ | wc -l
> 12
>
> $ git grep module_platform_driver -- drivers/ | wc -l
> 1138
>
> Most platform drivers have already been moved.
Okay, I grant the point. Objections withdrawn. Fix up the spelling
error and the other stuff in the Kconfig help text, and this will be
acceptable.
Alan Stern
next prev parent reply other threads:[~2014-07-14 14:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 15:18 [PATCH 0/3] Add USB HCD support for STi SoCs Peter Griffin
2014-07-10 15:18 ` [PATCH 1/3] usb: host: st-hcd: " Peter Griffin
2014-07-10 18:23 ` Alan Stern
2014-07-11 7:44 ` Peter Griffin
2014-07-11 21:21 ` Alan Stern
2014-07-14 8:35 ` Lee Jones
2014-07-14 14:58 ` Alan Stern [this message]
2014-07-22 13:59 ` Peter Griffin
2014-07-11 8:20 ` Lee Jones
2014-07-24 9:54 ` Peter Griffin
2014-07-10 15:18 ` [PATCH 2/3] usb: host: st-hcd: Add st-hcd devicetree bindings documentation Peter Griffin
2014-07-11 8:24 ` Lee Jones
2014-07-10 15:18 ` [PATCH 3/3] MAINTAINERS: Add st-hcd to ARCH/STI architecture Peter Griffin
2014-07-11 8:21 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.1407141054010.10763-100000@netrider.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).