From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] usb: host: st-hcd: Add st-hcd devicetree bindings documentation.
Date: Fri, 11 Jul 2014 09:24:25 +0100 [thread overview]
Message-ID: <20140711082425.GJ11948@lee--X1> (raw)
In-Reply-To: <1405005486-26355-3-git-send-email-peter.griffin@linaro.org>
On Thu, 10 Jul 2014, Peter Griffin wrote:
> This patch documents the device tree documentation required for
> the ST HCD controller found in STMicroelectronics SoCs.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> Documentation/devicetree/bindings/usb/st-hcd.txt | 51 ++++++++++++++++++++++++
> 1 file changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/st-hcd.txt
Just some nits:
> +Example:
> +
> +usb0: usb at fe100000 {
> + compatible = "st,usb-300x";
> + reg = <0xfe1ffc00 0x100>,
> + <0xfe1ffe00 0x100>;
> + reg-names = "ohci", "ehci";
> +
> + interrupts = <GIC_SPI 148 IRQ_TYPE_NONE>,
> + <GIC_SPI 149 IRQ_TYPE_NONE>;
> + interrupt-names = "ehci","ohci";
s/","/", "
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usb0>;
> + clocks = <&clk_s_a1_ls CLK_ICN_IF_2>,
> + <&clockgen_b0 0>;
> + clock-names = "ic", "ohci";
> +
> + resets = <&powerdown STIH416_USB0_POWERDOWN>,
> + <&softreset STIH416_USB0_SOFTRESET>;
> + reset-names = "power", "softreset";
> +
> + phys = <&usb2_phy>;
> + phy-names = "usb2-phy";
Tabbing of the '='s not consistent.
> +};
> +
> +
Too many '\n' at EOF.
Nothing controversial here, so once this nits are rectified:
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-07-11 8:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 15:18 [PATCH 0/3] Add USB HCD support for STi SoCs Peter Griffin
2014-07-10 15:18 ` [PATCH 1/3] usb: host: st-hcd: " Peter Griffin
2014-07-10 18:23 ` Alan Stern
2014-07-11 7:44 ` Peter Griffin
2014-07-11 21:21 ` Alan Stern
2014-07-14 8:35 ` Lee Jones
2014-07-14 14:58 ` Alan Stern
2014-07-22 13:59 ` Peter Griffin
2014-07-11 8:20 ` Lee Jones
2014-07-24 9:54 ` Peter Griffin
2014-07-10 15:18 ` [PATCH 2/3] usb: host: st-hcd: Add st-hcd devicetree bindings documentation Peter Griffin
2014-07-11 8:24 ` Lee Jones [this message]
2014-07-10 15:18 ` [PATCH 3/3] MAINTAINERS: Add st-hcd to ARCH/STI architecture Peter Griffin
2014-07-11 8:21 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140711082425.GJ11948@lee--X1 \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).