* [PATCH] arm64: defconfig: enable QoriQ dependencies as modules
@ 2020-06-24 14:04 Ard Biesheuvel
2020-06-24 14:50 ` Arnd Bergmann
2020-06-24 15:04 ` Leo Li
0 siblings, 2 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2020-06-24 14:04 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: olof, Ard Biesheuvel, arnd, leoyang.li
The arm64 port adopts a single image policy, and therefore has a single
defconfig that should produce a kernel that can boot on any platform.
Given the shared nature, we typically enable tristate Kconfig options
as modules, unless there is a good reason to enable it as a builtin.
In the case of commit 97c1ed02f765bc89 ("arm64: defconfig: Enable PHY
devices used on QorIQ boards"), this is not really the case, and the
various options are enabled as builtins as a convenience for the NXP
developers that actually work on such boards. This pulls in other
dependencies, such as CRYPTO_AES and CRYPTO_ECB (for MICROSEMI_PHY),
which themselves pull in other pieces of the crypto stack.
Since all the options that this commit enables are tristate, let's
switch them all to =m
Fixes: 97c1ed02f765bc89 ("arm64: defconfig: Enable PHY devices used on QorIQ boards")
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
arch/arm64/configs/defconfig | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 883e8bace3ed..b0c5cf72a4c3 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -318,17 +318,17 @@ CONFIG_STMMAC_ETH=m
CONFIG_TI_K3_AM65_CPSW_NUSS=y
CONFIG_QCOM_IPA=m
CONFIG_MDIO_BUS_MUX_MMIOREG=y
-CONFIG_MDIO_BUS_MUX_MULTIPLEXER=y
-CONFIG_AQUANTIA_PHY=y
+CONFIG_MDIO_BUS_MUX_MULTIPLEXER=m
+CONFIG_AQUANTIA_PHY=m
CONFIG_MARVELL_PHY=m
CONFIG_MARVELL_10G_PHY=m
CONFIG_MESON_GXL_PHY=m
CONFIG_MICREL_PHY=y
-CONFIG_MICROSEMI_PHY=y
+CONFIG_MICROSEMI_PHY=m
CONFIG_AT803X_PHY=y
CONFIG_REALTEK_PHY=m
CONFIG_ROCKCHIP_PHY=y
-CONFIG_VITESSE_PHY=y
+CONFIG_VITESSE_PHY=m
CONFIG_USB_PEGASUS=m
CONFIG_USB_RTL8150=m
CONFIG_USB_RTL8152=m
@@ -951,7 +951,7 @@ CONFIG_OPTEE=y
CONFIG_SLIMBUS=m
CONFIG_SLIM_QCOM_CTRL=m
CONFIG_SLIM_QCOM_NGD_CTRL=m
-CONFIG_MUX_MMIO=y
+CONFIG_MUX_MMIO=m
CONFIG_EXT2_FS=y
CONFIG_EXT3_FS=y
CONFIG_EXT4_FS_POSIX_ACL=y
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: defconfig: enable QoriQ dependencies as modules
2020-06-24 14:04 [PATCH] arm64: defconfig: enable QoriQ dependencies as modules Ard Biesheuvel
@ 2020-06-24 14:50 ` Arnd Bergmann
2020-06-24 14:55 ` Ard Biesheuvel
2020-06-24 15:04 ` Leo Li
1 sibling, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2020-06-24 14:50 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: Olof Johansson, Linux ARM, Leo Li
On Wed, Jun 24, 2020 at 4:04 PM Ard Biesheuvel <ardb@kernel.org> wrote:
>
> The arm64 port adopts a single image policy, and therefore has a single
> defconfig that should produce a kernel that can boot on any platform.
> Given the shared nature, we typically enable tristate Kconfig options
> as modules, unless there is a good reason to enable it as a builtin.
>
> In the case of commit 97c1ed02f765bc89 ("arm64: defconfig: Enable PHY
> devices used on QorIQ boards"), this is not really the case, and the
> various options are enabled as builtins as a convenience for the NXP
> developers that actually work on such boards. This pulls in other
> dependencies, such as CRYPTO_AES and CRYPTO_ECB (for MICROSEMI_PHY),
> which themselves pull in other pieces of the crypto stack.
>
> Since all the options that this commit enables are tristate, let's
> switch them all to =m
>
> Fixes: 97c1ed02f765bc89 ("arm64: defconfig: Enable PHY devices used on QorIQ boards")
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
I assume it's sufficient to apply this in linux-5.9 rather than 5.8, right?
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: defconfig: enable QoriQ dependencies as modules
2020-06-24 14:50 ` Arnd Bergmann
@ 2020-06-24 14:55 ` Ard Biesheuvel
0 siblings, 0 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2020-06-24 14:55 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Olof Johansson, Linux ARM, Leo Li
On Wed, 24 Jun 2020 at 16:51, Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Wed, Jun 24, 2020 at 4:04 PM Ard Biesheuvel <ardb@kernel.org> wrote:
> >
> > The arm64 port adopts a single image policy, and therefore has a single
> > defconfig that should produce a kernel that can boot on any platform.
> > Given the shared nature, we typically enable tristate Kconfig options
> > as modules, unless there is a good reason to enable it as a builtin.
> >
> > In the case of commit 97c1ed02f765bc89 ("arm64: defconfig: Enable PHY
> > devices used on QorIQ boards"), this is not really the case, and the
> > various options are enabled as builtins as a convenience for the NXP
> > developers that actually work on such boards. This pulls in other
> > dependencies, such as CRYPTO_AES and CRYPTO_ECB (for MICROSEMI_PHY),
> > which themselves pull in other pieces of the crypto stack.
> >
> > Since all the options that this commit enables are tristate, let's
> > switch them all to =m
> >
> > Fixes: 97c1ed02f765bc89 ("arm64: defconfig: Enable PHY devices used on QorIQ boards")
> > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> I assume it's sufficient to apply this in linux-5.9 rather than 5.8, right?
>
Whatever you prefer.
Thanks,
Ard.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] arm64: defconfig: enable QoriQ dependencies as modules
2020-06-24 14:04 [PATCH] arm64: defconfig: enable QoriQ dependencies as modules Ard Biesheuvel
2020-06-24 14:50 ` Arnd Bergmann
@ 2020-06-24 15:04 ` Leo Li
1 sibling, 0 replies; 4+ messages in thread
From: Leo Li @ 2020-06-24 15:04 UTC (permalink / raw)
To: Ard Biesheuvel, linux-arm-kernel; +Cc: olof, arnd
> -----Original Message-----
> From: Ard Biesheuvel <ardb@kernel.org>
> Sent: Wednesday, June 24, 2020 9:05 AM
> To: linux-arm-kernel@lists.infradead.org
> Cc: arnd@arndb.de; olof@lixom.net; Leo Li <leoyang.li@nxp.com>; Ard
> Biesheuvel <ardb@kernel.org>
> Subject: [PATCH] arm64: defconfig: enable QoriQ dependencies as modules
>
> The arm64 port adopts a single image policy, and therefore has a single
> defconfig that should produce a kernel that can boot on any platform.
> Given the shared nature, we typically enable tristate Kconfig options
> as modules, unless there is a good reason to enable it as a builtin.
>
> In the case of commit 97c1ed02f765bc89 ("arm64: defconfig: Enable PHY
> devices used on QorIQ boards"), this is not really the case, and the
> various options are enabled as builtins as a convenience for the NXP
> developers that actually work on such boards. This pulls in other
> dependencies, such as CRYPTO_AES and CRYPTO_ECB (for MICROSEMI_PHY),
> which themselves pull in other pieces of the crypto stack.
I agree that this makes it even worse to be enabled as built-in. I will try to change the way of work for NXP developers. If they really need these drivers to be built-in they will need to maintain a config fragment in private to do that.
>
> Since all the options that this commit enables are tristate, let's
> switch them all to =m
>
> Fixes: 97c1ed02f765bc89 ("arm64: defconfig: Enable PHY devices used on
> QorIQ boards")
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Acked-by: Li Yang <leoyang.li@nxp.com>
> ---
> arch/arm64/configs/defconfig | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 883e8bace3ed..b0c5cf72a4c3 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -318,17 +318,17 @@ CONFIG_STMMAC_ETH=m
> CONFIG_TI_K3_AM65_CPSW_NUSS=y
> CONFIG_QCOM_IPA=m
> CONFIG_MDIO_BUS_MUX_MMIOREG=y
> -CONFIG_MDIO_BUS_MUX_MULTIPLEXER=y
> -CONFIG_AQUANTIA_PHY=y
> +CONFIG_MDIO_BUS_MUX_MULTIPLEXER=m
> +CONFIG_AQUANTIA_PHY=m
> CONFIG_MARVELL_PHY=m
> CONFIG_MARVELL_10G_PHY=m
> CONFIG_MESON_GXL_PHY=m
> CONFIG_MICREL_PHY=y
> -CONFIG_MICROSEMI_PHY=y
> +CONFIG_MICROSEMI_PHY=m
> CONFIG_AT803X_PHY=y
> CONFIG_REALTEK_PHY=m
> CONFIG_ROCKCHIP_PHY=y
> -CONFIG_VITESSE_PHY=y
> +CONFIG_VITESSE_PHY=m
> CONFIG_USB_PEGASUS=m
> CONFIG_USB_RTL8150=m
> CONFIG_USB_RTL8152=m
> @@ -951,7 +951,7 @@ CONFIG_OPTEE=y
> CONFIG_SLIMBUS=m
> CONFIG_SLIM_QCOM_CTRL=m
> CONFIG_SLIM_QCOM_NGD_CTRL=m
> -CONFIG_MUX_MMIO=y
> +CONFIG_MUX_MMIO=m
> CONFIG_EXT2_FS=y
> CONFIG_EXT3_FS=y
> CONFIG_EXT4_FS_POSIX_ACL=y
> --
> 2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-24 15:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-24 14:04 [PATCH] arm64: defconfig: enable QoriQ dependencies as modules Ard Biesheuvel
2020-06-24 14:50 ` Arnd Bergmann
2020-06-24 14:55 ` Ard Biesheuvel
2020-06-24 15:04 ` Leo Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).