Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
From: Stefan-gabriel Mirea <stefan-gabriel.mirea@nxp.com>
To: Shawn Guo <shawnguo@kernel.org>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"corbet@lwn.net" <corbet@lwn.net>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"jslaby@suse.com" <jslaby@suse.com>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Leo Li <leoyang.li@nxp.com>,
	Cosmin Stefan Stoica <cosmin.stoica@nxp.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	Dan Nica <dan.nica@nxp.com>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"will@kernel.org" <will@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Larisa Ileana Grigore <larisa.grigore@nxp.com>
Subject: Re: [PATCH v2 3/6] arm64: dts: fsl: Add device tree for S32V234-EVB
Date: Tue, 20 Aug 2019 16:38:34 +0000
Message-ID: <VI1PR0402MB28634C3AEDC11B2CE0C4DE43DFAB0@VI1PR0402MB2863.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20190819085816.GI5999@X250>

Hello Shawn,

Thank you for your suggestions!

On 8/19/2019 11:58 AM, Shawn Guo wrote:
> On Fri, Aug 09, 2019 at 11:29:12AM +0000, Stefan-gabriel Mirea wrote:
>>  .../boot/dts/freescale/fsl-s32v234-evb.dts    |  24 ++++
> 
> The 'fsl-' prefix can be saved here, so that we can distinguish three
> families by starting string: imx??? for i.MX, fsl-??? for LayerScape,
> and s32??? for S32.

All right, I will remove the prefixes.

>> +     model = "Freescale S32V234";
> 
> The 'model' is usually used in board level DTS to describe the board.

I will delete the 'model' property from fsl-s32v234.dtsi and add a
suitable one in fsl-s32v234-evb.dts.

>> +             };
> 
> Please have a newline between nodes.
> 
>> +             cpu1: cpu@1 {

I've got it.

>> +                             interrupts = <0 59 1>;
> 
> Please use GIC_SPI and IRQ_TYPE_xxx defines to make it more readable.

I will use GIC_SPI/GIC_PPI and IRQ_TYPE_xxx/GIC_CPU_MASK_xxx where
applicable.

>> +
>> +     timer {
>> +             compatible = "arm,armv8-timer";
>> +             interrupts = <1 13 0xf08>,
>> +                          <1 14 0xf08>,
>> +                          <1 11 0xf08>,
>> +                          <1 10 0xf08>;
>> +             /* clock-frequency might be modified by u-boot, depending on the
>> +              * chip version.
>> +              */
>> +             clock-frequency = <10000000>;
>> +     };
>> +
>> +     gic: interrupt-controller@7d001000 {
>> +             compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic";
>> +             #interrupt-cells = <3>;
>> +             #address-cells = <0>;
>> +             interrupt-controller;
>> +             reg = <0 0x7d001000 0 0x1000>,
>> +                   <0 0x7d002000 0 0x2000>,
>> +                   <0 0x7d004000 0 0x2000>,
>> +                   <0 0x7d006000 0 0x2000>;
>> +             interrupts = <1 9 0xf04>;
>> +     };
> 
> We usually put these core platform devices prior to 'soc' node.

Sure, I will move the 'timer' and 'interrupt-controller' nodes right
before 'soc'.

Regards,
Stefan

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09 11:29 [PATCH v2 0/6] Add initial support " Stefan-gabriel Mirea
2019-08-09 11:29 ` [PATCH v2 1/6] dt-bindings: arm: fsl: Add the S32V234-EVB board Stefan-gabriel Mirea
2019-08-12 18:58   ` Rob Herring
2019-08-09 11:29 ` [PATCH v2 2/6] arm64: Introduce config for S32 Stefan-gabriel Mirea
2019-08-19  8:14   ` Shawn Guo
2019-08-20 16:38     ` Stefan-gabriel Mirea
2019-08-09 11:29 ` [PATCH v2 3/6] arm64: dts: fsl: Add device tree for S32V234-EVB Stefan-gabriel Mirea
2019-08-19  8:58   ` Shawn Guo
2019-08-20 16:38     ` Stefan-gabriel Mirea [this message]
2019-08-09 11:29 ` [PATCH v2 4/6] dt-bindings: serial: Document Freescale LINFlex UART Stefan-gabriel Mirea
2019-08-21 21:18   ` Rob Herring
2019-08-22 17:41     ` Stefan-gabriel Mirea
2019-08-09 11:29 ` [PATCH v2 5/6] tty: serial: Add linflexuart driver for S32V234 Stefan-gabriel Mirea
2019-08-09 11:29 ` [PATCH v2 6/6] arm64: defconfig: Enable configs " Stefan-gabriel Mirea

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR0402MB28634C3AEDC11B2CE0C4DE43DFAB0@VI1PR0402MB2863.eurprd04.prod.outlook.com \
    --to=stefan-gabriel.mirea@nxp.com \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=cosmin.stoica@nxp.com \
    --cc=dan.nica@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=larisa.grigore@nxp.com \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git