* [PATCH] clk: imx: remove redundant assignment to pointer np
@ 2020-10-29 22:40 Colin King
2020-10-30 3:27 ` Aisheng Dong
2020-11-01 9:27 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2020-10-29 22:40 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
linux-clk, linux-arm-kernel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer np is being initialized with a value that is never read
and it is being updated with a value later on. The initialization
is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/clk/imx/clk-imx8mp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c
index 12ce4770f702..3cb2bc46eae0 100644
--- a/drivers/clk/imx/clk-imx8mp.c
+++ b/drivers/clk/imx/clk-imx8mp.c
@@ -425,7 +425,7 @@ static struct clk **uart_clks[ARRAY_SIZE(uart_clk_ids) + 1];
static int imx8mp_clocks_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
- struct device_node *np = dev->of_node;
+ struct device_node *np;
void __iomem *anatop_base, *ccm_base;
int i;
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] clk: imx: remove redundant assignment to pointer np
2020-10-29 22:40 [PATCH] clk: imx: remove redundant assignment to pointer np Colin King
@ 2020-10-30 3:27 ` Aisheng Dong
2020-11-01 9:27 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Aisheng Dong @ 2020-10-30 3:27 UTC (permalink / raw)
To: Colin King, Michael Turquette, Stephen Boyd, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
dl-linux-imx, linux-clk, linux-arm-kernel
Cc: kernel-janitors, linux-kernel
> From: Colin King <colin.king@canonical.com>
> Sent: Friday, October 30, 2020 6:40 AM
>
> Pointer np is being initialized with a value that is never read and it is being
> updated with a value later on. The initialization is redundant and can be
> removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Regards
Aisheng
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: imx: remove redundant assignment to pointer np
2020-10-29 22:40 [PATCH] clk: imx: remove redundant assignment to pointer np Colin King
2020-10-30 3:27 ` Aisheng Dong
@ 2020-11-01 9:27 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2020-11-01 9:27 UTC (permalink / raw)
To: Colin King
Cc: Stephen Boyd, Michael Turquette, kernel-janitors, linux-kernel,
linux-clk, NXP Linux Team, Pengutronix Kernel Team,
Fabio Estevam, Sascha Hauer, linux-arm-kernel
On Thu, Oct 29, 2020 at 10:40:07PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer np is being initialized with a value that is never read
> and it is being updated with a value later on. The initialization
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-01 9:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-29 22:40 [PATCH] clk: imx: remove redundant assignment to pointer np Colin King
2020-10-30 3:27 ` Aisheng Dong
2020-11-01 9:27 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).