* [PATCH 2/2] mmc: sdhci-sprd: use sdhci_sprd_writew
2021-06-01 9:54 [PATCH 1/2] mmc: sdhci-esdhc-imx: remove unused is_imx6q_usdhc Krzysztof Kozlowski
@ 2021-06-01 9:54 ` Krzysztof Kozlowski
2021-06-08 13:16 ` Ulf Hansson
2021-06-01 11:59 ` [PATCH 1/2] mmc: sdhci-esdhc-imx: remove unused is_imx6q_usdhc Bough Chen
2021-06-08 13:16 ` Ulf Hansson
2 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2021-06-01 9:54 UTC (permalink / raw)
To: Adrian Hunter, Ulf Hansson, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Orson Zhai, Baolin Wang, Chunyan Zhang, linux-mmc,
linux-arm-kernel, linux-kernel
Cc: Krzysztof Kozlowski, kernel test robot
The sdhci_sprd_writew() was defined by never used in sdhci_ops:
drivers/mmc/host/sdhci-sprd.c:134:20: warning: unused function 'sdhci_sprd_writew'
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
drivers/mmc/host/sdhci-sprd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
index 5dc36efff47f..11e375579cfb 100644
--- a/drivers/mmc/host/sdhci-sprd.c
+++ b/drivers/mmc/host/sdhci-sprd.c
@@ -393,6 +393,7 @@ static void sdhci_sprd_request_done(struct sdhci_host *host,
static struct sdhci_ops sdhci_sprd_ops = {
.read_l = sdhci_sprd_readl,
.write_l = sdhci_sprd_writel,
+ .write_w = sdhci_sprd_writew,
.write_b = sdhci_sprd_writeb,
.set_clock = sdhci_sprd_set_clock,
.get_max_clock = sdhci_sprd_get_max_clock,
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] mmc: sdhci-sprd: use sdhci_sprd_writew
2021-06-01 9:54 ` [PATCH 2/2] mmc: sdhci-sprd: use sdhci_sprd_writew Krzysztof Kozlowski
@ 2021-06-08 13:16 ` Ulf Hansson
0 siblings, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2021-06-08 13:16 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Adrian Hunter, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Orson Zhai, Baolin Wang,
Chunyan Zhang, linux-mmc, Linux ARM, Linux Kernel Mailing List,
kernel test robot
On Tue, 1 Jun 2021 at 11:54, Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> The sdhci_sprd_writew() was defined by never used in sdhci_ops:
>
> drivers/mmc/host/sdhci-sprd.c:134:20: warning: unused function 'sdhci_sprd_writew'
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-sprd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
> index 5dc36efff47f..11e375579cfb 100644
> --- a/drivers/mmc/host/sdhci-sprd.c
> +++ b/drivers/mmc/host/sdhci-sprd.c
> @@ -393,6 +393,7 @@ static void sdhci_sprd_request_done(struct sdhci_host *host,
> static struct sdhci_ops sdhci_sprd_ops = {
> .read_l = sdhci_sprd_readl,
> .write_l = sdhci_sprd_writel,
> + .write_w = sdhci_sprd_writew,
> .write_b = sdhci_sprd_writeb,
> .set_clock = sdhci_sprd_set_clock,
> .get_max_clock = sdhci_sprd_get_max_clock,
> --
> 2.27.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 1/2] mmc: sdhci-esdhc-imx: remove unused is_imx6q_usdhc
2021-06-01 9:54 [PATCH 1/2] mmc: sdhci-esdhc-imx: remove unused is_imx6q_usdhc Krzysztof Kozlowski
2021-06-01 9:54 ` [PATCH 2/2] mmc: sdhci-sprd: use sdhci_sprd_writew Krzysztof Kozlowski
@ 2021-06-01 11:59 ` Bough Chen
2021-06-08 13:16 ` Ulf Hansson
2 siblings, 0 replies; 5+ messages in thread
From: Bough Chen @ 2021-06-01 11:59 UTC (permalink / raw)
To: Krzysztof Kozlowski, Adrian Hunter, Ulf Hansson, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
dl-linux-imx, Orson Zhai, Baolin Wang, Chunyan Zhang, linux-mmc,
linux-arm-kernel, linux-kernel
Cc: kernel test robot
[-- Attachment #1.1: Type: text/plain, Size: 1942 bytes --]
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com]
> Sent: 2021年6月1日 17:54
> To: Adrian Hunter <adrian.hunter@intel.com>; Ulf Hansson
> <ulf.hansson@linaro.org>; Shawn Guo <shawnguo@kernel.org>; Sascha
> Hauer <s.hauer@pengutronix.de>; Pengutronix Kernel Team
> <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>;
> dl-linux-imx <linux-imx@nxp.com>; Orson Zhai <orsonzhai@gmail.com>;
> Baolin Wang <baolin.wang7@gmail.com>; Chunyan Zhang
> <zhang.lyra@gmail.com>; linux-mmc@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>; kernel test
> robot <lkp@intel.com>
> Subject: [PATCH 1/2] mmc: sdhci-esdhc-imx: remove unused is_imx6q_usdhc
>
> The is_imx6q_usdhc() function is unused:
>
> drivers/mmc/host/sdhci-esdhc-imx.c:343:19: warning: unused function
> 'is_imx6q_usdhc'
Reviewed-by: Haibo Chen <haibo.chen@nxp.com>
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: f47c4bbfa283 ("mmc: sdhci-esdhc-imx: create struct esdhc_soc_data")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> drivers/mmc/host/sdhci-esdhc-imx.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c
> b/drivers/mmc/host/sdhci-esdhc-imx.c
> index fba4a963d12e..7336ae749137 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -324,11 +324,6 @@ static inline int is_imx53_esdhc(struct
> pltfm_imx_data *data)
> return data->socdata == &esdhc_imx53_data; }
>
> -static inline int is_imx6q_usdhc(struct pltfm_imx_data *data) -{
> - return data->socdata == &usdhc_imx6q_data;
> -}
> -
> static inline int esdhc_is_usdhc(struct pltfm_imx_data *data) {
> return !!(data->socdata->flags & ESDHC_FLAG_USDHC);
> --
> 2.27.0
[-- Attachment #1.2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 9571 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] mmc: sdhci-esdhc-imx: remove unused is_imx6q_usdhc
2021-06-01 9:54 [PATCH 1/2] mmc: sdhci-esdhc-imx: remove unused is_imx6q_usdhc Krzysztof Kozlowski
2021-06-01 9:54 ` [PATCH 2/2] mmc: sdhci-sprd: use sdhci_sprd_writew Krzysztof Kozlowski
2021-06-01 11:59 ` [PATCH 1/2] mmc: sdhci-esdhc-imx: remove unused is_imx6q_usdhc Bough Chen
@ 2021-06-08 13:16 ` Ulf Hansson
2 siblings, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2021-06-08 13:16 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Adrian Hunter, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Orson Zhai, Baolin Wang,
Chunyan Zhang, linux-mmc, Linux ARM, Linux Kernel Mailing List,
kernel test robot
On Tue, 1 Jun 2021 at 11:54, Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> The is_imx6q_usdhc() function is unused:
>
> drivers/mmc/host/sdhci-esdhc-imx.c:343:19: warning: unused function 'is_imx6q_usdhc'
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: f47c4bbfa283 ("mmc: sdhci-esdhc-imx: create struct esdhc_soc_data")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-esdhc-imx.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index fba4a963d12e..7336ae749137 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -324,11 +324,6 @@ static inline int is_imx53_esdhc(struct pltfm_imx_data *data)
> return data->socdata == &esdhc_imx53_data;
> }
>
> -static inline int is_imx6q_usdhc(struct pltfm_imx_data *data)
> -{
> - return data->socdata == &usdhc_imx6q_data;
> -}
> -
> static inline int esdhc_is_usdhc(struct pltfm_imx_data *data)
> {
> return !!(data->socdata->flags & ESDHC_FLAG_USDHC);
> --
> 2.27.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread