linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/2] phy: ti: phy-j721e-wiz: add j721s2 support
@ 2022-11-23  3:24 Matt Ranostay
  2022-11-23  3:24 ` [PATCH v2 1/2] dt-bindings: phy-j721e-wiz: add j721s2 compatible string Matt Ranostay
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Matt Ranostay @ 2022-11-23  3:24 UTC (permalink / raw)
  To: r-gunasekaran, rogerq, vkoul, robh+dt, krzysztof.kozlowski+dt, vigneshr
  Cc: linux-phy, devicetree, linux-arm-kernel, Matt Ranostay

Add support for j721s2 support for phy-j721e-wiz module.

Changes from v1:
* Re-order new compatible within yaml documentation

Matt Ranostay (2):
  dt-bindings: phy-j721e-wiz: add j721s2 compatible string
  phy: ti: phy-j721e-wiz: add j721s2-wiz-10g module support

 .../bindings/phy/ti,phy-j721e-wiz.yaml           |  1 +
 drivers/phy/ti/phy-j721e-wiz.c                   | 16 ++++++++++++++++
 2 files changed, 17 insertions(+)

-- 
2.38.GIT


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 1/2] dt-bindings: phy-j721e-wiz: add j721s2 compatible string
  2022-11-23  3:24 [PATCH v2 0/2] phy: ti: phy-j721e-wiz: add j721s2 support Matt Ranostay
@ 2022-11-23  3:24 ` Matt Ranostay
  2022-11-23  8:54   ` Krzysztof Kozlowski
  2022-11-23  3:24 ` [PATCH v2 2/2] phy: ti: phy-j721e-wiz: add j721s2-wiz-10g module support Matt Ranostay
  2022-11-24 18:11 ` [PATCH v2 0/2] phy: ti: phy-j721e-wiz: add j721s2 support Vinod Koul
  2 siblings, 1 reply; 6+ messages in thread
From: Matt Ranostay @ 2022-11-23  3:24 UTC (permalink / raw)
  To: r-gunasekaran, rogerq, vkoul, robh+dt, krzysztof.kozlowski+dt, vigneshr
  Cc: linux-phy, devicetree, linux-arm-kernel, Matt Ranostay

Add ti,j721s2-wiz-10g compatible string to binding documentation.

Signed-off-by: Matt Ranostay <mranostay@ti.com>
---
 Documentation/devicetree/bindings/phy/ti,phy-j721e-wiz.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/phy/ti,phy-j721e-wiz.yaml b/Documentation/devicetree/bindings/phy/ti,phy-j721e-wiz.yaml
index a9e38739c010..c54b36c104ab 100644
--- a/Documentation/devicetree/bindings/phy/ti,phy-j721e-wiz.yaml
+++ b/Documentation/devicetree/bindings/phy/ti,phy-j721e-wiz.yaml
@@ -15,6 +15,7 @@ properties:
     enum:
       - ti,j721e-wiz-16g
       - ti,j721e-wiz-10g
+      - ti,j721s2-wiz-10g
       - ti,am64-wiz-10g
       - ti,j7200-wiz-10g
       - ti,j784s4-wiz-10g
-- 
2.38.GIT


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 2/2] phy: ti: phy-j721e-wiz: add j721s2-wiz-10g module support
  2022-11-23  3:24 [PATCH v2 0/2] phy: ti: phy-j721e-wiz: add j721s2 support Matt Ranostay
  2022-11-23  3:24 ` [PATCH v2 1/2] dt-bindings: phy-j721e-wiz: add j721s2 compatible string Matt Ranostay
@ 2022-11-23  3:24 ` Matt Ranostay
  2022-11-23  8:29   ` Roger Quadros
  2022-11-24 18:11 ` [PATCH v2 0/2] phy: ti: phy-j721e-wiz: add j721s2 support Vinod Koul
  2 siblings, 1 reply; 6+ messages in thread
From: Matt Ranostay @ 2022-11-23  3:24 UTC (permalink / raw)
  To: r-gunasekaran, rogerq, vkoul, robh+dt, krzysztof.kozlowski+dt, vigneshr
  Cc: linux-phy, devicetree, linux-arm-kernel, Matt Ranostay

Add support for j721s2-wiz-10g device which is similar to j721e-wiz-10g but
uses clock-names interface versus explicitly defining clock nodes within
device tree node.

Signed-off-by: Matt Ranostay <mranostay@ti.com>
---
 drivers/phy/ti/phy-j721e-wiz.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c
index 141b51af4427..ddce5ef7711c 100644
--- a/drivers/phy/ti/phy-j721e-wiz.c
+++ b/drivers/phy/ti/phy-j721e-wiz.c
@@ -322,6 +322,7 @@ enum wiz_type {
 	AM64_WIZ_10G,
 	J7200_WIZ_10G,  /* J7200 SR2.0 */
 	J784S4_WIZ_10G,
+	J721S2_WIZ_10G,
 };
 
 struct wiz_data {
@@ -1000,6 +1001,7 @@ static void wiz_clock_cleanup(struct wiz *wiz, struct device_node *node)
 	case AM64_WIZ_10G:
 	case J7200_WIZ_10G:
 	case J784S4_WIZ_10G:
+	case J721S2_WIZ_10G:
 		of_clk_del_provider(dev->of_node);
 		return;
 	default:
@@ -1132,6 +1134,7 @@ static int wiz_clock_init(struct wiz *wiz, struct device_node *node)
 	case AM64_WIZ_10G:
 	case J7200_WIZ_10G:
 	case J784S4_WIZ_10G:
+	case J721S2_WIZ_10G:
 		ret = wiz_clock_register(wiz);
 		if (ret)
 			dev_err(dev, "Failed to register wiz clocks\n");
@@ -1214,6 +1217,7 @@ static int wiz_phy_fullrt_div(struct wiz *wiz, int lane)
 		break;
 	case J721E_WIZ_10G:
 	case J7200_WIZ_10G:
+	case J721S2_WIZ_10G:
 		if (wiz->lane_phy_type[lane] == PHY_TYPE_SGMII)
 			return regmap_field_write(wiz->p0_fullrt_div[lane], 0x2);
 		break;
@@ -1318,6 +1322,15 @@ static struct wiz_data j784s4_10g_data = {
 	.clk_div_sel_num = WIZ_DIV_NUM_CLOCKS_10G,
 };
 
+static struct wiz_data j721s2_10g_data = {
+	.type = J721S2_WIZ_10G,
+	.pll0_refclk_mux_sel = &pll0_refclk_mux_sel,
+	.pll1_refclk_mux_sel = &pll1_refclk_mux_sel,
+	.refclk_dig_sel = &refclk_dig_sel_10g,
+	.clk_mux_sel = clk_mux_sel_10g,
+	.clk_div_sel_num = WIZ_DIV_NUM_CLOCKS_10G,
+};
+
 static const struct of_device_id wiz_id_table[] = {
 	{
 		.compatible = "ti,j721e-wiz-16g", .data = &j721e_16g_data,
@@ -1334,6 +1347,9 @@ static const struct of_device_id wiz_id_table[] = {
 	{
 		.compatible = "ti,j784s4-wiz-10g", .data = &j784s4_10g_data,
 	},
+	{
+		.compatible = "ti,j721s2-wiz-10g", .data = &j721s2_10g_data,
+	},
 	{}
 };
 MODULE_DEVICE_TABLE(of, wiz_id_table);
-- 
2.38.GIT


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 2/2] phy: ti: phy-j721e-wiz: add j721s2-wiz-10g module support
  2022-11-23  3:24 ` [PATCH v2 2/2] phy: ti: phy-j721e-wiz: add j721s2-wiz-10g module support Matt Ranostay
@ 2022-11-23  8:29   ` Roger Quadros
  0 siblings, 0 replies; 6+ messages in thread
From: Roger Quadros @ 2022-11-23  8:29 UTC (permalink / raw)
  To: Matt Ranostay, r-gunasekaran, vkoul, robh+dt,
	krzysztof.kozlowski+dt, vigneshr
  Cc: linux-phy, devicetree, linux-arm-kernel



On 23/11/2022 05:24, Matt Ranostay wrote:
> Add support for j721s2-wiz-10g device which is similar to j721e-wiz-10g but
> uses clock-names interface versus explicitly defining clock nodes within
> device tree node.
> 
> Signed-off-by: Matt Ranostay <mranostay@ti.com>
> ---

Reviewed-by: Roger Quadros <rogerq@kernel.org>

>  drivers/phy/ti/phy-j721e-wiz.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c
> index 141b51af4427..ddce5ef7711c 100644
> --- a/drivers/phy/ti/phy-j721e-wiz.c
> +++ b/drivers/phy/ti/phy-j721e-wiz.c
> @@ -322,6 +322,7 @@ enum wiz_type {
>  	AM64_WIZ_10G,
>  	J7200_WIZ_10G,  /* J7200 SR2.0 */
>  	J784S4_WIZ_10G,
> +	J721S2_WIZ_10G,
>  };
>  
>  struct wiz_data {
> @@ -1000,6 +1001,7 @@ static void wiz_clock_cleanup(struct wiz *wiz, struct device_node *node)
>  	case AM64_WIZ_10G:
>  	case J7200_WIZ_10G:
>  	case J784S4_WIZ_10G:
> +	case J721S2_WIZ_10G:
>  		of_clk_del_provider(dev->of_node);
>  		return;
>  	default:
> @@ -1132,6 +1134,7 @@ static int wiz_clock_init(struct wiz *wiz, struct device_node *node)
>  	case AM64_WIZ_10G:
>  	case J7200_WIZ_10G:
>  	case J784S4_WIZ_10G:
> +	case J721S2_WIZ_10G:
>  		ret = wiz_clock_register(wiz);
>  		if (ret)
>  			dev_err(dev, "Failed to register wiz clocks\n");
> @@ -1214,6 +1217,7 @@ static int wiz_phy_fullrt_div(struct wiz *wiz, int lane)
>  		break;
>  	case J721E_WIZ_10G:
>  	case J7200_WIZ_10G:
> +	case J721S2_WIZ_10G:
>  		if (wiz->lane_phy_type[lane] == PHY_TYPE_SGMII)
>  			return regmap_field_write(wiz->p0_fullrt_div[lane], 0x2);
>  		break;
> @@ -1318,6 +1322,15 @@ static struct wiz_data j784s4_10g_data = {
>  	.clk_div_sel_num = WIZ_DIV_NUM_CLOCKS_10G,
>  };
>  
> +static struct wiz_data j721s2_10g_data = {
> +	.type = J721S2_WIZ_10G,
> +	.pll0_refclk_mux_sel = &pll0_refclk_mux_sel,
> +	.pll1_refclk_mux_sel = &pll1_refclk_mux_sel,
> +	.refclk_dig_sel = &refclk_dig_sel_10g,
> +	.clk_mux_sel = clk_mux_sel_10g,
> +	.clk_div_sel_num = WIZ_DIV_NUM_CLOCKS_10G,
> +};
> +
>  static const struct of_device_id wiz_id_table[] = {
>  	{
>  		.compatible = "ti,j721e-wiz-16g", .data = &j721e_16g_data,
> @@ -1334,6 +1347,9 @@ static const struct of_device_id wiz_id_table[] = {
>  	{
>  		.compatible = "ti,j784s4-wiz-10g", .data = &j784s4_10g_data,
>  	},
> +	{
> +		.compatible = "ti,j721s2-wiz-10g", .data = &j721s2_10g_data,
> +	},
>  	{}
>  };
>  MODULE_DEVICE_TABLE(of, wiz_id_table);

--
cheers,
-roger

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: phy-j721e-wiz: add j721s2 compatible string
  2022-11-23  3:24 ` [PATCH v2 1/2] dt-bindings: phy-j721e-wiz: add j721s2 compatible string Matt Ranostay
@ 2022-11-23  8:54   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-23  8:54 UTC (permalink / raw)
  To: Matt Ranostay, r-gunasekaran, rogerq, vkoul, robh+dt,
	krzysztof.kozlowski+dt, vigneshr
  Cc: linux-phy, devicetree, linux-arm-kernel

On 23/11/2022 04:24, Matt Ranostay wrote:
> Add ti,j721s2-wiz-10g compatible string to binding documentation.
> 
> Signed-off-by: Matt Ranostay <mranostay@ti.com>
> ---
>  Documentation/devicetree/bindings/phy/ti,phy-j721e-wiz.yam


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 0/2] phy: ti: phy-j721e-wiz: add j721s2 support
  2022-11-23  3:24 [PATCH v2 0/2] phy: ti: phy-j721e-wiz: add j721s2 support Matt Ranostay
  2022-11-23  3:24 ` [PATCH v2 1/2] dt-bindings: phy-j721e-wiz: add j721s2 compatible string Matt Ranostay
  2022-11-23  3:24 ` [PATCH v2 2/2] phy: ti: phy-j721e-wiz: add j721s2-wiz-10g module support Matt Ranostay
@ 2022-11-24 18:11 ` Vinod Koul
  2 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2022-11-24 18:11 UTC (permalink / raw)
  To: Matt Ranostay
  Cc: r-gunasekaran, rogerq, robh+dt, krzysztof.kozlowski+dt, vigneshr,
	linux-phy, devicetree, linux-arm-kernel

On 22-11-22, 19:24, Matt Ranostay wrote:
> Add support for j721s2 support for phy-j721e-wiz module.

Applied, thanks

-- 
~Vinod

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-11-24 18:12 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-23  3:24 [PATCH v2 0/2] phy: ti: phy-j721e-wiz: add j721s2 support Matt Ranostay
2022-11-23  3:24 ` [PATCH v2 1/2] dt-bindings: phy-j721e-wiz: add j721s2 compatible string Matt Ranostay
2022-11-23  8:54   ` Krzysztof Kozlowski
2022-11-23  3:24 ` [PATCH v2 2/2] phy: ti: phy-j721e-wiz: add j721s2-wiz-10g module support Matt Ranostay
2022-11-23  8:29   ` Roger Quadros
2022-11-24 18:11 ` [PATCH v2 0/2] phy: ti: phy-j721e-wiz: add j721s2 support Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).