* [PATCH v1 1/1] pinctrl: digicolor: Remove duplicate assignment of of_gpio_n_cells
@ 2023-01-12 18:43 Andy Shevchenko
2023-01-13 14:32 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2023-01-12 18:43 UTC (permalink / raw)
To: Andy Shevchenko, linux-gpio, linux-arm-kernel, linux-kernel
Cc: Linus Walleij, Baruch Siach
The of_gpio_n_cells default is 2 when ->of_xlate() callback is
not defined. No need to assign it explicitly in the driver.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/pinctrl-digicolor.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-digicolor.c b/drivers/pinctrl/pinctrl-digicolor.c
index cc3546fc4610..05213261b8a4 100644
--- a/drivers/pinctrl/pinctrl-digicolor.c
+++ b/drivers/pinctrl/pinctrl-digicolor.c
@@ -248,7 +248,6 @@ static int dc_gpiochip_add(struct dc_pinmap *pmap)
chip->set = dc_gpio_set;
chip->base = -1;
chip->ngpio = PINS_COUNT;
- chip->of_gpio_n_cells = 2;
spin_lock_init(&pmap->lock);
--
2.39.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] pinctrl: digicolor: Remove duplicate assignment of of_gpio_n_cells
2023-01-12 18:43 [PATCH v1 1/1] pinctrl: digicolor: Remove duplicate assignment of of_gpio_n_cells Andy Shevchenko
@ 2023-01-13 14:32 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2023-01-13 14:32 UTC (permalink / raw)
To: linux-gpio, linux-arm-kernel, linux-kernel; +Cc: Linus Walleij, Baruch Siach
On Thu, Jan 12, 2023 at 08:43:47PM +0200, Andy Shevchenko wrote:
> The of_gpio_n_cells default is 2 when ->of_xlate() callback is
> not defined. No need to assign it explicitly in the driver.
Ignore this one, it has been (re-)sent as a part of the series which needs
an update, so look forward to the v2 of that one.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-13 14:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-12 18:43 [PATCH v1 1/1] pinctrl: digicolor: Remove duplicate assignment of of_gpio_n_cells Andy Shevchenko
2023-01-13 14:32 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).